From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3A2E9A05D3 for ; Sat, 30 Mar 2019 15:29:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DF694C91; Sat, 30 Mar 2019 15:29:39 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 127FE3977 for ; Sat, 30 Mar 2019 15:29:38 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C4B3E21448; Sat, 30 Mar 2019 10:29:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 30 Mar 2019 10:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=xWvxpxYA4e8cjOciZKdQajt62HCxtWdxDv6rvqdarNE=; b=jBzjFhE5kUXJ oUmzMBGdpBjj7fr7KPUO9Sp7tiCgeqgHO1NX9feQZ/pYpSshELzwqWhN7o+028Gk eIqChrFh1qDJDSalHl+XR4fd9lQ1t3HGt33mZ8fRQo6vCTfQAM65vBCU3uFIHcQw mddu8yhfrJYoJBmogoy0qr7fm8mSma4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xWvxpxYA4e8cjOciZKdQajt62HCxtWdxDv6rvqdar NE=; b=Qpa/XGR1sE4sjK2Nt9s0L4PTardpSUkz1QjhdKxb08O/VUXovTYJN6d4f ZaP4iw8NfrZPcO7PxF5gkL9y8k9NxXHU3d/T+neBASt/OTEKq3YZ2QsSMy/v85z9 lSwyoEG24psgYndNWSTNqJLrNEqCpmGEWKGrYGYs2BnTSSfK/Epyicn7rmqB/8fh xe7pp/N2gCxhlaqccDKJMrwrNINZ000XktbQ2EMluAA2kkPLRT/pfQ4dDDHv7tRM 6sQG4qyVArTka3A4tI4tF3GynNDhnYSml+nteIzvIqHm1KU1Bm92Rd/WZOCp9aAQ ClukC3AUsQB+U/4AKTJaFW8RodqJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeelgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AB6F210316; Sat, 30 Mar 2019 10:29:34 -0400 (EDT) From: Thomas Monjalon To: Shahaf Shuler Cc: dev@dpdk.org, anatoly.burakov@intel.com, yskoh@mellanox.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com, gaetan.rivet@6wind.com Date: Sat, 30 Mar 2019 15:29:32 +0100 Message-ID: <2126544.BhJDSFOOTj@xps> In-Reply-To: <1932739.UiCEsj7Gze@xps> References: <828c4b2a57c5f6c4753898a6d3e96f0f9ded8171.1552206210.git.shahafs@mellanox.com> <1932739.UiCEsj7Gze@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/6] vfio: allow DMA map of memory for the default vfio fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190330142932.G-Tq6e76ypgT0WA2nU3LAM5zXT7tGeNuiwmHc0DC1AQ@z> 30/03/2019 01:23, Thomas Monjalon: > 10/03/2019 09:27, Shahaf Shuler: > > Enable users the option to call rte_vfio_dma_map with request to map > > to the default vfio fd. > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Anatoly Burakov > > --- > > --- a/doc/guides/rel_notes/release_19_05.rst > > +++ b/doc/guides/rel_notes/release_19_05.rst > > @@ -136,6 +136,9 @@ ABI Changes > > +* vfio: Functions ``rte_vfio_container_dma_map`` and > > + ``rte_vfio_container_dma_unmap`` have been extended with an option to > > + request mapping or un-mapping to the default vfio container fd. > > Isn't it an API change rather than ABI? > It is adding -1 as a special value, I think it is not breaking > previous interface, and does not require a notification in the release notes. I will move it to the "API changes" section.