From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6462AA05D3 for ; Sun, 31 Mar 2019 00:57:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35AF11DB8; Sun, 31 Mar 2019 00:57:18 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id CF15D11A4 for ; Sun, 31 Mar 2019 00:57:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8708836E2; Sat, 30 Mar 2019 19:57:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 30 Mar 2019 19:57:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gK5mNNGLhU1Y3vESjXtze3Q5skInbyw2CaP6RRAZO60=; b=Lq1AffEaNz5K GcCJK5Jjf3YAbm/ozoGyB9/uWB3jiWDhWGZ9h3tHTxrq0Ojkbs7/U2hkhWnWx2EA 77adyvBjVFBt2on+YGtdzQAIBLAfPWIBEf23Jmi5afEmk1ukfO7VwNDFvE5+8+PB WyIyftjZBl1PBTqwxXPf0hhZEiIlw9c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gK5mNNGLhU1Y3vESjXtze3Q5skInbyw2CaP6RRAZO 60=; b=Rbt/jQAoN+9d25g8hMEl1J8M7Pi+FcFf0rFTjEmyu3F+S/0C3H602JuHn 28psJF+i+n5p9UNi+BKsFUo1IoR87iIpkl6jqSh7LVcxGP93OaRVbOiLqGa1CHmq U6rEQzmlIW2TgnyWii2LbfcvaNyBMV2tD4eHrORKqh3uJg5pYNopgHReMEbE9Xi/ 8qnPaThN8d/ou0AXTJYR7sVKv8DHTBWrm2SiWfkJviT3Xg+FGH1cd7aMtS7E51zu xZbeIhdhGps+GnFyVnsKfMGfhorXiBdhfR6zQ/oJITrXKpgxT37/nhuZrMHruLuc 8DIfXAMPOkwW+XbKBj7ZQB+bwCC4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrledtgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A0E0FE442F; Sat, 30 Mar 2019 19:57:13 -0400 (EDT) From: Thomas Monjalon To: Natanael Copa Cc: dev@dpdk.org Date: Sun, 31 Mar 2019 00:57:10 +0100 Message-ID: <18966392.1bK43UoomU@xps> In-Reply-To: <20190313170657.16688-1-ncopa@alpinelinux.org> References: <20190313170657.16688-1-ncopa@alpinelinux.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/15] Build fixes for musl libc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190330235710.BLXq4OY1HmPS3gRUvZBviOvUSd8s9A8RttuW9bQs6tw@z> 13/03/2019 18:06, Natanael Copa: > A set of patches to fix build with musl libc. I also did a few cleanups wrt > macros and fixed a few scary compiler warnings while at it. > > Please note that those are only compile tested on x86_64 with musl libc. > > v2 has some code style fixes reported by checkpatch > v3 is a full reroll of the entire patch set to enable automatted tests > and logic for patchwork patchset. > > Natanael Copa (15): > app/testpmd: replace uint with unsigned int > net/cxgbe: replace uint with unsigned int > bus/pci: add fallback for out[lwb]_p for non GNU libc > bus/pci: factor out various ifdefs in pci_uio_ioport_{read,write} > bus/fslmc: fix compile error with musl libc > bus/fslmc: remove unused include of error.h > net/nfp: build fix for musl libc > app/test: include fcntl.h due to use of O_RDONLY > app/test: fix setting of -D_GNU_SOURCE with meson > bus/dpaa: use warn(3) instead of error(3) to improve portability > bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0 > crypto/dpaa2_sec: build fix for musl libc > crypto/dpaa2_sec: simplify pr_{debug,err,warn} macros > net/netvsc: fix compile warning for fcntl.h include > eal/linux: simplify debug message in sigbus_handler Thanks for the cleanup. Some patches may deserve more reviews. If you send a new version, please use --to-cmd devtools/get-maintainer.sh so the maintainers will be Cc'ed. All these patches are fixes and may be interesting to backport them in the latest LTS or other stable releases. In order to help with backporting, please fill "Fixes:" tag and add Cc: stable when relevant. The exact recommendation is described in this doc chapter: http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body In order to help, I already fixed 7 commit messages and merged them. The remaining patches, requiring a v4, are: app/testpmd: replace uint with unsigned int net/cxgbe: replace uint with unsigned int bus/pci: add fallback for out[lwb]_p for non GNU libc bus/pci: factor out various ifdefs in pci_uio_ioport_{read,write} bus/dpaa: use warn(3) instead of error(3) to improve portability bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0 crypto/dpaa2_sec: build fix for musl libc crypto/dpaa2_sec: simplify pr_{debug,err,warn} macros