DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators
Date: Mon, 01 Apr 2019 03:59:45 +0200	[thread overview]
Message-ID: <2318869.vaV4MP09YM@xps> (raw)
Message-ID: <20190401015945.XfMNC7RXAqyEnw1mfX1ONk7vmfl_gLfW43j7GwRKc9U@z> (raw)
In-Reply-To: <5809024.HDbGbE6FtF@xps>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 1387 bytes --]

27/02/2019 11:51, Thomas Monjalon:
> 27/02/2019 11:07, Gaëtan Rivet:
> > On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote:
> > > +uint16_t __rte_experimental
> > > +rte_eth_find_next_of(uint16_t port_id, const struct rte_device *parent)
> > > +{
> > > +	while (port_id < RTE_MAX_ETHPORTS &&
> > > +			rte_eth_devices[port_id].state == RTE_ETH_DEV_UNUSED &&
> > > +			rte_eth_devices[port_id].device != parent)
> > > +		port_id++;
> > 
> > Why not call rte_eth_find_next directly from this function, and
> > add your specific test on top of it?
> > 
> > Something like:
> > 
> >     	while (port_id < RTE_MAX_ETHPORTS &&
> >     	       rte_eth_devices[port_id].device != parent)
> >     		port_id = rte_eth_find_next(port_id + 1);
> > 
> > this way you won't have to rewrite the test on the device state. Having the
> > logic expressed in several places would make reworking the device states more
> > complicated than necessary if it were to happen (just as you did when switching
> > the test from !(ATTACHED || REMOVED) to (UNUSED).
> 
> About the intent, you are right.
> About the solution, it seems buggy. We can try to find another way
> of coding this loop by using rte_eth_find_next()
> and adding the parent condition.

Your proposal is correct if adding a first call before the loop:
	port_id = rte_eth_find_next(port_id);




  reply	other threads:[~2019-04-01  1:59 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  0:27 [dpdk-dev] [PATCH] ethdev: add siblings iterator Thomas Monjalon
2018-12-11 16:31 ` Ferruh Yigit
2018-12-11 18:19   ` Thomas Monjalon
2019-02-20 22:10 ` [dpdk-dev] [PATCH v2 0/4] ethdev iterators for multi-ports device Thomas Monjalon
2019-02-20 22:10   ` [dpdk-dev] [PATCH v2 1/4] ethdev: simplify port state comparisons Thomas Monjalon
2019-02-24 17:18     ` Andrew Rybchenko
2019-02-20 22:10   ` [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators Thomas Monjalon
2019-02-24 17:22     ` Andrew Rybchenko
2019-02-27 10:07     ` Gaëtan Rivet
2019-02-27 10:51       ` Thomas Monjalon
2019-04-01  1:59         ` Thomas Monjalon [this message]
2019-04-01  1:59           ` Thomas Monjalon
2019-03-19 15:47     ` Ferruh Yigit
2019-03-19 15:47       ` Ferruh Yigit
2019-03-19 17:34       ` Thomas Monjalon
2019-03-19 17:34         ` Thomas Monjalon
2019-03-19 18:04         ` Ferruh Yigit
2019-03-19 18:04           ` Ferruh Yigit
2019-04-01  2:16           ` Thomas Monjalon
2019-04-01  2:16             ` Thomas Monjalon
2019-04-01  6:46             ` David Marchand
2019-04-01  6:46               ` David Marchand
2019-04-01  8:09               ` Thomas Monjalon
2019-04-01  8:09                 ` Thomas Monjalon
2019-04-02 23:35                 ` Ferruh Yigit
2019-04-02 23:35                   ` Ferruh Yigit
2019-04-02 23:37                   ` Thomas Monjalon
2019-04-02 23:37                     ` Thomas Monjalon
2019-02-20 22:10   ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: use port sibling iterators Thomas Monjalon
2019-02-20 22:10   ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: use port sibling iterator in device cleanup Thomas Monjalon
2019-04-01  2:26 ` [dpdk-dev] [PATCH v3 0/4] ethdev iterators for multi-ports device Thomas Monjalon
2019-04-01  2:26   ` Thomas Monjalon
2019-04-01  2:26   ` [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons Thomas Monjalon
2019-04-01  2:26     ` Thomas Monjalon
2019-04-01 14:58     ` Stephen Hemminger
2019-04-01 14:58       ` Stephen Hemminger
2019-04-01 15:17       ` Thomas Monjalon
2019-04-01 15:17         ` Thomas Monjalon
2019-04-01 16:07         ` Stephen Hemminger
2019-04-01 16:07           ` Stephen Hemminger
2019-04-03 15:03     ` Slava Ovsiienko
2019-04-03 15:03       ` Slava Ovsiienko
2019-04-01  2:26   ` [dpdk-dev] [PATCH v3 2/4] ethdev: add siblings iterators Thomas Monjalon
2019-04-01  2:26     ` Thomas Monjalon
2019-04-01  7:23     ` Andrew Rybchenko
2019-04-01  7:23       ` Andrew Rybchenko
2019-04-02 23:42     ` Ferruh Yigit
2019-04-02 23:42       ` Ferruh Yigit
2019-04-02 23:48       ` Thomas Monjalon
2019-04-02 23:48         ` Thomas Monjalon
2019-04-03 15:03     ` Slava Ovsiienko
2019-04-03 15:03       ` Slava Ovsiienko
2019-04-01  2:26   ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: use port sibling iterators Thomas Monjalon
2019-04-01  2:26     ` Thomas Monjalon
2019-04-03 14:19     ` Ferruh Yigit
2019-04-03 14:19       ` Ferruh Yigit
2019-04-03 18:07       ` Yongseok Koh
2019-04-03 18:07         ` Yongseok Koh
2019-04-04 11:33         ` Ferruh Yigit
2019-04-04 11:33           ` Ferruh Yigit
2019-04-03 15:04     ` Slava Ovsiienko
2019-04-03 15:04       ` Slava Ovsiienko
2019-04-01  2:27   ` [dpdk-dev] [PATCH v3 4/4] app/testpmd: use port sibling iterator in device cleanup Thomas Monjalon
2019-04-01  2:27     ` Thomas Monjalon
2019-04-02 23:43     ` Ferruh Yigit
2019-04-02 23:43       ` Ferruh Yigit
2019-04-03 15:04     ` Slava Ovsiienko
2019-04-03 15:04       ` Slava Ovsiienko
2019-04-03 16:42   ` [dpdk-dev] [PATCH v3 0/4] ethdev iterators for multi-ports device Ferruh Yigit
2019-04-03 16:42     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2318869.vaV4MP09YM@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).