From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CCC2BA00B9 for ; Mon, 1 Apr 2019 04:16:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8935316B; Mon, 1 Apr 2019 04:16:10 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 176AA11A4 for ; Mon, 1 Apr 2019 04:16:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 91FD421B34; Sun, 31 Mar 2019 22:16:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 31 Mar 2019 22:16:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=edRMPNwUsFVgQJ+gtqB66HdpqH8E92Gywx0Gh6Fhnok=; b=icH8BJY2K362 aQjIRdb5CmGBndFIDagu7lCGSUKb+iwVjuv0oMqRVUCdW8avyOGfHxnFiJQl2kVt gdLPaYkroeTdgUYEgHac+5X8ZSUds6Z29jKGokycsbyw2tMesglydPY+Tij8oJBw vQE63+sCq6R141R7pgXoB6oJa22YMt0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=edRMPNwUsFVgQJ+gtqB66HdpqH8E92Gywx0Gh6Fhn ok=; b=3F+wMVipubcCK8yXIpXHzUqveL8+X/W8lpEDTFY7CHUMB6Z13yCnGvYXw wViSMDteJD+1SDpZGDRAio0NRvgeRxX3vpr6aV9aLfgX6ZWCANUjFfqyO6X5hISo HX0PgHgV9Pn9cZO8xNYqPXFiw1/aUAXjA7JfjskkO9pbHY9AXDXCeedrvuq3J2J9 WCvcDJwe3kToj1Vx0iIAVTiiHfuvwi6I0eSlKJr/J7rhsj3QT+BeWEsev/hW3TIh c78wk5KAe5I69AXutm4/+4hdBkFgfQd29Uft6X6D9wFG4hU0gskETqpQF68CTGc1 kf49dMfnFmEzJgWafdQq2D/wambdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleefgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17CDEE4210; Sun, 31 Mar 2019 22:16:07 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Andrew Rybchenko , david.marchand@redhat.com Date: Mon, 01 Apr 2019 04:16:06 +0200 Message-ID: <4063619.5t9VujUhGY@xps> In-Reply-To: <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> References: <20181130002716.27325-1-thomas@monjalon.net> <59747746.vl7xl9E5pD@xps> <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401021606.26a7kPbY6pEqmRz7B4Mka2mfXAyU0E-0wJJ3mMy3dvg@z> 19/03/2019 19:04, Ferruh Yigit: > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>> +uint16_t __rte_experimental > >> > >> Do we need _rte_experimental on function definitions? I guess only in .h file, > >> function declaration is enough. > > > > Yes we need them both in .h and .c files. > > Why we need them in .c file? > I think the compiler is interested in ones in .h file, because of the > experimental checks. We need the tag in .c file because a check is done in the ELF object by buildtools/check-experimental-syms.sh David tried a replacement of this script to run on header files, but it looks a bit slow: https://patches.dpdk.org/patch/49118/