From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C854FA068F for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 07:42:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D7A1316B; Mon, 1 Apr 2019 07:42:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 739A52B99 for <dev@dpdk.org>; Mon, 1 Apr 2019 07:42:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 22:42:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,295,1549958400"; d="scan'208";a="146903945" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 31 Mar 2019 22:42:49 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 22:42:24 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 22:42:23 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 13:42:21 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>, "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "O'Hare, Cathal" <cathal.ohare@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com> Thread-Topic: [dpdk-dev] [PATCH v4 00/38] ice share code update. Thread-Index: AQHU4s2kVA9itfWem0KnIL2YRBHXcaYb7NoggAmPeYCAAVbqgA== Date: Mon, 1 Apr 2019 05:42:21 +0000 Message-ID: <039ED4275CED7440929022BC67E706115336086A@SHSMSX103.ccr.corp.intel.com> References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190325054452.2616-1-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> <1570574.eaFxuQL18R@xps> In-Reply-To: <1570574.eaFxuQL18R@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2FiMDU2ZmQtOGI5ZS00NGJhLTgyODYtZmYyMzQwYjE4YTQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnJnWlVmRyt4NXBsbHRzOFIzemJCVlVieVN5XC9JY0EwdTRwUWJiZnVCMWQrdGFMdXpFN1hYWnpLMk1jVCtqSXIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190401054221.C4mD0pQWS2h4-5qTexhZzJnhZnu_g1sr9RyZhf8f2nk@z> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 1, 2019 1:06 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming > <qiming.yang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.= com>; > Yigit, Ferruh <ferruh.yigit@intel.com>; O'Hare, Cathal <cathal.ohare@inte= l.com>; > Mcnamara, John <john.mcnamara@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update. >=20 > 25/03/2019 08:07, Zhang, Qi Z: > > > Sync to latest kernel driver, main changes: > > > 1. add DCB/FDIR support. > > > 2. add more APIs in switch module. > > > 3. code clean and bug fix. > > > > > > Qi Zhang (38): > > > net/ice/base: add switch resource allocation and free > > > net/ice/base: improve comments > > > net/ice/base: add two helper functions > > > net/ice/base: add helper macros > > > net/ice/base: allow package copy to be used after resets > > > net/ice/base: clean code > > > net/ice/base: declare functions as external > > > net/ice/base: add more APIs in switch module > > > net/ice/base: add VSI queue context framework > > > net/ice/base: add APIs to add remove ethertype filter > > > net/ice/base: add APIs to get allocated resources > > > net/ice/base: add APIs to alloc/free resource counter > > > net/ice/base: add APIs to get VSI promiscuous mode > > > net/ice/base: add MAC filter with marker and counter > > > net/ice/base: add two helper functions for flow management > > > net/ice/base: fix minor issues > > > net/ice/base: update macros > > > net/ice/base: clean code > > > net/ice/base: enable VSI queue context > > > net/ice/base: ensure only valid bits are set > > > net/ice/base: enhance get link status command > > > net/ice/base: add RSS key related macro and structures > > > net/ice/base: do not write TCAM entries back > > > net/ice/base: remove local VSIG allocations > > > net/ice/base: fix minor issues > > > net/ice/base: update copyright time > > > net/ice/base: fix Klockwork analysis reported issues > > > net/ice/base: return config error without queue to disable > > > net/ice/base: add function to check FW recovery mode > > > net/ice/base: change profile id reference counting > > > net/ice/base: add DCB support > > > net/ice/base: add FDIR support > > > net/ice/base: change profile priority for RSS reply > > > net/ice/base: fix duplicate resource allocations > > > net/ice/base: fix minor issues > > > net/ice/base: increase prototol offset size > > > net/ice/base: revert the workaround for resource allocation > > > net/ice/base: rework on bit ops > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi >=20 > 3 commits have the title "fix minor issues", that's a funny performance. > When the ice PMD will enter in a serious phase, you should write some rea= l > commit titles and explain what are the fixed issues. > For DPDK 19.05, I guess it's fine because ice PMD is not going to be real= ly used > soon, right? Yes, the share code in 19.05 can be regarded as an initial version, the com= mit log is not quite sensitive for developers. Thanks to forgive this rough, this will not happen in our following share c= ode update :) >=20