From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 94EA9A068F for ; Mon, 1 Apr 2019 07:46:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C1A5316B; Mon, 1 Apr 2019 07:46:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B45802B99 for ; Mon, 1 Apr 2019 07:46:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 22:46:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,295,1549958400"; d="scan'208";a="136462591" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 31 Mar 2019 22:46:05 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 22:46:05 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 13:46:03 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon , "Yigit, Ferruh" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "O'Hare, Cathal" , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE Thread-Index: AQHU45rWNyYnVP7X2UeEqhPkDd0APqYdJUmAgAhA0YCAAWyj0A== Date: Mon, 1 Apr 2019 05:46:03 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407F8DBB@shsmsx102.ccr.corp.intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com> <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> <2061322.Qldrv329ue@xps> In-Reply-To: <2061322.Qldrv329ue@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401054603.LzTZ-vTzQdp_v_dEvhUHgzSj4knTyO-CdUWbDj45I7s@z> Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Sunday, March 31, 2019 11:52 PM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Zhang, Qi Z > Cc: dev@dpdk.org; O'Hare, Cathal ; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE >=20 > 26/03/2019 10:50, Ferruh Yigit: > > > Wenzhuo Lu (8): > > > net/ice: fix Tx function setting > > > net/ice: add pointer for queue buffer release > > > net/ice: support vector SSE in RX > > > net/ice: support Rx scatter SSE vector > > > net/ice: support Tx SSE vector > > > net/ice: support Rx AVX2 vector > > > net/ice: support Rx scatter AVX2 vector > > > net/ice: support vector AVX2 in TX > > > > This version (v7) pulled from next-net-intel to next-net. >=20 > I assume these patches have been tested, or at least compiled. > However, when running devtools/test-meson-builds.sh, there is a > compilation error for build-x86-default: >=20 > In file included from ../drivers/net/ice/ice_ethdev.h:10: > rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found >=20 > It can be fixed in > net/ice: support Rx AVX2 vector > by adding static_rte_pci and static_rte_bus_pci to the dependencies. > I fixed it even better in > net/ice: support vector SSE in Rx > by replacing the useless include of rte_ethdev_pci.h in ice_ethdev.h with > rte_ethdev_driver.h. Really sorry for this. Although I don't understand the issue. I do use meso= n build and it works. In my server, no matter using " rte_ethdev_pci.h " or " rte_ethdev_driver.= h ", it works fine. To be honest, the compile error looks weird to me. Looks like any file whic= h includes " rte_ethdev_pci.h " can hit the same problem. But I cannot tell= anything, as I cannot reproduce the error. Again, really appreciate for root causing and fixing the error but not reje= cting the patches. >=20 > I could just reject the next-net tree, but I don't really have such optio= n if we > want to close 19.05-rc1 quickly. >=20 > In summary, I am spending my Sunday hours to fix the mess in your driver > which was supposed to be tested before submitting, plus before merge in > next-net-intel, plus compilation-tested before pull in next-net. > I don't know what failed in the process, but I really don't like it. > I don't want to see any new patch for ice PMD in 19.05 cycle. > If you really need some fixes in 19.05 (very likely given the mass code d= rop > you are doing few days before the -rc1 deadline), then I advise you to > double check everything and make commits fully justified and explained. >=20 > Sorry for the bad mood, and I hope it won't happen again soon. >=20