From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 31407A068F
for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 08:32:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E9CF634F3;
Mon, 1 Apr 2019 08:32:34 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id BE96A343C;
Mon, 1 Apr 2019 08:32:33 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
31 Mar 2019 23:32:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,295,1549958400"; d="scan'208";a="127537225"
Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133])
by orsmga007.jf.intel.com with ESMTP; 31 Mar 2019 23:32:31 -0700
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by
KMSMSX156.gar.corp.intel.com ([169.254.1.198]) with mapi id 14.03.0415.000;
Mon, 1 Apr 2019 14:32:30 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for
x553
Thread-Index: AQHU5guKgX5Bz2WlrUuqK++iCMX7KKYibWGAgARvw5A=
Date: Mon, 1 Apr 2019 06:32:29 +0000
Message-ID:
<A2573D2ACFCADC41BB3BE09C6DE313CA07ECD7E3@PGSMSX103.gar.corp.intel.com>
References: <1553844685-52291-1-git-send-email-wei.zhao1@intel.com>
<1553847345-54013-1-git-send-email-wei.zhao1@intel.com>
<F8A4ECA1C1D86B4081DD6BF503D1F436C746BA94@fmsmsx120.amr.corp.intel.com>
In-Reply-To: <F8A4ECA1C1D86B4081DD6BF503D1F436C746BA94@fmsmsx120.amr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for
x553
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190401063229.7mw3IL34XuqCEuKVlcmJWE8FkyNkAWPd5IjHjT1Upos@z>
> -----Original Message-----
> From: Stillwell Jr, Paul M
> Sent: Saturday, March 30, 2019 2:47 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup fo=
r
> x553
>=20
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Zhao
> > Sent: Friday, March 29, 2019 1:16 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for
> > x553
> >
> > There is need to eanble 10Mb/s link foixgbe NIC of x553.
>=20
> Couple of typos, how about:
>=20
> Enable 10Mb/s link for ixgbe x553.
Good, update in v2
>=20
> > This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD
> > driver need to special check when setup link for these two types of dev=
ice.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > delete test code and change permit link speed
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 97e1021..0aef577 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct
> > rte_pci_device *pci_dev)
> > allowed_speeds =3D ETH_LINK_SPEED_100M |
> ETH_LINK_SPEED_1G |
> > ETH_LINK_SPEED_2_5G | ETH_LINK_SPEED_5G |
> > ETH_LINK_SPEED_10G;
> > + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T ||
> > + hw->device_id =3D=3D
> > IXGBE_DEV_ID_X550EM_A_1G_T_L)
> > + allowed_speeds =3D ETH_LINK_SPEED_10M |
> > + ETH_LINK_SPEED_100M |
> > ETH_LINK_SPEED_1G;
> > break;
> > default:
> > allowed_speeds =3D ETH_LINK_SPEED_100M |
> ETH_LINK_SPEED_1G | @@
> > -2742,6 +2746,8 @@ static int eth_ixgbevf_pci_remove(struct
> > rte_pci_device *pci_dev)
> > speed |=3D IXGBE_LINK_SPEED_1GB_FULL;
> > if (*link_speeds & ETH_LINK_SPEED_100M)
> > speed |=3D IXGBE_LINK_SPEED_100_FULL;
> > + if (*link_speeds & ETH_LINK_SPEED_10M)
> > + speed |=3D IXGBE_LINK_SPEED_10_FULL;
> > }
> >
> > err =3D ixgbe_setup_link(hw, speed, link_up); @@ -4061,8 +4067,12
> @@
> > static int ixgbevf_dev_xstats_get_names(__rte_unused struct
> > rte_eth_dev *dev,
> > switch (link_speed) {
> > default:
> > case IXGBE_LINK_SPEED_UNKNOWN:
> > + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T ||
> > + hw->device_id =3D=3D
> > IXGBE_DEV_ID_X550EM_A_1G_T_L)
> > + link.link_speed =3D ETH_SPEED_NUM_10M;
> > + else
> > + link.link_speed =3D ETH_SPEED_NUM_100M;
> > link.link_duplex =3D ETH_LINK_FULL_DUPLEX;
> > - link.link_speed =3D ETH_SPEED_NUM_100M;
> > break;
> >
> > case IXGBE_LINK_SPEED_100_FULL:
> > --
> > 1.8.3.1