From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 9128BA0679
for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 13:24:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CF9C7316B;
Mon, 1 Apr 2019 13:24:26 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E638D11A4
for <dev@dpdk.org>; Mon, 1 Apr 2019 13:24:24 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 8D5BD21E82;
Mon, 1 Apr 2019 07:24:24 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Mon, 01 Apr 2019 07:24:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=cVz3LOvinMDbAkkPK59JK5pUSt6CGUsOyFoajWSC2Pk=; b=bQWaAcKKLnqU
lu27Dwo1ms5NUJExiGKs+sneCYy1MaUH/mni3iiEhLQZ/HMzIlOF3yb4YX7GVQVw
A2CQ2JyvR2Pd3wztbaHHNIoibQUlhVFvAdXazVvhUb9gywIKzGQGwdliVORKuao3
RsaUlrr2bg8MyDurfUj7Uh5nEPQSYcI=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=cVz3LOvinMDbAkkPK59JK5pUSt6CGUsOyFoajWSC2
Pk=; b=ZVYMqw9Z6iNB6Fuvbu81R6lkbK9N2u63Ygekg286ykkAZD7BVzHqjUUum
QQ5d6aVHLOFZFhGrjNTnFGCo1KoY9x6hUqbmmwJOrkmxLvbYcYE6AZuPqUricZX9
Q/ESjDG4aWows9TVkgrjz5XiE6gWsjQqP4zi0h8RKSgR1S59QhiYp3ZpePQAfvw7
n3wWj8TcPs2gOqASjzqhLxGjDLZ9bXZo85k2HHO4VVNriRdpkxAdXQTBiFDd/Cjc
bBIWzl/qy/6dBEC1Ryhq/0L3IJSCG1+l05OwkKB1SXaPaHRtX8IlUNELOhIzIKrR
Yl0xZ/W5DAzD5qRoVqG5IKvE/7ylQ==
X-ME-Sender: <xms:5_ShXAy4CXylVSHfN9CWV8HLDqMnbGEI6oN5oRfFnZNJZsasGRtf2Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggdefkecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh
hmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeen
ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
enucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:5_ShXO8qO33T2dI68yP5wfYLdrvJoF2q1nPxrxz2VFo1naPJx1L4Uw>
<xmx:5_ShXLDLmf7OhfCgjkz80J7UxzaadvxVDpPMspYH1fC8P_kOLp8N9g>
<xmx:5_ShXFp8sbTuKt_V89bArtldiqB-CdBwcvqxsROPwyyr2bm_xzy1jQ>
<xmx:6PShXNQpQTyDgIhWPJj_jeyyx_gx5f7NDSDujK4fa_nygRJz8GdLbA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id C66E310316;
Mon, 1 Apr 2019 07:24:22 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
harini.ramakrishnan@microsoft.com, ranjit.menon@intel.com
Date: Mon, 01 Apr 2019 13:24:20 +0200
Message-ID: <3743424.Qud79MjzIA@xps>
In-Reply-To: <20190401103551.28909-1-alialnu@mellanox.com>
References: <20190401103551.28909-1-alialnu@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] build: use cat instead of more
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190401112420.NweTz8-dj-aj9lolvJx8e_vQXoHFBe-tYOoiS0FuzJQ@z>
01/04/2019 12:36, Ali Alnubani:
> This is to fix a build error with meson that is caused
> by using the 'more' command to read the VERSION file. The error:
>
> config/meson.build:10:10: ERROR: String
> '::::::::::::::\n<RTE_SDK_PATH>VERSION\n::::::::::::::\n19' cannot be
> converted to int
>
> The command 'more' prints the file name before the actual
> contents of the file when it's being run without a controlling terminal.
> This could happen in CI environments.
>
> Please refer to:
> https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c
>
> The cat command can still be found on Windows if the ports of GNU
> utilities are installed.
>
> Fixes: c04172b5f031 ("build: add single source of DPDK version number")
> Fixes: d320fe56bd51 ("build: use version number from config file")
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
It is fixing a regression on Linux.
I think we should take this fix urgently
and think about Windows in a next step.
"more" is an interactive command, we should not use it.
As suggested by Ali, we may require an extra dependency on Windows
to get some GNU utilities. Or if no other tools are required,
may we have a meson builtin to read a file?