From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 82E39A0679 for ; Mon, 1 Apr 2019 14:58:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 653124C8D; Mon, 1 Apr 2019 14:58:28 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 226443798 for ; Mon, 1 Apr 2019 14:58:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 05:58:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,296,1549958400"; d="scan'208";a="219463738" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2019 05:58:23 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by IRSMSX104.ger.corp.intel.com ([169.254.5.56]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 13:58:23 +0100 From: "Pattan, Reshma" To: "Phil Yang (Arm Technology China)" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "Hunt, David" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU5h4i/F9cKRYXykKYZrGPFx0ijKYixPTQgAGhiQCAAuIW8A== Date: Mon, 1 Apr 2019 12:58:22 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A43382E@irsmsx110.ger.corp.intel.com> References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1553856998-25394-2-git-send-email-phil.yang@arm.com> <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2ZhYmY1NWUtNmVmZi00NmZiLWJkZDUtZGE2NmFhYTVmMGQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTnY3VUw4UU4wNW5qcklybWFWYjU5RVZqcGtxcURZbVFMMDBEdGdDTnVmZE8yeWdKczhURHlaSUxEc2NsRk44dCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401125822.2kHGKm3OP0SX5LOEKlNzI-7a_FXzsoTl0ONxyl1Vt_w@z> > -----Original Message----- > From: Phil Yang (Arm Technology China) [mailto:Phil.Yang@arm.com] > Sent: Saturday, March 30, 2019 4:55 PM > To: Pattan, Reshma ; dev@dpdk.org; > thomas@monjalon.net > Cc: Hunt, David ; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd ; nd > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each work= er > thread >=20 > > -----Original Message----- > > From: Pattan, Reshma > > Sent: Saturday, March 30, 2019 12:40 AM > > To: Phil Yang (Arm Technology China) ; > > dev@dpdk.org; thomas@monjalon.net > > Cc: Hunt, David ; Gavin Hu (Arm Technology > > China) ; Honnappa Nagarahalli > > ; nd > > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each > > worker thread > > > > > > > > > -----Original Message----- > > > From: Phil Yang [mailto:phil.yang@arm.com] > > > > > > The current implementation using '__sync' built-ins to synchronize > > > statistics within worker threads. '__sync' built-ins functions are > > > full barriers which will affect the performance, so add a per worker > > > packets > > statistics. > > > > > > Enable by option --insight-worker. > > > > > > > I don't feel the need of this new option to print per core stats. Any > > reason for this? >=20 > Hi Reshma, >=20 > Thanks for your comment. > The per core stats aims at removing the '__sync' builtin full barrier in = the worker > thread. > It records the workload of each core (It shows the bottleneck core as wel= l). > Since the maximum core number may be more than 128, so disable the print = in > default and add this new option for debugging use. >=20 Ok fine with me then.=20 Thanks, Reshma