From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7C6B2A0679 for ; Mon, 1 Apr 2019 16:56:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 895E6378E; Mon, 1 Apr 2019 16:56:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3E6EF3576 for ; Mon, 1 Apr 2019 16:56:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 07:56:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="333954348" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by fmsmga005.fm.intel.com with ESMTP; 01 Apr 2019 07:56:27 -0700 To: Bruce Richardson Cc: Thomas Monjalon , Wenzhuo Lu , Qi Zhang , dev@dpdk.org, cathal.ohare@intel.com, john.mcnamara@intel.com References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com> <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> <2061322.Qldrv329ue@xps> <1af99378-b51a-fe64-6bba-7b8dd5f67e07@intel.com> <20190401143928.GA1441@bricha3-MOBL.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Mon, 1 Apr 2019 15:56:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190401143928.GA1441@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401145626.dWYd06BQZQ2LqZjRyI9gdFmparmVJz3bjYJm_ouo_vM@z> On 4/1/2019 3:39 PM, Bruce Richardson wrote: > On Mon, Apr 01, 2019 at 01:51:38PM +0100, Ferruh Yigit wrote: >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: >>> 26/03/2019 10:50, Ferruh Yigit: >>>>> Wenzhuo Lu (8): >>>>> net/ice: fix Tx function setting >>>>> net/ice: add pointer for queue buffer release >>>>> net/ice: support vector SSE in RX >>>>> net/ice: support Rx scatter SSE vector >>>>> net/ice: support Tx SSE vector >>>>> net/ice: support Rx AVX2 vector >>>>> net/ice: support Rx scatter AVX2 vector >>>>> net/ice: support vector AVX2 in TX >>>> >>>> This version (v7) pulled from next-net-intel to next-net. >>> >>> I assume these patches have been tested, or at least compiled. >>> However, when running devtools/test-meson-builds.sh, there is a >>> compilation error for build-x86-default: >>> >>> In file included from ../drivers/net/ice/ice_ethdev.h:10: >>> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found >> >> I tested this with meson but not able to catch the issue. Perhaps for my case >> dependencies were build fast enough to cause a problem. >> > > That should be a problem with the meson builds. While with make builds, the > headers files are picked up after they are copied to the "include" > directory by the build process, in meson no such copying occurs and the > header files are picked up by having the paths to them passed in the > "dependency object" to each build. If the dependency does not exist then > the build will never pass, irrespective of ordering, and if the dependency > exists, the build will always find the header in its original location. I was checking this and recognized that no copying is happening. And I can see many PMDs are using this header [1], not sure why ice is failing. > > [The biggest benefit of this is that when building with ninja there are no > dependencies between the individual .c files - each one can be compiled > in parallel with all the others. It's only at the linking step that we need > to wait for previous jobs to complete] > > In terms of this specific error with the header - did it get root caused? > Since it occurs on the "default" path, I'd suggest the fallback handling in > the meson.build file for the absense of AVX may be faulty, e.g. are you > replacing c flags or dependencies rather than appending to them? Trying to find out the root cause, but as you said it occurs on the 'default' path only, and taking into account that there is not copying dependent headers, I am not able to find it yet, checking. [1] $ git grep rte_ethdev_pci.h drivers/net/ark/ark_ethdev.c:#include drivers/net/atlantic/atl_ethdev.c:#include drivers/net/avp/avp_ethdev.c:#include drivers/net/axgbe/axgbe_common.h:#include drivers/net/bnx2x/bnx2x_ethdev.c:#include drivers/net/bnxt/bnxt_ethdev.c:#include drivers/net/cxgbe/cxgbe_ethdev.c:#include drivers/net/cxgbe/cxgbe_main.c:#include drivers/net/cxgbe/cxgbevf_ethdev.c:#include drivers/net/cxgbe/cxgbevf_main.c:#include drivers/net/e1000/em_ethdev.c:#include drivers/net/e1000/igb_ethdev.c:#include drivers/net/e1000/igb_flow.c:#include drivers/net/ena/ena_ethdev.c:#include drivers/net/enetc/enetc_ethdev.c:#include drivers/net/enic/enic_ethdev.c:#include drivers/net/fm10k/fm10k_ethdev.c:#include drivers/net/i40e/i40e_ethdev.c:#include drivers/net/i40e/i40e_ethdev_vf.c:#include drivers/net/iavf/iavf_ethdev.c:#include drivers/net/ice/ice_ethdev.c:#include drivers/net/ixgbe/ixgbe_ethdev.c:#include drivers/net/ixgbe/ixgbe_ipsec.c:#include drivers/net/liquidio/lio_ethdev.c:#include drivers/net/mlx4/mlx4.c:#include drivers/net/mlx5/mlx5.c:#include drivers/net/nfp/nfp_net.c:#include drivers/net/nfp/nfpcore/nfp_cpp.h:#include drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c:#include drivers/net/nfp/nfpcore/nfp_cppcore.c:#include drivers/net/qede/qede_ethdev.h:#include drivers/net/sfc/sfc_ethdev.c:#include drivers/net/szedata2/rte_eth_szedata2.c:#include drivers/net/thunderx/nicvf_ethdev.c:#include drivers/net/virtio/virtio_ethdev.c:#include drivers/net/vmxnet3/vmxnet3_ethdev.c:#include