From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 75FF74CC5
for <dev@dpdk.org>; Mon, 1 Apr 2019 18:17:30 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
01 Apr 2019 09:17:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="157725719"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35])
by fmsmga004.fm.intel.com with SMTP; 01 Apr 2019 09:17:27 -0700
Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 17:17:26 +0100
Date: Mon, 1 Apr 2019 17:17:25 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anand Rawat <anand.rawat@intel.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
jeffrey.b.shaw@intel.com, thomas@monjalon.net
Message-ID: <20190401161725.GA1457@bricha3-MOBL.ger.corp.intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
<20190328232451.16988-1-anand.rawat@intel.com>
<20190328232451.16988-2-anand.rawat@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Apr 2019 16:17:30 -0000
On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote:
> Added initial stub source files for windows support
> and only the required meson changes for windows.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
> config/meson.build | 23 ++++++++++++------
> config/x86/meson.build | 14 ++++++-----
> lib/librte_eal/meson.build | 6 ++++-
> lib/librte_eal/windows/eal/eal.c | 14 +++++++++++
> lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++
> lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++
> lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++
> lib/librte_eal/windows/eal/meson.build | 10 ++++++++
> 8 files changed, 118 insertions(+), 14 deletions(-)
> create mode 100644 lib/librte_eal/windows/eal/eal.c
> create mode 100644 lib/librte_eal/windows/eal/eal_debug.c
> create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c
> create mode 100644 lib/librte_eal/windows/eal/eal_thread.c
> create mode 100644 lib/librte_eal/windows/eal/meson.build
>
> diff --git a/config/meson.build b/config/meson.build
> index 30a7261a5..4bd73b1e9 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: BSD-3-Clause
> -# Copyright(c) 2017 Intel Corporation
> +# Copyright(c) 2017-2019 Intel Corporation
>
> # set the major version, which might be used by drivers and libraries
> # depending on the configuration options
> @@ -80,18 +80,27 @@ dpdk_extra_ldflags += '-Wl,--no-as-needed'
> add_project_link_arguments('-pthread', language: 'c')
> dpdk_extra_ldflags += '-pthread'
>
> -# some libs depend on maths lib
> -add_project_link_arguments('-lm', language: 'c')
> -dpdk_extra_ldflags += '-lm'
> +# on some OS, maths functions are in a separate library
> +if cc.find_library('lm', required : false).found()
The library is "libm", not "liblm" so this breaks the linux builds as there
is not found an "lm" library. Instead use "cc.find_library('m',..."
/Bruce
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id E481DA0679
for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 18:17:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id F094D4D3A;
Mon, 1 Apr 2019 18:17:31 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 75FF74CC5
for <dev@dpdk.org>; Mon, 1 Apr 2019 18:17:30 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
01 Apr 2019 09:17:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="157725719"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35])
by fmsmga004.fm.intel.com with SMTP; 01 Apr 2019 09:17:27 -0700
Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 17:17:26 +0100
Date: Mon, 1 Apr 2019 17:17:25 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anand Rawat <anand.rawat@intel.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
jeffrey.b.shaw@intel.com, thomas@monjalon.net
Message-ID: <20190401161725.GA1457@bricha3-MOBL.ger.corp.intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
<20190328232451.16988-1-anand.rawat@intel.com>
<20190328232451.16988-2-anand.rawat@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190401161725.omn6IiOA2kiC8W9HWBf6OnZkmjNcp5kcjR_h-ItliWI@z>
On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote:
> Added initial stub source files for windows support
> and only the required meson changes for windows.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
> config/meson.build | 23 ++++++++++++------
> config/x86/meson.build | 14 ++++++-----
> lib/librte_eal/meson.build | 6 ++++-
> lib/librte_eal/windows/eal/eal.c | 14 +++++++++++
> lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++
> lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++
> lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++
> lib/librte_eal/windows/eal/meson.build | 10 ++++++++
> 8 files changed, 118 insertions(+), 14 deletions(-)
> create mode 100644 lib/librte_eal/windows/eal/eal.c
> create mode 100644 lib/librte_eal/windows/eal/eal_debug.c
> create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c
> create mode 100644 lib/librte_eal/windows/eal/eal_thread.c
> create mode 100644 lib/librte_eal/windows/eal/meson.build
>
> diff --git a/config/meson.build b/config/meson.build
> index 30a7261a5..4bd73b1e9 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: BSD-3-Clause
> -# Copyright(c) 2017 Intel Corporation
> +# Copyright(c) 2017-2019 Intel Corporation
>
> # set the major version, which might be used by drivers and libraries
> # depending on the configuration options
> @@ -80,18 +80,27 @@ dpdk_extra_ldflags += '-Wl,--no-as-needed'
> add_project_link_arguments('-pthread', language: 'c')
> dpdk_extra_ldflags += '-pthread'
>
> -# some libs depend on maths lib
> -add_project_link_arguments('-lm', language: 'c')
> -dpdk_extra_ldflags += '-lm'
> +# on some OS, maths functions are in a separate library
> +if cc.find_library('lm', required : false).found()
The library is "libm", not "liblm" so this breaks the linux builds as there
is not found an "lm" library. Instead use "cc.find_library('m',..."
/Bruce