From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Phil Yang (Arm Technology China)" <Phil.Yang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "david.hunt@intel.com" <david.hunt@intel.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"Phil Yang (Arm Technology China)" <Phil.Yang@arm.com>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] test/ring_perf: replace sync builtins with atomic builtins
Date: Mon, 1 Apr 2019 16:24:24 +0000 [thread overview]
Message-ID: <VE1PR08MB5149C99438508E154484CE4998550@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
Message-ID: <20190401162424.vX4smxgYEgYJlOKRI64snFJ-8u61qCL4kJzlUHrWGqk@z> (raw)
In-Reply-To: <1553856998-25394-4-git-send-email-phil.yang@arm.com>
<snip>
> diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c index
> ebb3939..e851c1a 100644
> --- a/app/test/test_ring_perf.c
> +++ b/app/test/test_ring_perf.c
> @@ -160,7 +160,11 @@ enqueue_bulk(void *p)
> unsigned i;
> void *burst[MAX_BURST] = {0};
>
> - if ( __sync_add_and_fetch(&lcore_count, 1) != 2 )
> +#ifdef RTE_USE_C11_MEM_MODEL
> + if (__atomic_add_fetch(&lcore_count, 1, __ATOMIC_RELAXED) != 2)
> #else
> + if (__sync_add_and_fetch(&lcore_count, 1) != 2) #endif
> while(lcore_count != 2)
> rte_pause();
Since, rte_ring library has both C11 and non-C11 implementations, conditional compilation should be fine here.
>
> @@ -196,7 +200,11 @@ dequeue_bulk(void *p)
> unsigned i;
> void *burst[MAX_BURST] = {0};
>
> - if ( __sync_add_and_fetch(&lcore_count, 1) != 2 )
> +#ifdef RTE_USE_C11_MEM_MODEL
> + if (__atomic_add_fetch(&lcore_count, 1, __ATOMIC_RELAXED) != 2)
> #else
> + if (__sync_add_and_fetch(&lcore_count, 1) != 2) #endif
> while(lcore_count != 2)
> rte_pause();
>
> --
> 2.7.4
next prev parent reply other threads:[~2019-04-01 16:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 9:49 [dpdk-dev] [PATCH] packet_ordering: " Phil Yang
2019-03-28 18:42 ` Thomas Monjalon
2019-03-28 18:42 ` Thomas Monjalon
2019-03-29 1:34 ` Phil Yang (Arm Technology China)
2019-03-29 1:34 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 0/3] example and test cases optimizations Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-03-29 16:39 ` Pattan, Reshma
2019-03-29 16:39 ` Pattan, Reshma
2019-03-30 16:55 ` Phil Yang (Arm Technology China)
2019-03-30 16:55 ` Phil Yang (Arm Technology China)
2019-04-01 12:58 ` Pattan, Reshma
2019-04-01 12:58 ` Pattan, Reshma
2019-04-02 3:33 ` Phil Yang (Arm Technology China)
2019-04-02 3:33 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-02 3:43 ` Phil Yang (Arm Technology China)
2019-04-02 3:43 ` Phil Yang (Arm Technology China)
2019-03-29 10:56 ` [dpdk-dev] [PATCH v2 3/3] test/ring_perf: " Phil Yang
2019-03-29 10:56 ` Phil Yang
2019-04-01 16:24 ` Honnappa Nagarahalli [this message]
2019-04-01 16:24 ` Honnappa Nagarahalli
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 0/3] example and test cases optimizations Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-04 23:24 ` Thomas Monjalon
2019-04-04 23:24 ` Thomas Monjalon
2019-04-08 4:04 ` Phil Yang (Arm Technology China)
2019-04-08 4:04 ` Phil Yang (Arm Technology China)
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-04 15:30 ` Honnappa Nagarahalli
2019-04-04 15:30 ` Honnappa Nagarahalli
2019-04-03 6:59 ` [dpdk-dev] [PATCH v3 3/3] test/ring_perf: " Phil Yang
2019-04-03 6:59 ` Phil Yang
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-07-04 20:15 ` Thomas Monjalon
2019-07-05 3:19 ` Phil Yang (Arm Technology China)
2019-07-08 14:38 ` Thomas Monjalon
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 1/3] packet_ordering: add statistics for each worker thread Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 2/3] test/distributor: replace sync builtins with atomic builtins Phil Yang
2019-04-08 3:02 ` Phil Yang
2019-04-10 14:05 ` Hunt, David
2019-04-10 14:05 ` Hunt, David
2019-04-11 11:31 ` Phil Yang (Arm Technology China)
2019-04-11 11:31 ` Phil Yang (Arm Technology China)
2019-04-08 3:02 ` [dpdk-dev] [PATCH v4 3/3] test/ring_perf: " Phil Yang
2019-04-08 3:02 ` Phil Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5149C99438508E154484CE4998550@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Phil.Yang@arm.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).