From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E32EA5681 for ; Mon, 1 Apr 2019 18:34:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 09:34:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="136623283" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 01 Apr 2019 09:34:27 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 17:34:26 +0100 Date: Mon, 1 Apr 2019 17:34:25 +0100 From: Bruce Richardson To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net Message-ID: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 16:34:31 -0000 On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > Added initial stub source files for windows support > and only the required meson changes for windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Menon > --- > config/meson.build | 23 ++++++++++++------ > config/x86/meson.build | 14 ++++++----- > lib/librte_eal/meson.build | 6 ++++- > lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ > lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ > lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ > lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ > lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > 8 files changed, 118 insertions(+), 14 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/eal.c > create mode 100644 lib/librte_eal/windows/eal/eal_debug.c > create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c > create mode 100644 lib/librte_eal/windows/eal/eal_thread.c > create mode 100644 lib/librte_eal/windows/eal/meson.build > I'm a little uncertain behind putting the stub files and the meson.build changes in the one patch, since the result doesn't build anyway. However, you can get meson to successfully configure the project on windows by adding in an empty file called meson.build to the kernel/windows directory. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 46F51A0679 for ; Mon, 1 Apr 2019 18:34:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96C8A5689; Mon, 1 Apr 2019 18:34:32 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E32EA5681 for ; Mon, 1 Apr 2019 18:34:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 09:34:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="136623283" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 01 Apr 2019 09:34:27 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 17:34:26 +0100 Date: Mon, 1 Apr 2019 17:34:25 +0100 From: Bruce Richardson To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net Message-ID: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190328232451.16988-2-anand.rawat@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401163425.frhqRCKo-lBdDE-mR_PL6a73G0oCH5T8yPzCfU2KOeg@z> On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > Added initial stub source files for windows support > and only the required meson changes for windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Anand Rawat > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Menon > --- > config/meson.build | 23 ++++++++++++------ > config/x86/meson.build | 14 ++++++----- > lib/librte_eal/meson.build | 6 ++++- > lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ > lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ > lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ > lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ > lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > 8 files changed, 118 insertions(+), 14 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/eal.c > create mode 100644 lib/librte_eal/windows/eal/eal_debug.c > create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c > create mode 100644 lib/librte_eal/windows/eal/eal_thread.c > create mode 100644 lib/librte_eal/windows/eal/meson.build > I'm a little uncertain behind putting the stub files and the meson.build changes in the one patch, since the result doesn't build anyway. However, you can get meson to successfully configure the project on windows by adding in an empty file called meson.build to the kernel/windows directory. /Bruce