From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8A8143576 for ; Mon, 1 Apr 2019 22:10:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 13:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="139268405" Received: from mashbery-mobl.ger.corp.intel.com ([10.252.17.42]) by fmsmga007.fm.intel.com with SMTP; 01 Apr 2019 13:10:22 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 21:10:21 +0100 Date: Mon, 1 Apr 2019 21:10:20 +0100 From: Bruce Richardson To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net Message-ID: <20190401201019.GA1466@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 20:10:27 -0000 On Mon, Apr 01, 2019 at 10:06:18AM -0700, Anand Rawat wrote: > On 4/1/2019 9:34 AM, Bruce Richardson wrote: > > On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > > > config/meson.build | 23 ++++++++++++------ > > > config/x86/meson.build | 14 ++++++----- > > > lib/librte_eal/meson.build | 6 ++++- > > > lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ > > > lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ > > > lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ > > > lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ > > > lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > > > > I'm a little uncertain behind putting the stub files and the meson.build > > changes in the one patch, since the result doesn't build anyway. However, > > you can get meson to successfully configure the project on windows by > > adding in an empty file called meson.build to the kernel/windows directory. > > > > /Bruce > > > > Thanks Bruce, libm is a part of V8 fixes. > kernel/windows directory is the patch 8/8 as I thought of it as a temporary > workaround. I'll move it to another patch along with meson changes here. Oh, I wasn't thinking of it being temporary, as I assumed you had kernel modules for uio on windows. However, if they are not being hosted on DPDK, I still think having a directory with a meson.build file with just a comment in it e.g. "No kernel drivers for this OS", is probably tidier than having if conditions in the higher level build files. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B159DA0679 for ; Mon, 1 Apr 2019 22:10:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB1DE3798; Mon, 1 Apr 2019 22:10:27 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8A8143576 for ; Mon, 1 Apr 2019 22:10:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 13:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="139268405" Received: from mashbery-mobl.ger.corp.intel.com ([10.252.17.42]) by fmsmga007.fm.intel.com with SMTP; 01 Apr 2019 13:10:22 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Apr 2019 21:10:21 +0100 Date: Mon, 1 Apr 2019 21:10:20 +0100 From: Bruce Richardson To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net Message-ID: <20190401201019.GA1466@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401201020.DmF2tuSti60JTmXqq_XSTUfiT5E_50S1AufhHv0sTks@z> On Mon, Apr 01, 2019 at 10:06:18AM -0700, Anand Rawat wrote: > On 4/1/2019 9:34 AM, Bruce Richardson wrote: > > On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: > > > config/meson.build | 23 ++++++++++++------ > > > config/x86/meson.build | 14 ++++++----- > > > lib/librte_eal/meson.build | 6 ++++- > > > lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ > > > lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ > > > lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ > > > lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ > > > lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > > > > I'm a little uncertain behind putting the stub files and the meson.build > > changes in the one patch, since the result doesn't build anyway. However, > > you can get meson to successfully configure the project on windows by > > adding in an empty file called meson.build to the kernel/windows directory. > > > > /Bruce > > > > Thanks Bruce, libm is a part of V8 fixes. > kernel/windows directory is the patch 8/8 as I thought of it as a temporary > workaround. I'll move it to another patch along with meson changes here. Oh, I wasn't thinking of it being temporary, as I assumed you had kernel modules for uio on windows. However, if they are not being hosted on DPDK, I still think having a directory with a meson.build file with just a comment in it e.g. "No kernel drivers for this OS", is probably tidier than having if conditions in the higher level build files.