From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 91AB8A0679
for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 22:37:05 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 42CE34C96;
Mon, 1 Apr 2019 22:37:04 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id E9E844C95;
Mon, 1 Apr 2019 22:37:02 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 2C9DD3082E03;
Mon, 1 Apr 2019 20:37:02 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D08B1001DC1;
Mon, 1 Apr 2019 20:37:01 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "ferruh.yigit\@intel.com" <ferruh.yigit@intel.com>,
"nikhil.rao\@intel.com" <nikhil.rao@intel.com>,
"pallantlax.poornima\@intel.com" <pallantlax.poornima@intel.com>,
"dev\@dpdk.org" <dev@dpdk.org>,
"jananeex.m.parthasarathy\@intel.com" <jananeex.m.parthasarathy@intel.com>,
"reshma.pattan\@intel.com" <reshma.pattan@intel.com>,
"stable\@dpdk.org" <stable@dpdk.org>
References: <1549449822-412-1-git-send-email-pallantlax.poornima@intel.com>
<f7to97mdlld.fsf@dhcp-25.97.bos.redhat.com>
<7AE31235A30B41498D1C31348DC858BD5B534A73@IRSMSX103.ger.corp.intel.com>
<7AE31235A30B41498D1C31348DC858BD5B54DCD4@IRSMSX103.ger.corp.intel.com>
<f7tftrsi23b.fsf@dhcp-25.97.bos.redhat.com>
<fa21b43f-2788-1085-e6df-b49f3c6a5c71@intel.com>
<f7ta7hyriu2.fsf@dhcp-25.97.bos.redhat.com>
<96fe0a31-215e-e6e6-96b0-540ca666951b@intel.com>
<f7twol2q1th.fsf@dhcp-25.97.bos.redhat.com>
<8ed852bffa7d6fda3a20019be2b4542542312983.camel@marvell.com>
Date: Mon, 01 Apr 2019 16:37:00 -0400
In-Reply-To: <8ed852bffa7d6fda3a20019be2b4542542312983.camel@marvell.com>
(Jerin Jacob Kollanukkaran's message of "Sat, 30 Mar 2019 14:15:47
+0000")
Message-ID: <f7tlg0t1mz7.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.46]); Mon, 01 Apr 2019 20:37:02 +0000 (UTC)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf
with snprintf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190401203700.jCjMxYd1cc6TRjPKaTEFKiKT-l5L6UiTnfwt6KqHnEQ@z>
Jerin Jacob Kollanukkaran <jerinj@marvell.com> writes:
> On Wed, 2019-03-13 at 10:35 -0400, Aaron Conole wrote:
>>
>> > For all cases I expect truncation trigger a functional error which
>> > should be
>> > already handled properly, like in this case 'rte_vdev_init()' will
>> > fail in
>> > second call if buffer is small.
>>
>> And give the user a bad error ("I said net_null1038123825, not
>> net_null10
>> - bug in dpdk!").
>>
>> > There may be cases to check the return value, but that should be
>> > the case with
>> > 'sprintf' as well, changing API to 'snprintf' shouldn't require
>> > additional check
>> > by default.
>>
>> I agree, that's true. I think it's the right thing to do here,
>> though.
>
> Aaron,
>
> Are you expecting next version of this patch? Or I can merge this
> patch?
Go ahead and merge.