From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3526BA0679 for ; Tue, 2 Apr 2019 05:33:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E3BC5323; Tue, 2 Apr 2019 05:33:47 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59]) by dpdk.org (Postfix) with ESMTP id 0C14C4F9B for ; Tue, 2 Apr 2019 05:33:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0ZzOcMGU+/KW4I9K4aQK1WUdRQc6y1HTh+F9kMqOao=; b=Be0l5WrgEBbWmJQL7BCNJNv8LqhjX8nHbUmqmr3/ul7+C1YkfKnEo48qt1dCoFv2tihSLE2xu78jjX/wUfnzO/z9eEyeLwMh4sgxduF2Tey/rtHDJVTXqZEVxFOQPIEvGJFjnchhm2SN0NxvEeAZWykin6t4n1QW+WxqIEsDDw4= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3388.eurprd08.prod.outlook.com (20.176.238.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Tue, 2 Apr 2019 03:33:44 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe%5]) with mapi id 15.20.1750.017; Tue, 2 Apr 2019 03:33:44 +0000 From: "Phil Yang (Arm Technology China)" To: "Pattan, Reshma" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "Hunt, David" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd , nd Thread-Topic: [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU5h4f4SycvOPeMUyZPHSuJ0FAPqYiz88AgAGCYuCAAva+AIAA8+Gw Date: Tue, 2 Apr 2019 03:33:43 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1553856998-25394-2-git-send-email-phil.yang@arm.com> <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A43382E@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A43382E@irsmsx110.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd3ae7d9-763b-40dc-323f-08d6b71c021c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB7PR08MB3388; x-ms-traffictypediagnostic: DB7PR08MB3388: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(346002)(376002)(366004)(39860400002)(199004)(189003)(13464003)(93886005)(74316002)(106356001)(2906002)(316002)(2501003)(55016002)(66066001)(72206003)(110136005)(105586002)(54906003)(14454004)(25786009)(446003)(53936002)(71190400001)(478600001)(9686003)(4326008)(86362001)(71200400001)(2201001)(305945005)(5660300002)(102836004)(7736002)(486006)(76176011)(55236004)(229853002)(6506007)(33656002)(53546011)(11346002)(476003)(6246003)(256004)(6436002)(97736004)(8936002)(3846002)(7696005)(68736007)(99286004)(81156014)(81166006)(6116002)(8676002)(52536014)(186003)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3388; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: At4xcA5HQE25EfNSlcys0Vj7qcgoQSe8vIzd/adUUOm2FxNMScEdgyABkfx8su84EAWCOwE6FmGk/yHUkuJcz9OsurKHc9TSI6VbAN8MYrZlsLv8IViFzuJXBnRKuF5q24tSQL94/RwMXk0q2OBVHDqRBQtpGhpFBOxdDc6A3kA9kkAvpzHWlYp0OUowhznU+59E0N9dF/+TEOQPv0IfxnxhJehShrFETzt7qFPR0sukiTHZlr5Z3QrgwJwRb+Lmh5BjMxaca75vBskYwX91MfF6+wfrvjEQjZbI0jJZGsx3Yk1Iubl7fDaXdv/eXlF3UcfJtS2lTGmfelsV92JxBuxMIpM+jpWgdk4eC23clUqoVse/6u3/IeMW1o+LbIOvdDZ/8UhaqJd1sP3/fyWAAtHjPqQOmROsimgyfEiUxoI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd3ae7d9-763b-40dc-323f-08d6b71c021c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 03:33:44.0332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3388 Subject: Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402033343.G2MgQzweu9aBUpRnE95v3RbW5sn4iGgr8gARthw0XV8@z> > -----Original Message----- > From: Pattan, Reshma > Sent: Monday, April 1, 2019 8:58 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > thomas@monjalon.net > Cc: Hunt, David ; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd ; nd > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each work= er > thread >=20 >=20 >=20 > > -----Original Message----- > > From: Phil Yang (Arm Technology China) [mailto:Phil.Yang@arm.com] > > Sent: Saturday, March 30, 2019 4:55 PM > > To: Pattan, Reshma ; dev@dpdk.org; > > thomas@monjalon.net > > Cc: Hunt, David ; Gavin Hu (Arm Technology > > China) ; Honnappa Nagarahalli > > ; nd ; nd > > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each > > worker thread > > > > > -----Original Message----- > > > From: Pattan, Reshma > > > Sent: Saturday, March 30, 2019 12:40 AM > > > To: Phil Yang (Arm Technology China) ; > > > dev@dpdk.org; thomas@monjalon.net > > > Cc: Hunt, David ; Gavin Hu (Arm Technology > > > China) ; Honnappa Nagarahalli > > > ; nd > > > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each > > > worker thread > > > > > > > > > > > > > -----Original Message----- > > > > From: Phil Yang [mailto:phil.yang@arm.com] > > > > > > > > The current implementation using '__sync' built-ins to synchronize > > > > statistics within worker threads. '__sync' built-ins functions are > > > > full barriers which will affect the performance, so add a per > > > > worker packets > > > statistics. > > > > > > > > Enable by option --insight-worker. > > > > > > > > > > I don't feel the need of this new option to print per core stats. > > > Any reason for this? > > > > Hi Reshma, > > > > Thanks for your comment. > > The per core stats aims at removing the '__sync' builtin full barrier > > in the worker thread. > > It records the workload of each core (It shows the bottleneck core as w= ell). > > Since the maximum core number may be more than 128, so disable the > > print in default and add this new option for debugging use. > > >=20 > Ok fine with me then. >=20 > Thanks, > Reshma Thanks for your review. Thanks, Phil