From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CF0FDA0679 for ; Tue, 2 Apr 2019 05:48:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD08854AE; Tue, 2 Apr 2019 05:47:59 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CDF845323 for ; Tue, 2 Apr 2019 05:47:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 20:47:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,298,1549958400"; d="scan'208";a="219690429" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2019 20:47:56 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-9-anand.rawat@intel.com> <1874669.yI0RQQHDzX@xps> From: Anand Rawat Message-ID: Date: Mon, 1 Apr 2019 20:47:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1874669.yI0RQQHDzX@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402034756.I-LuZsmwfsrAf1oD4KzBaDcy9wvQIRJdusArse0ZHUs@z> On 4/1/2019 4:25 PM, Thomas Monjalon wrote: > 29/03/2019 00:24, Anand Rawat: >> Added meson workarounds to build helloworld on windows. >> Windows currently only supports kvargs and eal libraries. >> This change restricts the build flow to supported libraries >> only. > [...] >> --- a/app/meson.build >> +++ b/app/meson.build >> @@ -1,5 +1,9 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> -# Copyright(c) 2017 Intel Corporation >> +# Copyright(c) 2017-2019 Intel Corporation >> + >> +if host_machine.system() == 'windows' >> + subdir_done() >> +endif > > Not sure this change deserves a copyright update :) I am not sure either, basic principle that I am following is if any file is touched with some code/logic the license should be updated. Do correct me if I am wrong. I can make the changes accordingly in the future releases. > >> --- a/examples/meson.build >> +++ b/examples/meson.build >> - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > > Please keep this line intact. > >> + if host_machine.system() != 'windows' >> + deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] >> + else >> + deps = ['eal'] # only supported lib on windows currently >> + endif > > You could override deps for Windows only. > Will be updated in v8 -- Anand Rawat