From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98A49A0679 for ; Tue, 2 Apr 2019 05:52:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97F3C54AE; Tue, 2 Apr 2019 05:52:45 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4C5ED4F9B for ; Tue, 2 Apr 2019 05:52:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 20:52:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,298,1549958400"; d="scan'208";a="219691125" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2019 20:52:42 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, harini.ramakrishnan@microsoft.com, david.marchand@redhat.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-3-anand.rawat@intel.com> <1935221.MXycTWvINB@xps> From: Anand Rawat Message-ID: <92030f2c-44c8-60da-b1b3-6eb251129387@intel.com> Date: Mon, 1 Apr 2019 20:52:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1935221.MXycTWvINB@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402035242.aduTBwMQC95Vk0uahmeLCAba0Z2WEQfkdDubgybfiQQ@z> On 4/1/2019 4:09 PM, Thomas Monjalon wrote: > Hi, > > An update of the legacy Makefiles is missing. > It should be something like that: > > --- a/lib/librte_eal/freebsd/eal/Makefile > +++ b/lib/librte_eal/freebsd/eal/Makefile > @@ -86,7 +86,7 @@ CFLAGS_eal_thread.o += -Wno-return-type > CFLAGS_eal_hpet.o += -Wno-return-type > endif > > -INC := # no bsd specific headers > +INC := rte_os.h > > SYMLINK-$(CONFIG_RTE_EXEC_ENV_FREEBSD)-include := $(addprefix include/,$(INC)) > > --- a/lib/librte_eal/linux/eal/Makefile > +++ b/lib/librte_eal/linux/eal/Makefile > @@ -93,7 +93,8 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > CFLAGS_eal_thread.o += -Wno-return-type > endif > > -INC := rte_kni_common.h > +INC := rte_os.h > +INC += rte_kni_common.h > > SYMLINK-$(CONFIG_RTE_EXEC_ENV_LINUX)-include := $(addprefix include/,$(INC)) > Adding the change to v8 along with a change in mk/target//rte.vars.mk to include path 'librte_eal//eal/include' for rte_os.h. This is done to make it available during the build process. -- Anand Rawat