DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, anand.rawat@intel.com,
	ranjit.menon@intel.com, ferruh.yigit@intel.com,
	david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific
Date: Tue, 02 Apr 2019 14:57:03 +0200	[thread overview]
Message-ID: <1935282.F1JuZfYupj@xps> (raw)
Message-ID: <20190402125703.Wm51l72rwMDCBHCGUlofS7FxmDEa-MQRhZNIsT6JO4k@z> (raw)
In-Reply-To: <20171011143352.GA23500@jerin>

11/10/2017 16:33, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 07/08/2017 14:04, Jerin Jacob:
> > > baremetal execution environments may have a different
> > > method to enable RTE_INIT instead of using compiler
> > > constructor scheme. Move RTE_INIT* definition under
> > > exec-env to support different execution environments.
> > > 
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > >  app/test-eventdev/evt_test.h                       |  2 +-
> > >  lib/librte_eal/bsdapp/eal/Makefile                 |  2 +-
> > >  .../bsdapp/eal/include/exec-env/rte_eal.h          | 51 ++++++++++++++++++++++

I sent a patch to flatten the hierarchy, removing exec-env.
And I'm not sure about the file name rte_eal.h.
Please could you move it to lib/librte_eal/<os>/eal/include/rte_exec_env.h
or another better name? Note that Windows is introducing rte_os.h.
PS: I'm not sure about the intent of rte_os.h. Should it be rte_libc.h?

> > >  lib/librte_eal/common/eal_common_log.c             |  2 +
> > >  lib/librte_eal/common/include/rte_bus.h            |  2 +
> > >  lib/librte_eal/common/include/rte_eal.h            |  6 ---
> > >  lib/librte_eal/common/include/rte_tailq.h          |  2 +
> > >  lib/librte_eal/linuxapp/eal/Makefile               |  2 +-
> > >  .../linuxapp/eal/include/exec-env/rte_eal.h        | 51 ++++++++++++++++++++++
> > 
> > I am not a big fan of duplicating code for Linux and BSD.
> > 
> > Maybe we should have different splits and include a common file
> > in Linux and BSD?
> 
> OK. This is doable.

After some thoughts about Windows port, I think we need to consider
a better split.
The constructors are the same for Linux, BSD and Windows, isn't it?
Is it related to splitting between POSIX libc and others?




  parent reply	other threads:[~2019-04-02 12:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 12:04 Jerin Jacob
2017-10-11 13:02 ` Thomas Monjalon
2017-10-11 14:33   ` Jerin Jacob
2019-03-01 17:05     ` Ferruh Yigit
2019-03-01 17:16       ` Ferruh Yigit
2019-03-01 17:28       ` Thomas Monjalon
2019-03-12 19:25         ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-03-12 20:33           ` Thomas Monjalon
2019-03-13  8:02             ` Jerin Jacob Kollanukkaran
2019-03-13  8:16               ` Thomas Monjalon
2019-03-13  8:44                 ` Jerin Jacob Kollanukkaran
2019-03-14 20:44                   ` Jerin Jacob Kollanukkaran
2019-03-14 20:44                     ` Jerin Jacob Kollanukkaran
2019-04-02  1:15                     ` Jerin Jacob Kollanukkaran
2019-04-02  1:15                       ` Jerin Jacob Kollanukkaran
2019-04-02 12:45                       ` Thomas Monjalon
2019-04-02 12:45                         ` Thomas Monjalon
2019-04-02 12:57     ` Thomas Monjalon [this message]
2019-04-02 12:57       ` [dpdk-dev] " Thomas Monjalon
2019-04-02 13:20       ` Wiles, Keith
2019-04-02 13:20         ` Wiles, Keith
2019-04-03 19:28 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2019-04-03 19:28   ` Jerin Jacob Kollanukkaran
2019-04-03 20:07   ` Thomas Monjalon
2019-04-03 20:07     ` Thomas Monjalon
2019-04-03 21:52     ` Thomas Monjalon
2019-04-03 21:52       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1935282.F1JuZfYupj@xps \
    --to=thomas@monjalon.net \
    --cc=anand.rawat@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=ranjit.menon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).