From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 35A411B1EC for ; Tue, 2 Apr 2019 22:48:04 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id f6so7129790pgs.8 for ; Tue, 02 Apr 2019 13:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kwcIIMZ7k4IyV+gD6kJmcXfb6T17ztS21P9vqK4cA6M=; b=Rhe97oRfyPR3qyAFyegq/xX+lP9Xh35gY8AIOZlXy57PRzNDvXqBaAcnvMrMVwwfqY PisQZMrPBKwB1DemG6dCNv9k+NStBOhufDI51CTXkhZ/DPt/Y4/ghJ9YKCnw1W/93+dh ZKfyJXU/xW05ZOMvBv3do+UFZQTkpIPeITNb4UAI4juw5g0z35Rb3fPgxrzGvKY2yky6 3SKKHQCBWMd8fZfcylUggLImSZ8kRWUz7fhl4u5S7Q/m+E91sFVdX+t/lGqz0dYVbP2H iB1XSTDPgYEgVr51a1KL50lTw9uODVB3XcH9qZctg9wdzfGCtxxa1nKHfNh+RMA96k90 Hmbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kwcIIMZ7k4IyV+gD6kJmcXfb6T17ztS21P9vqK4cA6M=; b=GIwptrOzxiPTTaRIpqOtkR8tSQYjlaxnilGEvM7sReZUz2W+D4Gu7F4vMQcYv/lt92 XeLgY6cl/nQpljYK7Cr9UCbdn5PLxp/SyIOhIrzaA+u9IMlwvhvyM+nBRi6BiTwP0vpY NoPzFE4GXFZFm+2FLikLNahkPWaACysv7KbG8Q2Ty1/9nhgptqS9HiqVB8JyGa/P3UCh rWdBPqHNKrPSZs3UOiyI+KUZoKfrhP+xaB2GXK5RC4ofp+P0Jo576NYaWEEsfwpJI1bQ KPaEuZ6fd6WLR2syHBUQl/4cC+lGWD+9/wPZEAJNM1SyaB0j2prN0nx3RpL56AGbmH2O GO3g== X-Gm-Message-State: APjAAAXdZgJuZYJ+0waCnAoiVNaC9ePWHKC0XSMjJhA/CdngjXKei/2G vDeU0b6XhGA2Tdb/Ks4kD1jcgA== X-Google-Smtp-Source: APXvYqzAsEF4zBRtUynM2Sdtz+gBxlBUnocuhDSwCHSoDyc8IjvffjeKPH7o6QsnqunGPwHdWmVn6w== X-Received: by 2002:a62:1a0d:: with SMTP id a13mr7756466pfa.198.1554238083199; Tue, 02 Apr 2019 13:48:03 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f6sm9612421pgq.11.2019.04.02.13.48.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 13:48:03 -0700 (PDT) Date: Tue, 2 Apr 2019 13:48:00 -0700 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20190402134800.789bd9bf@shemminger-XPS-13-9360> In-Reply-To: References: <20190326192556.19934-1-stephen@networkplumber.org> <20190402155722.21400-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 20:48:04 -0000 On Tue, 2 Apr 2019 22:15:40 +0200 David Marchand wrote: > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger > wrote: > > > C language does not really treat enum's as first class symbols. > > The values in an enum live in a global namespace. That means if > > DPDK defines "RUNNING" it can't be used by another enum in an > > application using DPDK. > > > > To solve this add a prefix "RTE_LCORE_" to the enum values, and > > make them grammatically consistent. > > > > Well, I understand this is not clean, but this patch breaks the API. The lcore state was marked as internal in the header file, code that ignores that is going to have problems. The values are the same. We could defer this to 19.11 (next LTS) since it is cosmetic. At that time, I am willing to do more work to make lcore_config hidden; ie no inline's to access it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DF77EA0679 for ; Tue, 2 Apr 2019 22:48:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9259C1B1F4; Tue, 2 Apr 2019 22:48:06 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 35A411B1EC for ; Tue, 2 Apr 2019 22:48:04 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id f6so7129790pgs.8 for ; Tue, 02 Apr 2019 13:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kwcIIMZ7k4IyV+gD6kJmcXfb6T17ztS21P9vqK4cA6M=; b=Rhe97oRfyPR3qyAFyegq/xX+lP9Xh35gY8AIOZlXy57PRzNDvXqBaAcnvMrMVwwfqY PisQZMrPBKwB1DemG6dCNv9k+NStBOhufDI51CTXkhZ/DPt/Y4/ghJ9YKCnw1W/93+dh ZKfyJXU/xW05ZOMvBv3do+UFZQTkpIPeITNb4UAI4juw5g0z35Rb3fPgxrzGvKY2yky6 3SKKHQCBWMd8fZfcylUggLImSZ8kRWUz7fhl4u5S7Q/m+E91sFVdX+t/lGqz0dYVbP2H iB1XSTDPgYEgVr51a1KL50lTw9uODVB3XcH9qZctg9wdzfGCtxxa1nKHfNh+RMA96k90 Hmbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kwcIIMZ7k4IyV+gD6kJmcXfb6T17ztS21P9vqK4cA6M=; b=GIwptrOzxiPTTaRIpqOtkR8tSQYjlaxnilGEvM7sReZUz2W+D4Gu7F4vMQcYv/lt92 XeLgY6cl/nQpljYK7Cr9UCbdn5PLxp/SyIOhIrzaA+u9IMlwvhvyM+nBRi6BiTwP0vpY NoPzFE4GXFZFm+2FLikLNahkPWaACysv7KbG8Q2Ty1/9nhgptqS9HiqVB8JyGa/P3UCh rWdBPqHNKrPSZs3UOiyI+KUZoKfrhP+xaB2GXK5RC4ofp+P0Jo576NYaWEEsfwpJI1bQ KPaEuZ6fd6WLR2syHBUQl/4cC+lGWD+9/wPZEAJNM1SyaB0j2prN0nx3RpL56AGbmH2O GO3g== X-Gm-Message-State: APjAAAXdZgJuZYJ+0waCnAoiVNaC9ePWHKC0XSMjJhA/CdngjXKei/2G vDeU0b6XhGA2Tdb/Ks4kD1jcgA== X-Google-Smtp-Source: APXvYqzAsEF4zBRtUynM2Sdtz+gBxlBUnocuhDSwCHSoDyc8IjvffjeKPH7o6QsnqunGPwHdWmVn6w== X-Received: by 2002:a62:1a0d:: with SMTP id a13mr7756466pfa.198.1554238083199; Tue, 02 Apr 2019 13:48:03 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f6sm9612421pgq.11.2019.04.02.13.48.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 13:48:03 -0700 (PDT) Date: Tue, 2 Apr 2019 13:48:00 -0700 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20190402134800.789bd9bf@shemminger-XPS-13-9360> In-Reply-To: References: <20190326192556.19934-1-stephen@networkplumber.org> <20190402155722.21400-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402204800.pTZ1-Kgc7Mz7HcYplMQidSw7c2GbM8ohriEib3AvmS0@z> On Tue, 2 Apr 2019 22:15:40 +0200 David Marchand wrote: > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger > wrote: > > > C language does not really treat enum's as first class symbols. > > The values in an enum live in a global namespace. That means if > > DPDK defines "RUNNING" it can't be used by another enum in an > > application using DPDK. > > > > To solve this add a prefix "RTE_LCORE_" to the enum values, and > > make them grammatically consistent. > > > > Well, I understand this is not clean, but this patch breaks the API. The lcore state was marked as internal in the header file, code that ignores that is going to have problems. The values are the same. We could defer this to 19.11 (next LTS) since it is cosmetic. At that time, I am willing to do more work to make lcore_config hidden; ie no inline's to access it.