From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v2] rte_ring: add newline to error message
Date: Tue, 2 Apr 2019 08:30:26 -0700 [thread overview]
Message-ID: <20190402153026.17951-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20190321230341.6576-1-stephen@networkplumber.org>
Log message should end with newline.
Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
---
v2 -- fix punctuation in message as well
lib/librte_ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c
index d215aceccf46..550549db3924 100644
--- a/lib/librte_ring/rte_ring.c
+++ b/lib/librte_ring/rte_ring.c
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
* therefore, there is no memzone to free.
*/
if (r->memzone == NULL) {
- RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+ RTE_LOG(ERR, RING,
+ "Cannot free ring, not created with rte_ring_create()\n");
return;
}
--
2.17.1
next prev parent reply other threads:[~2019-04-02 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 23:03 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-03-21 23:03 ` Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
2019-03-22 9:49 ` Rami Rosen
2019-03-27 11:21 ` Thomas Monjalon
2019-03-27 11:21 ` Thomas Monjalon
2019-04-02 15:30 ` Stephen Hemminger [this message]
2019-04-02 15:30 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-04-03 16:40 ` Thomas Monjalon
2019-04-03 16:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402153026.17951-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).