From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EA19DA0679 for ; Tue, 2 Apr 2019 18:33:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E4284CA0; Tue, 2 Apr 2019 18:33:07 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130078.outbound.protection.outlook.com [40.107.13.78]) by dpdk.org (Postfix) with ESMTP id E8E3D37A8 for ; Tue, 2 Apr 2019 18:33:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GufT2eYoHlDSdlrP7+zIw+kS3+tWZ8IPlvNxpZ8HCOU=; b=MQ+u2u4a4kozWHgIuxRUjavCbfYLNp3KNXG1thm6sQ0Pt6vlElvwC18AY42/8j5UU4o2d+Ovuk0Q+G7I0ubPpodrYs94+DxJVd1qjcp4ZrHBBC8A4grJGutlO8m8zB4SwabA8SS3a8z8lve61B7foz3JrTeM8Qmr3isU8I+t2lw= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3475.eurprd05.prod.outlook.com (10.171.186.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 16:33:04 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5df0:22de:97f0:3827]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5df0:22de:97f0:3827%4]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 16:33:04 +0000 From: Ori Kam To: Dekel Peled , Adrien Mazarguil , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields Thread-Index: AQHU6Wbd7vklhq4/rk6qaIHuITf9YKYpEJLQ Date: Tue, 2 Apr 2019 16:33:04 +0000 Message-ID: References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com> <1554218001-62012-2-git-send-email-dekelp@mellanox.com> In-Reply-To: <1554218001-62012-2-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd751490-ceca-4325-e7ad-08d6b788e140 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM4PR05MB3475; x-ms-traffictypediagnostic: AM4PR05MB3475: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(366004)(136003)(39860400002)(199004)(189003)(13464003)(476003)(81156014)(54906003)(2201001)(478600001)(256004)(229853002)(6436002)(14444005)(8936002)(97736004)(81166006)(14454004)(9686003)(2501003)(316002)(68736007)(99286004)(110136005)(446003)(7736002)(3846002)(71200400001)(6116002)(71190400001)(76176011)(106356001)(26005)(25786009)(86362001)(11346002)(6506007)(66066001)(102836004)(7696005)(186003)(6636002)(6246003)(305945005)(74316002)(2906002)(33656002)(486006)(4326008)(53936002)(107886003)(105586002)(52536014)(5660300002)(55016002)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3475; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Uvsj4eXvYuzC5E5QQm8cQoZsiWbCiQe6T/TQJAaGqyoimqrDV0mzotjQYZ/Bdu49pJu0Obkr0rATzAa3fseNmIPXxKnSPquvDnYCJy2W2FAdCvFKzbrOtXVL8LX3PldOWFsG6UD4nR5iU0wphnEppx4QYS38iZFsX9LVRTpr1ya6NgX8lFO2eidPZOi+mtDjzIfbSeN8Q/0LPBBwTGw+2cRBmFrUuBxN/2su9RNT/ZTMkgtbEvdG0EZzaE7vLYqbtI9hwm8w3PSh4yAqM7Swws0MEsxq6Px+l107PGOZRd9zuYH67OkgT0Zp7q4JYsFJX4w0jzIkL6ZfZe2uNyK/VhX7itwLMWyDkDezTHb5H+aK/Wowtv+Thd8JNI1gH/PJAFAhv3bxm82lT6ckh4xYfDKKAh3rofQkSN4nUE4/PiE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd751490-ceca-4325-e7ad-08d6b788e140 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 16:33:04.0565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3475 Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402163304.Q099QQowFjcS7a4Evm3Hj71DHIGi23TwK4ggL1FakqA@z> > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, April 2, 2019 6:13 PM > To: Adrien Mazarguil ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com; Yongseok Koh > ; Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP head= er > fields >=20 > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP > header. > - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP > header. >=20 > Original work by Xiaoyu Min. >=20 > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 72 > ++++++++++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_flow.c | 8 +++++ > lib/librte_ethdev/rte_flow.h | 70 > ++++++++++++++++++++++++++++++++++++ > 3 files changed, 150 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 0203f4f..5bebb29 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2345,6 +2345,78 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error > will be returned. > | ``mac_addr`` | MAC address | > +--------------+---------------+ >=20 > +Action: ``INC_TCP_SEQ`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Increase sequence number in the outermost TCP header. > + > +If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP flow patte= rn > item, > +behavior is unspecified, depending on PMD implementation. > + > +.. _table_rte_flow_action_inc_tcp_seq: > + > +.. table:: INC_TCP_SEQ > + > + +-----------+------------------------------------------+ > + | Field | Value | > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to increase TCP sequence number by | > + +-----------+------------------------------------------+ > + > +Action: ``DEC_TCP_SEQ`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Decrease sequence number in the outermost TCP header. > + > +If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP flow patte= rn > item, > +behavior is unspecified, depending on PMD implementation. > + > +.. _table_rte_flow_action_dec_tcp_seq: > + > +.. table:: DEC_TCP_SEQ > + > + +-----------+------------------------------------------+ > + | Field | Value | > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to decrease TCP sequence number by | > + +-----------+------------------------------------------+ > + > +Action: ``INC_TCP_ACK`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Increase acknowledgment number in the outermost TCP header. > + > +If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP flow patte= rn > item, > +behavior is unspecified, depending on PMD implementation. > + > +.. _table_rte_flow_action_inc_tcp_ack: > + > +.. table:: INC_TCP_ACK > + > + +-----------+------------------------------------------------+ > + | Field | Value | > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to increase TCP acknowledgment number by | > + +-----------+------------------------------------------------+ > + > +Action: ``DEC_TCP_ACK`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Decrease acknowledgment number in the outermost TCP header. > + > +If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP flow patte= rn > item, > +behavior is unspecified, depending on PMD implementation. > + > +.. _table_rte_flow_action_dec_tcp_ack: > + > +.. table:: DEC_TCP_ACK > + > + +-----------+------------------------------------------------+ > + | Field | Value | > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > + | ``value`` | Value to decrease TCP acknowledgment number by | > + +-----------+------------------------------------------------+ > + > Negative types > ~~~~~~~~~~~~~~ >=20 > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > index 3277be1..589d0b9 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -143,6 +143,14 @@ struct rte_flow_desc_data { > MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)), > MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct > rte_flow_action_set_mac)), > MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct > rte_flow_action_set_mac)), > + MK_FLOW_ACTION(INC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + MK_FLOW_ACTION(DEC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + MK_FLOW_ACTION(INC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > + MK_FLOW_ACTION(DEC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > }; >=20 > static int > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index c0fe879..eca7544 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1651,6 +1651,50 @@ enum rte_flow_action_type { > * See struct rte_flow_action_set_mac. > */ > RTE_FLOW_ACTION_TYPE_SET_MAC_DST, > + > + /** > + * Increase sequence number in the outermost TCP header. > + * > + * If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP > + * flow pattern item, behavior is unspecified, depending on > + * PMD implementation. > + * > + * See struct rte_flow_action_modify_tcp_seq > + */ > + RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ, > + > + /** > + * Decrease sequence number in the outermost TCP header. > + * > + * If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP > + * flow pattern item, behavior is unspecified, depending on > + * PMD implementation. > + * > + * See struct rte_flow_action_modify_tcp_seq > + */ > + RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ, > + > + /** > + * Increase acknowledgment number in the outermost TCP header. > + * > + * If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP > + * flow pattern item, behavior is unspecified, depending on > + * PMD implementation. > + * > + * See struct rte_flow_action_modify_tcp_ack > + */ > + RTE_FLOW_ACTION_TYPE_INC_TCP_ACK, > + > + /** > + * Decrease acknowledgment number in the outermost TCP header. > + * > + * If this action is used without a valid RTE_FLOW_ITEM_TYPE_TCP > + * flow pattern item, behavior is unspecified, depending on > + * PMD implementation. > + * > + * See struct rte_flow_action_modify_tcp_ack > + */ > + RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK, > }; >=20 > /** > @@ -2122,6 +2166,32 @@ struct rte_flow_action_set_mac { > uint8_t mac_addr[ETHER_ADDR_LEN]; > }; >=20 > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > + * RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > + * > + * Increase/Decrease outermost TCP sequence number > + */ > +struct rte_flow_action_modify_tcp_seq { > + rte_be32_t value; /**< Value to increase/decrease by. */ > +}; > + > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > + * RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > + * > + * Increase/Decrease outermost TCP acknowledgment number. > + */ > +struct rte_flow_action_modify_tcp_ack { > + rte_be32_t value; /**< Value to increase/decrease by. */ > +}; > + > /* > * Definition of a single action. > * > -- > 1.8.3.1 Thanks, Acked-by: Ori Kam