From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ABFEBA0679 for ; Tue, 2 Apr 2019 18:33:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 770AF5681; Tue, 2 Apr 2019 18:33:47 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59]) by dpdk.org (Postfix) with ESMTP id 8345C54AE for ; Tue, 2 Apr 2019 18:33:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2BX49Jm9fTEoIFfyaACRRzMaKad/pfZ/9K+FWTX8Zcc=; b=dyC7RnL8x7Ve0ChND5AcBWeT+5Bm3f9uFGKH/cqNQJvN2j7H4dG6z+upH8vQx4FEPhLeHgJktpejulPxeTMZRwa5Wzk4MQbXbjUOsmFnc7qbqGTR0YNEENA/eJP/BjMjhrHltO3RB1AqEoNoRrN857Muk5XQc514H5leOTok+KQ= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3475.eurprd05.prod.outlook.com (10.171.186.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 16:33:45 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5df0:22de:97f0:3827]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::5df0:22de:97f0:3827%4]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 16:33:45 +0000 From: Ori Kam To: Dekel Peled , Adrien Mazarguil , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , Dekel Peled Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add actions to modify TCP header fields Thread-Index: AQHU6Wbj+ennxyTG40maKYuR+dHETKYpELNQ Date: Tue, 2 Apr 2019 16:33:44 +0000 Message-ID: References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com> <1554218001-62012-3-git-send-email-dekelp@mellanox.com> In-Reply-To: <1554218001-62012-3-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ffeac293-89c4-4e8d-75a9-08d6b788f99e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM4PR05MB3475; x-ms-traffictypediagnostic: AM4PR05MB3475: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(366004)(136003)(39860400002)(199004)(189003)(13464003)(476003)(81156014)(54906003)(2201001)(478600001)(256004)(229853002)(6436002)(8936002)(97736004)(81166006)(14454004)(9686003)(2501003)(316002)(68736007)(99286004)(110136005)(446003)(7736002)(3846002)(71200400001)(6116002)(71190400001)(76176011)(106356001)(26005)(25786009)(86362001)(11346002)(6506007)(66066001)(102836004)(7696005)(186003)(6636002)(6246003)(305945005)(74316002)(2906002)(33656002)(486006)(4326008)(53936002)(107886003)(105586002)(52536014)(5660300002)(55016002)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3475; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: t9Xgkv/X6jTQ6QThbvOIWIRRaAfElOR1FnJt/4HXgocgsFhyf983bhkXyAlr9/EBTOeV572Od2qONTPdtxHJzeyg6sleNlVe3VdrT+yBfKnXfHsoIfpA4jUSKJNCD3oqzasYZU8adVBweQWoGnpFW/07E6uR68za0EgCan5BgvpnipEmpRl/1VCGoVILc3b99JpHncHH+6k1gr39IEpOCq1am1Mlr68jGXtyepVt0u35Jke1z6/suR8xO5dTDz029zSIuCAuKvPgkwSgxokpQp29yGW6Lk7MDgUvHXqMi2qbq7wHr9o0THiIBko3dmE6ipEux7hztHhNMPJdxqsAxi5nUdqGprVeMq5yPETI0DS066CqFmG29v7zs3JDu9r+FC+a9Ug+mlFL8jIn+jNXHwZHCEpYn4lVnmN3B1KR2o0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffeac293-89c4-4e8d-75a9-08d6b788f99e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 16:33:44.9349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3475 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402163344.qn0w9ofU4ukjfSr6JIimsV-zNq-WfBiztgSntgSIECM@z> > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, April 2, 2019 6:13 PM > To: Adrien Mazarguil ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com; Yongseok Koh > ; Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add actions to modify TCP > header fields >=20 > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP > header. > - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP > header. >=20 > Original work by Xiaoyu Min. >=20 > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline_flow.c | 100 > ++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 +++++ > 2 files changed, 116 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 36659a6..5cd4ceb 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -271,6 +271,14 @@ enum index { > ACTION_SET_MAC_SRC_MAC_SRC, > ACTION_SET_MAC_DST, > ACTION_SET_MAC_DST_MAC_DST, > + ACTION_INC_TCP_SEQ, > + ACTION_INC_TCP_SEQ_VALUE, > + ACTION_DEC_TCP_SEQ, > + ACTION_DEC_TCP_SEQ_VALUE, > + ACTION_INC_TCP_ACK, > + ACTION_INC_TCP_ACK_VALUE, > + ACTION_DEC_TCP_ACK, > + ACTION_DEC_TCP_ACK_VALUE, > }; >=20 > /** Maximum size for pattern in struct rte_flow_item_raw. */ > @@ -884,6 +892,10 @@ struct parse_action_priv { > ACTION_SET_TTL, > ACTION_SET_MAC_SRC, > ACTION_SET_MAC_DST, > + ACTION_INC_TCP_SEQ, > + ACTION_DEC_TCP_SEQ, > + ACTION_INC_TCP_ACK, > + ACTION_DEC_TCP_ACK, > ZERO, > }; >=20 > @@ -1046,6 +1058,30 @@ struct parse_action_priv { > ZERO, > }; >=20 > +static const enum index action_inc_tcp_seq[] =3D { > + ACTION_INC_TCP_SEQ_VALUE, > + ACTION_NEXT, > + ZERO, > +}; > + > +static const enum index action_dec_tcp_seq[] =3D { > + ACTION_DEC_TCP_SEQ_VALUE, > + ACTION_NEXT, > + ZERO, > +}; > + > +static const enum index action_inc_tcp_ack[] =3D { > + ACTION_INC_TCP_ACK_VALUE, > + ACTION_NEXT, > + ZERO, > +}; > + > +static const enum index action_dec_tcp_ack[] =3D { > + ACTION_DEC_TCP_ACK_VALUE, > + ACTION_NEXT, > + ZERO, > +}; > + > static int parse_init(struct context *, const struct token *, > const char *, unsigned int, > void *, unsigned int); > @@ -2843,6 +2879,70 @@ static int comp_vc_action_rss_queue(struct context > *, const struct token *, > (struct rte_flow_action_set_mac, mac_addr)), > .call =3D parse_vc_conf, > }, > + [ACTION_INC_TCP_SEQ] =3D { > + .name =3D "inc_tcp_seq", > + .help =3D "increase TCP sequence number", > + .priv =3D PRIV_ACTION(INC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + .next =3D NEXT(action_inc_tcp_seq), > + .call =3D parse_vc, > + }, > + [ACTION_INC_TCP_SEQ_VALUE] =3D { > + .name =3D "value", > + .help =3D "the value to increase TCP sequence number by", > + .next =3D NEXT(action_inc_tcp_seq, NEXT_ENTRY(UNSIGNED)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_modify_tcp_seq, value)), > + .call =3D parse_vc_conf, > + }, > + [ACTION_DEC_TCP_SEQ] =3D { > + .name =3D "dec_tcp_seq", > + .help =3D "decrease TCP sequence number", > + .priv =3D PRIV_ACTION(DEC_TCP_SEQ, > + sizeof(struct rte_flow_action_modify_tcp_seq)), > + .next =3D NEXT(action_dec_tcp_seq), > + .call =3D parse_vc, > + }, > + [ACTION_DEC_TCP_SEQ_VALUE] =3D { > + .name =3D "value", > + .help =3D "the value to decrease TCP sequence number by", > + .next =3D NEXT(action_dec_tcp_seq, NEXT_ENTRY(UNSIGNED)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_modify_tcp_seq, value)), > + .call =3D parse_vc_conf, > + }, > + [ACTION_INC_TCP_ACK] =3D { > + .name =3D "inc_tcp_ack", > + .help =3D "increase TCP acknowledgment number", > + .priv =3D PRIV_ACTION(INC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > + .next =3D NEXT(action_inc_tcp_ack), > + .call =3D parse_vc, > + }, > + [ACTION_INC_TCP_ACK_VALUE] =3D { > + .name =3D "value", > + .help =3D "the value to increase TCP acknowledgment number > by", > + .next =3D NEXT(action_inc_tcp_ack, NEXT_ENTRY(UNSIGNED)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_modify_tcp_ack, value)), > + .call =3D parse_vc_conf, > + }, > + [ACTION_DEC_TCP_ACK] =3D { > + .name =3D "dec_tcp_ack", > + .help =3D "decrease TCP acknowledgment number", > + .priv =3D PRIV_ACTION(DEC_TCP_ACK, > + sizeof(struct rte_flow_action_modify_tcp_ack)), > + .next =3D NEXT(action_dec_tcp_ack), > + .call =3D parse_vc, > + }, > + [ACTION_DEC_TCP_ACK_VALUE] =3D { > + .name =3D "value", > + .help =3D "the value to decrease TCP acknowledgment number > by", > + .next =3D NEXT(action_dec_tcp_ack, NEXT_ENTRY(UNSIGNED)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_modify_tcp_ack, value)), > + .call =3D parse_vc_conf, > + }, > }; >=20 > /** Remove and return last entry from argument stack. */ > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index bcf1449..bf93cea 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3997,6 +3997,22 @@ This section lists supported actions and their > attributes, if any. >=20 > - ``mac_addr {MAC-48}``: new destination MAC address >=20 > +- ``inc_tcp_seq``: Increase sequence number in the outermost TCP header. > + > + - ``value {unsigned}``: Value to increase TCP sequence number by. > + > +- ``dec_tcp_seq``: Decrease sequence number in the outermost TCP header. > + > + - ``value {unsigned}``: Value to decrease TCP sequence number by. > + > +- ``inc_tcp_ack``: Increase acknowledgment number in the outermost TCP > header. > + > + - ``value {unsigned}``: Value to increase TCP acknowledgment number by= . > + > +- ``dec_tcp_ack``: Decrease acknowledgment number in the outermost TCP > header. > + > + - ``value {unsigned}``: Value to decrease TCP acknowledgment number by= . > + > Destroying flow rules > ~~~~~~~~~~~~~~~~~~~~~ >=20 > -- > 1.8.3.1 Thanks, Acked-by: Ori Kam