DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tom Barbette <barbette@kth.se>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp
Date: Tue, 2 Apr 2019 21:39:16 +0200	[thread overview]
Message-ID: <b9c51d91-496f-0847-9158-f7a77e0f3529@kth.se> (raw)
Message-ID: <20190402193916.gqdYHBAAyheHlUXGme3WbS_ZwRrX3PL8cZbuiJbESlA@z> (raw)
In-Reply-To: <5ea4b14e-6db9-7d7a-6b15-33fef4c3cd16@intel.com>

Le 02/04/2019 à 20:22, Ferruh Yigit a écrit :
> Same comment as ethdev one, above code assume if driver announces
> 'DEV_RX_OFFLOAD_TIMESTAMP' capability, it have to implement 'read_clock'
> dev_ops, should it be the case?
> 
> Write now only mlx implements it so this is not a problem at all, but I don't
> know if all PMDs supports timestamping packets must implement 'read_clock'.

I changed the init code to fail if rte_eth_read_clock did not work 
during the initialization of the base clock.

Other comments are applied.

Thanks!

Tom

  parent reply	other threads:[~2019-04-02 19:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27  6:19 [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Tom Barbette
2019-03-27  6:19 ` Tom Barbette
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 17:46   ` Ferruh Yigit
2019-04-02 17:46     ` Ferruh Yigit
2019-04-02 19:24     ` Tom Barbette
2019-04-02 19:24       ` Tom Barbette
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 2/3] mlx5: Implement support for read_clock Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 17:47   ` Ferruh Yigit
2019-04-02 17:47     ` Ferruh Yigit
2019-04-02 18:26   ` Ferruh Yigit
2019-04-02 18:26     ` Ferruh Yigit
2019-04-02 19:05     ` Tom Barbette
2019-04-02 19:05       ` Tom Barbette
2019-04-03  5:28   ` Shahaf Shuler
2019-04-03  5:28     ` Shahaf Shuler
2019-03-27  6:19 ` [dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp Tom Barbette
2019-03-27  6:19   ` Tom Barbette
2019-04-02 18:22   ` Ferruh Yigit
2019-04-02 18:22     ` Ferruh Yigit
2019-04-02 19:39     ` Tom Barbette [this message]
2019-04-02 19:39       ` Tom Barbette
2019-03-27 14:41 ` [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Stephen Hemminger
2019-03-27 14:41   ` Stephen Hemminger
2019-03-27 14:48   ` Thomas Monjalon
2019-03-27 14:48     ` Thomas Monjalon
2019-03-27 14:54   ` Wiles, Keith
2019-03-27 14:54     ` Wiles, Keith
2019-03-27 16:08     ` Tom Barbette
2019-03-27 16:08       ` Tom Barbette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9c51d91-496f-0847-9158-f7a77e0f3529@kth.se \
    --to=barbette@kth.se \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).