From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id E8012A0679
	for <public@inbox.dpdk.org>; Tue,  2 Apr 2019 21:39:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C0B081B0F7;
	Tue,  2 Apr 2019 21:39:20 +0200 (CEST)
Received: from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192])
 by dpdk.org (Postfix) with ESMTP id 979C17D52
 for <dev@dpdk.org>; Tue,  2 Apr 2019 21:39:19 +0200 (CEST)
Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1])
 by smtp-3.sys.kth.se (Postfix) with ESMTP id 37D189E5D;
 Tue,  2 Apr 2019 21:39:19 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at kth.se
Received: from smtp-3.sys.kth.se ([127.0.0.1])
 by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 5pab-or1dmY6; Tue,  2 Apr 2019 21:39:18 +0200 (CEST)
X-KTH-Auth: barbette [83.249.19.162]
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default;
 t=1554233958; bh=soU7uHi2JjR8BZKADUHgS6KazHN/rOMKf2TC33bTcdk=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Ndw1MJNZVTi9fshOlAzk4e4RpWnYroAv4BG5Fpv1w5Oxg78Xdiq14rdQ7eHNmfebe
 3OHkoMTCQRvW7OoHG0vRNDFWekDQAlLXmoNfiUL/oqD+bNfKE8CHuwejSfSTVmvDGP
 bb47flfPPCfd3pYxeA1l81Co3afJ1snmi3VDn3BQ=
X-KTH-mail-from: barbette@kth.se
Received: from [192.168.0.59] (c83-249-19-162.bredband.comhem.se
 [83.249.19.162])
 by smtp-3.sys.kth.se (Postfix) with ESMTPSA id BC0DB9DF4;
 Tue,  2 Apr 2019 21:39:17 +0200 (CEST)
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "john.mcnamara@intel.com" <john.mcnamara@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
References: <20190327061935.19572-1-barbette@kth.se>
 <20190327061935.19572-4-barbette@kth.se>
 <5ea4b14e-6db9-7d7a-6b15-33fef4c3cd16@intel.com>
From: Tom Barbette <barbette@kth.se>
Message-ID: <b9c51d91-496f-0847-9158-f7a77e0f3529@kth.se>
Date: Tue, 2 Apr 2019 21:39:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <5ea4b14e-6db9-7d7a-6b15-33fef4c3cd16@intel.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW
	timestamp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190402193916.gqdYHBAAyheHlUXGme3WbS_ZwRrX3PL8cZbuiJbESlA@z>

Le 02/04/2019 à 20:22, Ferruh Yigit a écrit :
> Same comment as ethdev one, above code assume if driver announces
> 'DEV_RX_OFFLOAD_TIMESTAMP' capability, it have to implement 'read_clock'
> dev_ops, should it be the case?
> 
> Write now only mlx implements it so this is not a problem at all, but I don't
> know if all PMDs supports timestamping packets must implement 'read_clock'.

I changed the init code to fail if rte_eth_read_clock did not work 
during the initialization of the base clock.

Other comments are applied.

Thanks!

Tom