From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 9E871A0679
	for <public@inbox.dpdk.org>; Tue,  2 Apr 2019 21:46:42 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2E3E01B0F9;
	Tue,  2 Apr 2019 21:46:42 +0200 (CEST)
Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com
 [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 35D8B1B0F7
 for <dev@dpdk.org>; Tue,  2 Apr 2019 21:46:40 +0200 (CEST)
Received: by mail-vs1-f68.google.com with SMTP id a190so8555309vsd.0
 for <dev@dpdk.org>; Tue, 02 Apr 2019 12:46:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Riy63hij7CpiLiWYkbNTnDnfJKhtK0XLVx9XG8HBIdg=;
 b=WL8iSL9iWppbyz9S7xAhbogb421GfLjHNP3SK/7NzuwviaKmuMofYYl7E70f/rloLM
 ZCFL0bNyawQTj5KYW7Aab7CziEW+OdqxkrCBjrLEk7gVFWCIfyynFkncD5hHUm2EEZt7
 vVHUN6EVlvTdJEk+gN6KCYybVH4d9zla1+h8Yk5MfFsCF7lT2Ge2sj2xyfrdq8KjVjsB
 tk6wKMm6gjDaquiNcb8xvyBmLxoXrURb+9g3u5QU/pVKd+v47K/StqTmmvIGDRfPWTS1
 /fu0Mkca5U48ca2UrY3l48QEhM2Q1UgIpm7XT2qWcUKp/wBQq7dwI3r7toVk/d3WDcTF
 sBZg==
X-Gm-Message-State: APjAAAWvMk1FubsRwy3hmZPynI7YvLLYyTNMoeHfQRyPxwDlmTAml6UM
 T/5U/o+nqAXkQudoRMugRI50mLtqAtEE+v4csdB95A==
X-Google-Smtp-Source: APXvYqyrz9zWhv8UFM2Gk5VjmmoYylxPwcMpV2Jzb/gqthv5JxW8A/CdbCQbMaRZHN4ihR04QBXCbakdvP2+aheJ9k8=
X-Received: by 2002:a67:ed59:: with SMTP id m25mr43157081vsp.100.1554234399533; 
 Tue, 02 Apr 2019 12:46:39 -0700 (PDT)
MIME-Version: 1.0
References: <20190401230712.31864-1-thomas@monjalon.net>
 <20190402193048.27410-1-thomas@monjalon.net>
In-Reply-To: <20190402193048.27410-1-thomas@monjalon.net>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 2 Apr 2019 21:46:28 +0200
Message-ID:
 <CAJFAV8yj5KFqLZS7666hrCy_33qGjpAQC7BOUma=88S2BTWyew@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>,
 Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Anand Rawat <anand.rawat@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190402194628.8ea8DJDaWiHU2ZIPlPj9X2IH2MfBk_PB__eAFMd0Soc@z>

On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> Only one header file (rte_kni_common.h) was in the sub-directory
>         include/exec-env/
> This file was installed in a sub-directory of the same name
> in the makefile-based build.
> Source and install directories are moved as below:
>
>    lib/librte_eal/linux/eal/include/exec-env/
> -> lib/librte_eal/linux/eal/include/
>
>    build/include/exec-env/
> -> build/include/
>
> The consequence is to have a file hierarchy a bit more flat.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>

Looks good to me.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Tested-by: David Marchand <david.marchand@redhat.com>


Bruce, while testing with meson, I noticed this:
kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument
"console".
WARNING: This will become a hard error in the future.
WARNING: Unknown keyword arguments in target rte_kni: console


-- 
David Marchand