From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 6FCECA0679
for <public@inbox.dpdk.org>; Tue, 2 Apr 2019 22:06:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 284551B122;
Tue, 2 Apr 2019 22:06:12 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A93871B107
for <dev@dpdk.org>; Tue, 2 Apr 2019 22:06:10 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 4CF1A220DE;
Tue, 2 Apr 2019 16:06:10 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 02 Apr 2019 16:06:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=DJalqZiKVWfQ97/MFTWbKqVfkVfShgymyqjN3Fd4ZJY=; b=TgntYLRhQxQI
wwX+cqYO7OE1/CXpwZaxOeeJaW8Z8jvzqIWDFLxDcv6WtKN+FtpFHFrLIrTZJ9eT
ExStcg5WaESvgaODK8zNnxQoOaCP7m/dtiJJO5sq5Nehd1hKp6iuQmqcdDr218Vr
ViWQsCEQraIdJll9rkAfQfn+j/Y4OY0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=DJalqZiKVWfQ97/MFTWbKqVfkVfShgymyqjN3Fd4Z
JY=; b=dMgOl7biXXCaihlRNbFealxFu6f+7d1vNzvw0RPBmMM12MWFta7+niAZI
zWFI3AyLYjhImWXK5YKx6cssMBXW8F7y+Enf7+mxfDui71gebX3BNDFfeUjMeTNp
5h1NqPlZ9/62CJSId1Z5TM5id84EHbbaVk6ypvpKkAjdbBGP2X0DMYH47amIWhzQ
pwFM3kV8+zln7tMjRhewcQRk1q9jk9iwiX7AM37nr1H8YJMXgYlCw/2JaDIAsLNx
WyfpUTRpf7+gdPlK1dcxbAJJbXW+OCFQRzrpvcuGyiMunDMqjzrrFZUMD07pXcIN
qScVoHECbRcqmLpvzq1+u6uWZOPJQ==
X-ME-Sender: <xms:scCjXD0sua6ntuMUi3S-uCMso0WahzgqTHqy9EQGC-Uzf4f7O2Vw0Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdduvdegucdltddurdeguddtrddttd
dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv
pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih
gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv
necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh
grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm
pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush
htvghrufhiiigvpedt
X-ME-Proxy: <xmx:scCjXHTrUqHBHn4FkJT0QG-3uEb5zkgGIcQDCzfDdLpRFOpt_ql3_Q>
<xmx:scCjXHQAM_Zs-KvgGJLEJTtHZ_CXb-h1YIlXCoV4ZSDsaqXdVTKsiw>
<xmx:scCjXIWoLUcq1K4s8fP4v4euvmyM0Pg_jjAMnyFn4tKTAASeeiGGJA>
<xmx:ssCjXKw5PtO2EwzvYVo0BiJZKv2XxHXswIDr9-OdoKJg1gHL4VNS2Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id C2D6AE43A3;
Tue, 2 Apr 2019 16:06:08 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anand Rawat <anand.rawat@intel.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
jeffrey.b.shaw@intel.com, bruce.richardson@intel.com
Date: Tue, 02 Apr 2019 22:06:06 +0200
Message-ID: <3868443.jK6Cv4ngdr@xps>
In-Reply-To: <20190402035458.14664-9-anand.rawat@intel.com>
References: <20190306041634.12976-1-anand.rawat@intel.com>
<20190402035458.14664-1-anand.rawat@intel.com>
<20190402035458.14664-9-anand.rawat@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for
eal on windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190402200606.wFFp6WsmFxHjTc4X0SbbYMH-UPzn897XHiWXNb0HcvY@z>
02/04/2019 05:54, Anand Rawat:
> Add windows specific logic for eal.c, eal_lcore.c,
> eal_debug.c and eal_thread.c. Updated header files to
> contain suitable function declaractions.
>
> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
[...]
> + /*
> + * create communication pipes between master thread
> + * and children
> + */
> + if (_pipe(lcore_config[i].pipe_master2slave,
> + sizeof(char), _O_BINARY) < 0)
> + rte_panic("Cannot create pipe\n");
rte_panic should be used only in applications, not in libraries.
The application can do something in case of DPDK failure.
Please remove all calls to rte_panic() during next weeks, thanks.