From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DE64EA0679 for ; Tue, 2 Apr 2019 23:39:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96F0F1B14C; Tue, 2 Apr 2019 23:39:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 66D301B11A for ; Tue, 2 Apr 2019 23:39:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A66A721B28; Tue, 2 Apr 2019 17:38:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 17:38:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=pacColbaGOQQKaIqqfqyzB2IliZNrHB88KkzPbXKK+Q=; b=JzE78yFIN4Wv ncC5/Lkv9W6c6vEMCXIUAW1ZLPtnLZKnyXzEu5Qwr+RaGPZi+jZIscrhmNGuPnHd sfugS6ixsII/ESQy/vzGPFrKg7cizvneGn9KXFD4a5sFjEX21Yjf1eoXzOXFosZN GvlM3fNbvJpCqx8xlkQYb/nh0mA7JpM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pacColbaGOQQKaIqqfqyzB2IliZNrHB88KkzPbXKK +Q=; b=eSa45B9eem6bXgwg+uvneBzHk8KyM+xZQbz2V+DZPjpNlrEXj0DWNk8MV vxnWVoKZiq8Umxk2z6AWnYOW66BknPqtdS1xOoBv8iisFqXaCo1m/o4NSvhRAdHW xflGPzkIrzq/hJW3ZaYsTV5ruf247ryEuHAONUcAQT627K3z0rVyaFsdrHZFpino e8GpatytdaIaUZTUpUqHsZQNaJyIFKd1Da3O80sWYYZbKyun1LrgXFrHjdxiRiDz xH0AnuvOEeJfswbtV/ELfgIwpD5ZIwiohqkHqfnxHkh02VE/S9CYD4XQQA9gyNMf dmBFtLJmwkssHQSn/SzXp1I4xPTSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgddugeefucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D931FE4805; Tue, 2 Apr 2019 17:38:57 -0400 (EDT) From: Thomas Monjalon To: Pallavi Kadam Cc: Anand Rawat , dev@dpdk.org, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 02 Apr 2019 23:38:56 +0200 Message-ID: <1828556.vUbNugSFqY@xps> In-Reply-To: <3ac129fb-709d-833a-234a-286793e2a322@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <3868443.jK6Cv4ngdr@xps> <3ac129fb-709d-833a-234a-286793e2a322@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402213856.v2ODoKqYuVHne4uyAq1sPKSeVr0s17geZ-WTwxDXKFs@z> 02/04/2019 23:21, Pallavi Kadam: > > On 4/2/2019 1:06 PM, Thomas Monjalon wrote: > > 02/04/2019 05:54, Anand Rawat: > >> Add windows specific logic for eal.c, eal_lcore.c, > >> eal_debug.c and eal_thread.c. Updated header files to > >> contain suitable function declaractions. > >> > >> Signed-off-by: Anand Rawat > >> Signed-off-by: Pallavi Kadam > >> Reviewed-by: Jeff Shaw > >> Reviewed-by: Ranjit Menon > >> --- > > [...] > >> + /* > >> + * create communication pipes between master thread > >> + * and children > >> + */ > >> + if (_pipe(lcore_config[i].pipe_master2slave, > >> + sizeof(char), _O_BINARY) < 0) > >> + rte_panic("Cannot create pipe\n"); > > rte_panic should be used only in applications, not in libraries. > > The application can do something in case of DPDK failure. > > Please remove all calls to rte_panic() during next weeks, thanks. > > Ok, will try to incorporate in v9. Just curious, is this the major issue? > > Calls to rte_panic() can be seen in linux/eal and freebsd/eal. No, there is a misunderstanding. I am merging v8 and I am asking for a new patch to remove these calls. By the way, I am fixing patch 3, please check my comment on this patch.