From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 67767A0679 for ; Wed, 3 Apr 2019 01:37:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F2E71B111; Wed, 3 Apr 2019 01:37:49 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 3247B1B108 for ; Wed, 3 Apr 2019 01:37:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A17C921FFC; Tue, 2 Apr 2019 19:37:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 19:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=h/sVFTyJiYWWaI0SmS+9aMjRSB32AxfTAsjXSbNSiwc=; b=Qh8FjVwtAyZN 5XuDzQfTP/celeJImhlh/GkALxdWwMwTeLR16GnfjsmgqoiGUtUyqtVGdXaq7xTt xjhpQGQWz765DRbPaHzlquFJoht81Qt0VvWX9qSNKCtlc5JfWJ7HtuC5LjlUPVfP gTV6ljKpoglMn68d8jc5A5s1+NucNbg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=h/sVFTyJiYWWaI0SmS+9aMjRSB32AxfTAsjXSbNSi wc=; b=0/2wQ0YEhpDz7M4/4iLDlGyeK6gEepK7h7bwUJIXpzLtiqHMp9xGyt/U7 EUCaiLGIUGdpLB+JcErKuDrWBxxk0qjrbLO6O54fQ25yi2Tp4lhV1/h3px/V1rlz OVi1vly2JvU2Ctsr7eXeob0RJjKbpJz1VmIaIYthWc2MHL3vU2BHDxqcGY2n1KrM aeycSx259dQJaDyOj5CMF+K+4oGsdFmnHxO0LcxZjCOVLD2GpdqW4FHmhwccDhHA BZJrew7yS5K+cLa8K39HTVRXbydCencX1XUbPgkhXUmQbLxrKDhuIMjO53GRoCdm BDt2N2hpoCOFsI/J2P74zpSa6n/fg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddvfeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucffohhmrghinheptghhvggtkhdqvgigphgvrhhimhgvnhhtrghl qdhshihmshdrshhhnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpe hmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 205131031A; Tue, 2 Apr 2019 19:37:46 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: David Marchand , dev , Andrew Rybchenko Date: Wed, 03 Apr 2019 01:37:44 +0200 Message-ID: <4060275.r8SWH6iRtW@xps> In-Reply-To: <387091f6-9a9a-6645-9cbd-89dc306ff202@intel.com> References: <20181130002716.27325-1-thomas@monjalon.net> <1668070.OiOMRC6GPs@xps> <387091f6-9a9a-6645-9cbd-89dc306ff202@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402233744.ilUaU2euP21Pb-5m9My1Ryjio_TZ96MEaZZzVKpYvbE@z> 03/04/2019 01:35, Ferruh Yigit: > On 4/1/2019 9:09 AM, Thomas Monjalon wrote: > > 01/04/2019 08:46, David Marchand: > >> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > >> > >>> 19/03/2019 19:04, Ferruh Yigit: > >>>> On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>>>>>> +uint16_t __rte_experimental > >>>>>> > >>>>>> Do we need _rte_experimental on function definitions? I guess only in > >>> .h file, > >>>>>> function declaration is enough. > >>>>> > >>>>> Yes we need them both in .h and .c files. > >>>> > >>>> Why we need them in .c file? > >>>> I think the compiler is interested in ones in .h file, because of the > >>>> experimental checks. > >>> > >>> We need the tag in .c file because a check is done in the ELF object > >>> by buildtools/check-experimental-syms.sh > >>> > >> > >> ? > >> The attribute should be inherited from the declaration in the header. > >> If you have a case where it does not work, I'd like to look at it. > > > > I don't know such case, it was just a belief. > > Putting the __rte_experimental tag into header files should be sufficient. > > - buildtools/check-experimental-syms.sh > checks if symbols in .map file are marked with __rte_experimental, both putting > the tag to the symbol in .c file or .h file is working. > > - tag should be in header file so that application using it can get the warning. > > Briefly, __rte_experimental needs to be in .h file, it is optional to have it in > .c, I am for keeping it only in .h file function declaration. I agree As I said below, we can remove all experimental tags from .c files in a separate patch. > > If we can confirm it works well with tag in headers only, > > I suggest we remove all of them at once. > > For this patch, I prefer being on the safe side for now.