From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Byrne, Stephen1" <stephen1.byrne@intel.com>,
"Tamboli, Amit S" <amit.tamboli@intel.com>,
"Padubidri, Sanjay A" <sanjay.padubidri@intel.com>,
"Patel, Amol" <amol.patel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture
Date: Wed, 3 Apr 2019 03:53:24 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3294C8@BGSMSX101.gar.corp.intel.com> (raw)
Message-ID: <20190403035324.xkG_icAuY705N6t8EZ808dRys7T9yiA7tVnxwSYI2Nc@z> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4341B4@irsmsx110.ger.corp.intel.com>
Hi Reshma,
snipped
> > +
> > + printf(" core (%u); port %u device (%s) queue %u\n",
> > + rte_lcore_id(), pt->port, pt->device_id, pt->queue);
>
> Log message can be improved to be " packet_dump for port <num> running on
> core <id>"
Thanks for the suggestion, but I am comfortable with this message.
>
> > + fflush(stdout);
>
> Why is fflush used here and in below other places?
To ensure the stdout content is flushed out. We had used similar approach to ' examples/l2fwd/main.c'
>
> >
> > +The ``--multi`` command line option is optional argument. If passed,
> > +capture will be running on unqiue cores for all ``--pdump`` options.
> > +If
>
> Typo unique
>
> Thanks,
> Reshma
next prev parent reply other threads:[~2019-04-03 3:53 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 6:00 [dpdk-dev] [PATCH] " Vipin Varghese
2019-03-28 6:00 ` Vipin Varghese
2019-03-28 14:57 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2019-03-28 14:57 ` Vipin Varghese
2019-03-28 15:04 ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2019-03-28 15:04 ` Vipin Varghese
2019-03-28 15:34 ` Wiles, Keith
2019-03-28 15:34 ` Wiles, Keith
2019-03-29 10:08 ` Pattan, Reshma
2019-03-29 10:08 ` Pattan, Reshma
2019-03-29 10:22 ` Varghese, Vipin
2019-03-29 10:22 ` Varghese, Vipin
2019-03-29 10:52 ` Pattan, Reshma
2019-03-29 10:52 ` Pattan, Reshma
2019-03-29 17:03 ` Ferruh Yigit
2019-03-29 17:03 ` Ferruh Yigit
2019-04-01 4:05 ` Varghese, Vipin
2019-04-01 4:05 ` Varghese, Vipin
2019-04-02 4:33 ` [dpdk-dev] [PATCH v4 0/2] app/pdump: enhance to support unique cores Vipin Varghese
2019-04-02 4:33 ` Vipin Varghese
2019-04-02 4:33 ` [dpdk-dev] [PATCH v4 1/2] app/pdump: remove core restriction Vipin Varghese
2019-04-02 4:33 ` Vipin Varghese
2019-04-02 4:33 ` [dpdk-dev] [PATCH v4 2/2] app/pdump: enhance to support multi-core capture Vipin Varghese
2019-04-02 4:33 ` Vipin Varghese
2019-04-02 7:05 ` David Marchand
2019-04-02 7:05 ` David Marchand
2019-04-02 8:06 ` Varghese, Vipin
2019-04-02 8:06 ` Varghese, Vipin
2019-04-02 9:18 ` [dpdk-dev] [PATCH v5 0/2] app/pdump: enhance to support unique cores Vipin Varghese
2019-04-02 9:18 ` Vipin Varghese
2019-04-02 9:18 ` [dpdk-dev] [PATCH v5 1/2] app/pdump: remove core restriction Vipin Varghese
2019-04-02 9:18 ` Vipin Varghese
2019-04-02 9:18 ` [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture Vipin Varghese
2019-04-02 9:18 ` Vipin Varghese
2019-04-02 10:01 ` David Marchand
2019-04-02 10:01 ` David Marchand
2019-04-02 15:30 ` Varghese, Vipin
2019-04-02 15:30 ` Varghese, Vipin
2019-04-04 7:39 ` David Marchand
2019-04-04 7:39 ` David Marchand
2019-04-02 16:13 ` Pattan, Reshma
2019-04-02 16:13 ` Pattan, Reshma
2019-04-03 3:53 ` Varghese, Vipin [this message]
2019-04-03 3:53 ` Varghese, Vipin
2019-04-05 17:10 ` Pattan, Reshma
2019-04-05 17:10 ` Pattan, Reshma
2019-04-08 3:03 ` Varghese, Vipin
2019-04-08 3:03 ` Varghese, Vipin
2019-04-04 8:55 ` [dpdk-dev] [PATCH v6 0/2] app/pdump: enhance to support unique cores Vipin Varghese
2019-04-04 8:55 ` Vipin Varghese
2019-04-04 8:55 ` [dpdk-dev] [PATCH v6 1/2] app/pdump: remove core restriction Vipin Varghese
2019-04-04 8:55 ` Vipin Varghese
2019-04-09 9:04 ` Pattan, Reshma
2019-04-09 9:04 ` Pattan, Reshma
2019-04-04 8:55 ` [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture Vipin Varghese
2019-04-04 8:55 ` Vipin Varghese
2019-04-05 17:09 ` Pattan, Reshma
2019-04-05 17:09 ` Pattan, Reshma
2019-04-08 3:01 ` Varghese, Vipin
2019-04-08 3:01 ` Varghese, Vipin
2019-04-09 9:05 ` Pattan, Reshma
2019-04-09 9:05 ` Pattan, Reshma
2019-04-22 19:49 ` [dpdk-dev] [PATCH v6 0/2] app/pdump: enhance to support unique cores Thomas Monjalon
2019-04-22 19:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3294C8@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=amit.tamboli@intel.com \
--cc=amol.patel@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=reshma.pattan@intel.com \
--cc=sanjay.padubidri@intel.com \
--cc=stephen1.byrne@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).