From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3186DA0679 for ; Wed, 3 Apr 2019 05:53:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6A555B3E; Wed, 3 Apr 2019 05:53:32 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 26DC85B12 for ; Wed, 3 Apr 2019 05:53:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 20:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,303,1549958400"; d="scan'208";a="157726645" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 02 Apr 2019 20:53:29 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 2 Apr 2019 20:53:29 -0700 Received: from BGSMSX108.gar.corp.intel.com (10.223.4.192) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 2 Apr 2019 20:53:28 -0700 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.171]) by BGSMSX108.gar.corp.intel.com ([169.254.8.24]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 09:23:25 +0530 From: "Varghese, Vipin" To: "Pattan, Reshma" , "dev@dpdk.org" , "Kovacevic, Marko" , "david.marchand@redhat.com" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" Thread-Topic: [PATCH v5 2/2] app/pdump: enhance to support multi-core capture Thread-Index: AQHU6TUdRxunck6MJ0aCmCq5Lg2fiaYor2gAgAENLYA= Date: Wed, 3 Apr 2019 03:53:24 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3294C8@BGSMSX101.gar.corp.intel.com> References: <20190402043318.20382-3-vipin.varghese@intel.com> <20190402091836.35779-1-vipin.varghese@intel.com> <20190402091836.35779-3-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A4341B4@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4341B4@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVlYTc5ZmYtMTZjNi00MDA2LWExMDMtM2EzMzY2Y2IyNTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGNsaGgyXC9OR3c2V1dDWElzRFpyWGVkUG5oZ2wwZ0RlTHVoMVp0cXI4RHF4SVFETW50NVZFXC9sc3ByUytnSlNCIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403035324.xkG_icAuY705N6t8EZ808dRys7T9yiA7tVnxwSYI2Nc@z> Hi Reshma, snipped > > + > > + printf(" core (%u); port %u device (%s) queue %u\n", > > + rte_lcore_id(), pt->port, pt->device_id, pt->queue); >=20 > Log message can be improved to be " packet_dump for port running o= n > core " Thanks for the suggestion, but I am comfortable with this message. >=20 > > + fflush(stdout); >=20 > Why is fflush used here and in below other places? To ensure the stdout content is flushed out. We had used similar approach t= o ' examples/l2fwd/main.c' >=20 > > > > +The ``--multi`` command line option is optional argument. If passed, > > +capture will be running on unqiue cores for all ``--pdump`` options. > > +If >=20 > Typo unique >=20 > Thanks, > Reshma