DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
	 Anand Rawat <anand.rawat@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory
Date: Wed, 3 Apr 2019 10:41:47 +0200	[thread overview]
Message-ID: <CAJFAV8zLP=Tyy+j91BQ0e7Qjov4c=FuCO9HiNRVx=Jcu-LvOFQ@mail.gmail.com> (raw)
Message-ID: <20190403084147.frpHW-O9Y9RwRlsszD14LGIPVt1bHmIvpMTOb7LRvEg@z> (raw)
In-Reply-To: <5780010.E6WaIR6Pig@xps>

On Tue, Apr 2, 2019 at 9:51 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 02/04/2019 21:46, David Marchand:
> > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > > Only one header file (rte_kni_common.h) was in the sub-directory
> > >         include/exec-env/
> > > This file was installed in a sub-directory of the same name
> > > in the makefile-based build.
> > > Source and install directories are moved as below:
> > >
> > >    lib/librte_eal/linux/eal/include/exec-env/
> > > -> lib/librte_eal/linux/eal/include/
> > >
> > >    build/include/exec-env/
> > > -> build/include/
> > >
> > > The consequence is to have a file hierarchy a bit more flat.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> >
> > Looks good to me.
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> > Tested-by: David Marchand <david.marchand@redhat.com>
>
> Applied
>


As a followup, I noticed this:

[dmarchan@dmarchan dpdk]$ for file in $(find lib/librte_eal/*/eal -name
*.h); do echo $(basename $file); git grep -l $(basename $file); echo; done
eal_alarm_private.h
lib/librte_eal/freebsd/eal/eal_alarm.c
lib/librte_eal/freebsd/eal/eal_interrupts.c

eal_vfio.h
lib/librte_eal/linux/eal/eal.c
lib/librte_eal/linux/eal/eal_interrupts.c
lib/librte_eal/linux/eal/eal_vfio.c
lib/librte_eal/linux/eal/eal_vfio_mp_sync.c

rte_kni_common.h
kernel/linux/kni/kni_dev.h
kernel/linux/kni/kni_fifo.h
kernel/linux/kni/kni_misc.c
kernel/linux/kni/kni_net.c
lib/librte_eal/linux/eal/Makefile
lib/librte_kni/rte_kni.c
lib/librte_kni/rte_kni.h

At the moment, kni is the only special case where users need to set a
CFLAGS -I...eal/include for.
But we have some drivers directly referencing linux/eal, linux/eal/include
and a funny $(SYSTEM)app/eal:

[dmarchan@dmarchan dpdk]$ git grep CFLAGS.*/eal
drivers/bus/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/bus/pci/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal
drivers/bus/vmbus/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal
drivers/crypto/caam_jr/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/crypto/dpaa2_sec/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/crypto/dpaa_sec/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/event/dpaa/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal/include
drivers/event/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/mempool/dpaa2/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/net/dpaa/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal/include
drivers/net/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal
drivers/raw/dpaa2_qdma/Makefile:CFLAGS +=
-I$(RTE_SDK)/lib/librte_eal/linux/eal

Preparing a patch.

-- 
David Marchand

  parent reply	other threads:[~2019-04-03  8:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 23:07 [dpdk-dev] [PATCH] " Thomas Monjalon
2019-04-01 23:07 ` Thomas Monjalon
2019-04-02  9:39 ` Bruce Richardson
2019-04-02  9:39   ` Bruce Richardson
2019-04-02 14:43   ` Ferruh Yigit
2019-04-02 14:43     ` Ferruh Yigit
2019-04-02  9:57 ` David Marchand
2019-04-02  9:57   ` David Marchand
2019-04-02 10:03   ` Thomas Monjalon
2019-04-02 10:03     ` Thomas Monjalon
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-04-02 15:13   ` Thomas Monjalon
2019-04-02 19:30 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2019-04-02 19:30   ` Thomas Monjalon
2019-04-02 19:46   ` David Marchand
2019-04-02 19:46     ` David Marchand
2019-04-02 19:50     ` Thomas Monjalon
2019-04-02 19:50       ` Thomas Monjalon
2019-04-03  8:41       ` David Marchand [this message]
2019-04-03  8:41         ` David Marchand
2019-04-02 19:52     ` Ferruh Yigit
2019-04-02 19:52       ` Ferruh Yigit
2019-04-02 19:55       ` David Marchand
2019-04-02 19:55         ` David Marchand
2019-04-02 19:57         ` Ferruh Yigit
2019-04-02 19:57           ` Ferruh Yigit
2019-04-02 20:04           ` David Marchand
2019-04-02 20:04             ` David Marchand
2019-04-02 20:09             ` Thomas Monjalon
2019-04-02 20:09               ` Thomas Monjalon
2019-04-03 13:34       ` Bruce Richardson
2019-04-03 13:34         ` Bruce Richardson
2019-04-02 19:50   ` Ferruh Yigit
2019-04-02 19:50     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zLP=Tyy+j91BQ0e7Qjov4c=FuCO9HiNRVx=Jcu-LvOFQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=anand.rawat@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).