DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Hajkowski, MarcinX" <marcinx.hajkowski@intel.com>,
	"Hunt, David" <david.hunt@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Hajkowski, MarcinX" <marcinx.hajkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds
Date: Wed, 3 Apr 2019 09:25:10 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A43462C@irsmsx110.ger.corp.intel.com> (raw)
Message-ID: <20190403092510.JPTxjJHIrE0BCAPjyKkd5psjq-QLXnxl4SotLK2YYn0@z> (raw)
In-Reply-To: <20190402082121.5472-4-marcinx.hajkowski@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski
> +		RTE_LOG(DEBUG, GUEST_CLI, "Not expected command has
> been received.\n");

Instead of : "Not expected command has been received ".  How about, Received invalid response from host, expecting NACK/ACK?
But let's hear from others.

> +	int result;
> +	ret = check_response_cmd(res->lcore_id, &result);
> +	if (ret < 0) {
> +		RTE_LOG(DEBUG, GUEST_CLI, "No confirmation for sent msg
> received\n");
> +	} else {
> +		cmdline_printf(cl, "Ack for sent msg received with result:
> %s.\n",
> +				result == 1 ? "SUCCESS" : "ERROR");
> +	}
>  }

In else statement how about just checking for result ACK/NACK and have log saying
received ACK /received NACK for msg

Thanks,
Reshma
 

  parent reply	other threads:[~2019-04-03  9:25 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 10:55 [dpdk-dev] [PATCH v3 0/4] bidirect guest channel Hajkowski
2019-03-21 10:55 ` Hajkowski
2019-03-21 10:55 ` [dpdk-dev] [PATCH v3 1/4] power: fix invalid socket indicator value Hajkowski
2019-03-21 10:55   ` Hajkowski
2019-03-22 10:56   ` Maxime Coquelin
2019-03-22 10:56     ` Maxime Coquelin
2019-03-27 14:03   ` Burakov, Anatoly
2019-03-27 14:03     ` Burakov, Anatoly
2019-03-21 10:55 ` [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading Hajkowski
2019-03-21 10:55   ` Hajkowski
2019-03-22 11:00   ` Maxime Coquelin
2019-03-22 11:00     ` Maxime Coquelin
2019-03-22 11:53     ` Ananyev, Konstantin
2019-03-22 11:53       ` Ananyev, Konstantin
2019-03-27 14:23   ` Burakov, Anatoly
2019-03-27 14:23     ` Burakov, Anatoly
2019-03-21 10:55 ` [dpdk-dev] [PATCH v3 3/4] power: process incoming confirmation cmds Hajkowski
2019-03-21 10:55   ` Hajkowski
2019-03-27 14:51   ` Burakov, Anatoly
2019-03-27 14:51     ` Burakov, Anatoly
2019-04-01 14:25   ` Pattan, Reshma
2019-04-01 14:25     ` Pattan, Reshma
2019-03-21 10:55 ` [dpdk-dev] [PATCH v3 4/4] power: send confirmation cmd to vm guest Hajkowski
2019-03-21 10:55   ` Hajkowski
2019-03-27 14:58   ` Burakov, Anatoly
2019-03-27 14:58     ` Burakov, Anatoly
2019-03-29 14:16 ` [dpdk-dev] [PATCH v3 0/4] bidirect guest channel Thomas Monjalon
2019-03-29 14:16   ` Thomas Monjalon
2019-04-02  8:21 ` [dpdk-dev] [PATCH v4 " Hajkowski
2019-04-02  8:21   ` Hajkowski
2019-04-02  8:21   ` [dpdk-dev] [PATCH v4 1/4] power: fix invalid socket indicator value Hajkowski
2019-04-02  8:21     ` Hajkowski
2019-04-02  8:21   ` [dpdk-dev] [PATCH v4 2/4] power: extend guest channel api for reading Hajkowski
2019-04-02  8:21     ` Hajkowski
2019-04-02  8:21   ` [dpdk-dev] [PATCH v4 3/4] power: process incoming confirmation cmds Hajkowski
2019-04-02  8:21     ` Hajkowski
2019-04-03  9:25     ` Pattan, Reshma [this message]
2019-04-03  9:25       ` Pattan, Reshma
2019-04-02  8:21   ` [dpdk-dev] [PATCH v4 4/4] power: send confirmation cmd to vm guest Hajkowski
2019-04-02  8:21     ` Hajkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A43462C@irsmsx110.ger.corp.intel.com \
    --to=reshma.pattan@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=marcinx.hajkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).