From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 49F36A0679 for ; Wed, 3 Apr 2019 12:31:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F0791B12D; Wed, 3 Apr 2019 12:31:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 63CC91B129; Wed, 3 Apr 2019 12:31:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 03:31:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="147662289" Received: from klaatz-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by orsmga002.jf.intel.com with ESMTP; 03 Apr 2019 03:31:12 -0700 To: Andrius Sirvys , dev@dpdk.org Cc: stable@dpdk.org, ciara.power@intel.com References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> From: "Laatz, Kevin" Message-ID: <00d20004-b191-51b3-55e3-776ff734b45e@intel.com> Date: Wed, 3 Apr 2019 11:31:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403103109.WLV5Eo-LAfYQ2CMiaG_5dSqmgng_I_lJh_NB7Sg3OmE@z> On 20/03/2019 16:43, Andrius Sirvys wrote: > LGTM static code analysis tool reports that the function 'input' is > unsafe. Changed to use raw_input which then converts it using > ast.literal_eval() which is safe. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Cc: ciara.power@intel.com > > Signed-off-by: Andrius Sirvys > --- Looks good to me. Thanks! Acked-by: Kevin Laatz