DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] usertools: replace unsafe input function
@ 2019-03-20 16:43 Andrius Sirvys
  2019-03-20 16:43 ` Andrius Sirvys
                   ` (3 more replies)
  0 siblings, 4 replies; 20+ messages in thread
From: Andrius Sirvys @ 2019-03-20 16:43 UTC (permalink / raw)
  To: dev, Kevin Laatz; +Cc: stable, Andrius Sirvys, ciara.power

LGTM static code analysis tool reports that the function 'input' is
unsafe. Changed to use raw_input which then converts it using
ast.literal_eval() which is safe.

Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
Cc: ciara.power@intel.com

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
 usertools/dpdk-telemetry-client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index ce0c7a9..c3ba77d 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -72,7 +72,7 @@ def requestMetrics(self): # Requests metrics for given client
 
     def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
         print("\nPlease enter the number of times you'd like to continuously request Metrics:")
-        n_requests = int(input("\n:"))
+        n_requests = int(ast.literal_eval(raw_input("\n:")))
         print("\033[F") #Removes the user input from screen, cleans it up
         print("\033[K")
         for i in range(n_requests):
@@ -87,7 +87,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
             print("[3] Unregister client")
 
             try:
-                self.choice = int(input("\n:"))
+                self.choice = int(ast.literal_eval(raw_input("\n:")))
                 print("\033[F") #Removes the user input for screen, cleans it up
                 print("\033[K")
                 if self.choice == 1:
-- 
2.7.4

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2019-04-09  9:10 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 16:43 [dpdk-dev] [PATCH] usertools: replace unsafe input function Andrius Sirvys
2019-03-20 16:43 ` Andrius Sirvys
2019-04-03 10:31 ` Laatz, Kevin
2019-04-03 10:31   ` Laatz, Kevin
2019-04-03 10:44 ` Burakov, Anatoly
2019-04-03 10:44   ` Burakov, Anatoly
2019-04-03 13:30   ` Bruce Richardson
2019-04-03 13:30     ` Bruce Richardson
2019-04-03 14:29     ` Burakov, Anatoly
2019-04-03 14:29       ` Burakov, Anatoly
2019-04-03 14:48       ` Burakov, Anatoly
2019-04-03 14:48         ` Burakov, Anatoly
2019-04-03 14:58         ` Burakov, Anatoly
2019-04-03 14:58           ` Burakov, Anatoly
2019-04-03 15:10           ` Richardson, Bruce
2019-04-03 15:10             ` Richardson, Bruce
2019-04-08 13:40 ` [dpdk-dev] [PATCH v2] " Andrius Sirvys
2019-04-08 13:40   ` Andrius Sirvys
2019-04-09  9:10   ` Burakov, Anatoly
2019-04-09  9:10     ` Burakov, Anatoly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).