From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Anand Rawat <anand.rawat@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory
Date: Wed, 3 Apr 2019 14:34:39 +0100 [thread overview]
Message-ID: <20190403133439.GC1309@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com>
On Tue, Apr 02, 2019 at 08:52:12PM +0100, Ferruh Yigit wrote:
> On 4/2/2019 8:46 PM, David Marchand wrote:
> > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> >> Only one header file (rte_kni_common.h) was in the sub-directory
> >> include/exec-env/
> >> This file was installed in a sub-directory of the same name
> >> in the makefile-based build.
> >> Source and install directories are moved as below:
> >>
> >> lib/librte_eal/linux/eal/include/exec-env/
> >> -> lib/librte_eal/linux/eal/include/
> >>
> >> build/include/exec-env/
> >> -> build/include/
> >>
> >> The consequence is to have a file hierarchy a bit more flat.
> >>
> >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >
> > Looks good to me.
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> > Tested-by: David Marchand <david.marchand@redhat.com>
> >
> >
> > Bruce, while testing with meson, I noticed this:
> > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument
> > "console".
> > WARNING: This will become a hard error in the future.
> > WARNING: Unknown keyword arguments in target rte_kni: console
>
> I am not seeing this...
It's ok. The keyword is new in newer versions which obviously won't give an
error on it being invalid then. Older versions just ignore it, other than
printing the warning you see.
In short, harmless, ignore! :-)
/Bruce
next prev parent reply other threads:[~2019-04-03 13:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 23:07 [dpdk-dev] [PATCH] " Thomas Monjalon
2019-04-01 23:07 ` Thomas Monjalon
2019-04-02 9:39 ` Bruce Richardson
2019-04-02 9:39 ` Bruce Richardson
2019-04-02 14:43 ` Ferruh Yigit
2019-04-02 14:43 ` Ferruh Yigit
2019-04-02 9:57 ` David Marchand
2019-04-02 9:57 ` David Marchand
2019-04-02 10:03 ` Thomas Monjalon
2019-04-02 10:03 ` Thomas Monjalon
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-04-02 15:13 ` Thomas Monjalon
2019-04-02 19:30 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2019-04-02 19:30 ` Thomas Monjalon
2019-04-02 19:46 ` David Marchand
2019-04-02 19:46 ` David Marchand
2019-04-02 19:50 ` Thomas Monjalon
2019-04-02 19:50 ` Thomas Monjalon
2019-04-03 8:41 ` David Marchand
2019-04-03 8:41 ` David Marchand
2019-04-02 19:52 ` Ferruh Yigit
2019-04-02 19:52 ` Ferruh Yigit
2019-04-02 19:55 ` David Marchand
2019-04-02 19:55 ` David Marchand
2019-04-02 19:57 ` Ferruh Yigit
2019-04-02 19:57 ` Ferruh Yigit
2019-04-02 20:04 ` David Marchand
2019-04-02 20:04 ` David Marchand
2019-04-02 20:09 ` Thomas Monjalon
2019-04-02 20:09 ` Thomas Monjalon
2019-04-03 13:34 ` Bruce Richardson [this message]
2019-04-03 13:34 ` Bruce Richardson
2019-04-02 19:50 ` Ferruh Yigit
2019-04-02 19:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403133439.GC1309@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anand.rawat@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).