From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] net/bonding: fix buffer length when printing strings
Date: Wed, 3 Apr 2019 16:51:17 +0100 [thread overview]
Message-ID: <20190403155117.GA1332@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190403084758.2b7bed7f@shemminger-XPS-13-9360>
On Wed, Apr 03, 2019 at 08:47:58AM -0700, Stephen Hemminger wrote:
> On Wed, 3 Apr 2019 15:45:01 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> >
> > static void
> > -arp_op_name(uint16_t arp_op, char *buf)
> > +arp_op_name(uint16_t arp_op, char *buf, size_t buf_len)
> > {
> > switch (arp_op) {
> > case ARP_OP_REQUEST:
> > - snprintf(buf, sizeof("ARP Request"), "%s", "ARP Request");
> > + snprintf(buf, buf_len, "%s", "ARP Request");
> > return;
> This should be strlcpy not snprintf
Yes, it should, but I just let that get fixed by cocci script in the later
patch. For this one, I just fixed the most egregious error.
next prev parent reply other threads:[~2019-04-03 15:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:45 [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 14:45 ` [dpdk-dev] [PATCH 1/5] net/bonding: fix buffer length when printing strings Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 15:47 ` Stephen Hemminger
2019-04-03 15:47 ` Stephen Hemminger
2019-04-03 15:51 ` Bruce Richardson [this message]
2019-04-03 15:51 ` Bruce Richardson
2019-04-03 15:53 ` Stephen Hemminger
2019-04-03 15:53 ` Stephen Hemminger
2019-04-03 14:45 ` [dpdk-dev] [PATCH 2/5] devtools/cocci: make strlcpy replacement smarter Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 14:45 ` [dpdk-dev] [PATCH 3/5] devtools/cocci: create safer version of strlcpy script Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 14:45 ` [dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 15:51 ` Stephen Hemminger
2019-04-03 15:51 ` Stephen Hemminger
2019-04-03 15:56 ` Bruce Richardson
2019-04-03 15:56 ` Bruce Richardson
2019-04-04 18:05 ` Thomas Monjalon
2019-04-04 18:05 ` Thomas Monjalon
2019-04-03 14:45 ` [dpdk-dev] [PATCH 5/5] replace snprintf with strlcpy Bruce Richardson
2019-04-03 14:45 ` Bruce Richardson
2019-04-03 14:57 ` [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying Wiles, Keith
2019-04-03 14:57 ` Wiles, Keith
2019-04-03 15:13 ` Bruce Richardson
2019-04-03 15:13 ` Bruce Richardson
2019-04-03 15:27 ` Stephen Hemminger
2019-04-03 15:27 ` Stephen Hemminger
2019-04-04 20:11 ` Thomas Monjalon
2019-04-04 20:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403155117.GA1332@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).