This patch stopped lldp by default to avoid the statistics error. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: stable@dpdk.org Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1482ced..b3df282 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -11,6 +11,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_stop_lldp(hw, TRUE, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
This patch stopped lldp by default to avoid the statistics error. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: stable@dpdk.org Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1482ced..b3df282 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -11,6 +11,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_stop_lldp(hw, TRUE, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, April 3, 2019 11:59 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default > > This patch stopped lldp by default to avoid the statistics error. > > Fixes: f9cf4f864150 ("net/ice: support device initialization") > Cc: stable@dpdk.org > > Signed-off-by: Qiming Yang <qiming.yang@intel.com> > --- > drivers/net/ice/ice_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index > 1482ced..b3df282 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -11,6 +11,7 @@ > > #include "base/ice_sched.h" > #include "base/ice_flow.h" > +#include "base/ice_dcb.h" > #include "ice_ethdev.h" > #include "ice_rxtx.h" > > @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Disable double vlan by default */ > ice_vsi_config_double_vlan(vsi, FALSE); > > + ret = ice_aq_stop_lldp(hw, TRUE, NULL); > + if (ret != ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); I think we need to warning user here if LLDP can't be stopped. > + > /* register callback func to eal lib */ > rte_intr_callback_register(intr_handle, > ice_interrupt_handler, dev); > -- > 2.9.5
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, April 3, 2019 11:59 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default > > This patch stopped lldp by default to avoid the statistics error. > > Fixes: f9cf4f864150 ("net/ice: support device initialization") > Cc: stable@dpdk.org > > Signed-off-by: Qiming Yang <qiming.yang@intel.com> > --- > drivers/net/ice/ice_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index > 1482ced..b3df282 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -11,6 +11,7 @@ > > #include "base/ice_sched.h" > #include "base/ice_flow.h" > +#include "base/ice_dcb.h" > #include "ice_ethdev.h" > #include "ice_rxtx.h" > > @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Disable double vlan by default */ > ice_vsi_config_double_vlan(vsi, FALSE); > > + ret = ice_aq_stop_lldp(hw, TRUE, NULL); > + if (ret != ICE_SUCCESS) > + PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); I think we need to warning user here if LLDP can't be stopped. > + > /* register callback func to eal lib */ > rte_intr_callback_register(intr_handle, > ice_interrupt_handler, dev); > -- > 2.9.5
This patch stopped lldp by default to avoid the statistics error. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1482ced..a4191e9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -11,6 +11,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_start_lldp(hw, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(WARNING, "Failed to stop lldp"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
This patch stopped lldp by default to avoid the statistics error. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 1482ced..a4191e9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -11,6 +11,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_start_lldp(hw, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(WARNING, "Failed to stop lldp"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
This patch stopped lldp by default to avoid the statistics error. Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9d01018..b106ee9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -12,6 +12,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1428,6 +1429,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_stop_lldp(hw, TRUE, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(DEBUG, "lldp has already stopped\n"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
This patch stopped lldp by default to avoid the statistics error. Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/ice/ice_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9d01018..b106ee9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -12,6 +12,7 @@ #include "base/ice_sched.h" #include "base/ice_flow.h" +#include "base/ice_dcb.h" #include "ice_ethdev.h" #include "ice_rxtx.h" @@ -1428,6 +1429,10 @@ ice_dev_init(struct rte_eth_dev *dev) /* Disable double vlan by default */ ice_vsi_config_double_vlan(vsi, FALSE); + ret = ice_aq_stop_lldp(hw, TRUE, NULL); + if (ret != ICE_SUCCESS) + PMD_INIT_LOG(DEBUG, "lldp has already stopped\n"); + /* register callback func to eal lib */ rte_intr_callback_register(intr_handle, ice_interrupt_handler, dev); -- 2.9.5
> -----Original Message-----
> From: Yang, Qiming
> Sent: Friday, April 12, 2019 6:10 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: [PATCH v3] net/ice: stop lldp by default
>
> This patch stopped lldp by default to avoid the statistics error.
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> -----Original Message-----
> From: Yang, Qiming
> Sent: Friday, April 12, 2019 6:10 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Subject: [PATCH v3] net/ice: stop lldp by default
>
> This patch stopped lldp by default to avoid the statistics error.
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi