From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE3DEA0679 for ; Thu, 4 Apr 2019 16:14:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CDD61B3FB; Thu, 4 Apr 2019 16:14:23 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E541D1B3D8 for ; Thu, 4 Apr 2019 16:14:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 07:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,308,1549958400"; d="scan'208";a="158207836" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 04 Apr 2019 07:14:19 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 4 Apr 2019 07:14:19 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by FMSMSX155.amr.corp.intel.com ([169.254.5.16]) with mapi id 14.03.0415.000; Thu, 4 Apr 2019 07:14:18 -0700 From: "Eads, Gage" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "gavin.hu@arm.com" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library Thread-Index: AQHU6uqQpgvUOLmN60G6/sb+euTpzqYsB5iw Date: Thu, 4 Apr 2019 14:14:18 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E54210E03@FMSMSX108.amr.corp.intel.com> References: <20190403205041.4651-1-gage.eads@intel.com> <20190403232020.12784-1-gage.eads@intel.com> <20190403232020.12784-2-gage.eads@intel.com> <1742818.CN8ABES3X5@xps> In-Reply-To: <1742818.CN8ABES3X5@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmQyZjU0ZmMtMDY1ZS00NmIyLTg2MDEtZmZjYjhmNTE4M2M3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicWhkZktVdzZ4NDlvSFwvdHRiNGxwTXFLZTg2bis0OFFDZ3hkbnVSUFdpWVdNMUFhUVBTZWNwbnBPNkhaYWFXZlAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404141418.emJ892oq7Td36i1yk8iJgX04aD-Bchb0g4homCy_5RI@z> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, April 4, 2019 8:30 AM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ; gavin.hu@arm.com; > Honnappa.Nagarahalli@arm.com; nd@arm.com > Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library >=20 > 04/04/2019 01:20, Gage Eads: > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) +=3D - > lrte_security > > _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) +=3D -lrte_compressdev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D -lrte_eventdev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=3D -lrte_rawdev > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) +=3D -lrte_stack > > _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) +=3D -lrte_timer > > _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=3D -lrte_mempool > > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) +=3D - > lrte_mempool_ring >=20 > Stack library is used by mempool, so it should appear after mempool in th= e > library list. > It is the same as ring lib being after mempool_ring. >=20 > If you agree, please just tell me without sending a new version, because = I'm > doing other minor changes (sorting stack near ring in many files). >=20 Agreed. I suspect we haven't seen any linker problems because it's in a --w= hole-archive section (line 72), but better to put these in the correct depe= ndency order.