* [dpdk-dev] [PATCH] eal/x86: fix pedantic build
@ 2019-04-04 13:00 Thomas Monjalon
2019-04-04 13:00 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
0 siblings, 2 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 13:00 UTC (permalink / raw)
To: gage.eads, Bruce Richardson, Konstantin Ananyev; +Cc: dev, Ferruh Yigit
When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
the compiler complains about non standard 128-bit integer type:
include/rte_atomic_64.h:223:3: error:
ISO C does not support ‘__int128’ types [-Werror=pedantic]
It must be marked as an extension of the standard C language
to be accepted in pedantic compilation.
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/common/include/arch/x86/rte_atomic_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
index 4b8315926..6232c57d9 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
@@ -220,7 +220,7 @@ typedef struct {
RTE_STD_C11
union {
uint64_t val[2];
- __int128 int128;
+ __extension__ __int128 int128;
};
} __rte_aligned(16) rte_int128_t;
--
2.21.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 13:00 [dpdk-dev] [PATCH] eal/x86: fix pedantic build Thomas Monjalon
@ 2019-04-04 13:00 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 13:00 UTC (permalink / raw)
To: gage.eads, Bruce Richardson, Konstantin Ananyev; +Cc: dev, Ferruh Yigit
When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
the compiler complains about non standard 128-bit integer type:
include/rte_atomic_64.h:223:3: error:
ISO C does not support ‘__int128’ types [-Werror=pedantic]
It must be marked as an extension of the standard C language
to be accepted in pedantic compilation.
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/common/include/arch/x86/rte_atomic_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
index 4b8315926..6232c57d9 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
@@ -220,7 +220,7 @@ typedef struct {
RTE_STD_C11
union {
uint64_t val[2];
- __int128 int128;
+ __extension__ __int128 int128;
};
} __rte_aligned(16) rte_int128_t;
--
2.21.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 13:00 [dpdk-dev] [PATCH] eal/x86: fix pedantic build Thomas Monjalon
2019-04-04 13:00 ` Thomas Monjalon
@ 2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 14:14 ` Eads, Gage
1 sibling, 2 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 13:22 UTC (permalink / raw)
To: dev
Cc: gage.eads, Bruce Richardson, Konstantin Ananyev, Ferruh Yigit,
david.marchand, alialnu
04/04/2019 15:00, Thomas Monjalon:
> When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> the compiler complains about non standard 128-bit integer type:
>
> include/rte_atomic_64.h:223:3: error:
> ISO C does not support ‘__int128’ types [-Werror=pedantic]
>
> It must be marked as an extension of the standard C language
> to be accepted in pedantic compilation.
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Forgot one line:
Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
Note: It seems only Ferruh can reproduce it.
I wonder whether the RTE_STD_C11 of the union is hiding the issue.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 13:22 ` Thomas Monjalon
@ 2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 14:14 ` Eads, Gage
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 13:22 UTC (permalink / raw)
To: dev
Cc: gage.eads, Bruce Richardson, Konstantin Ananyev, Ferruh Yigit,
david.marchand, alialnu
04/04/2019 15:00, Thomas Monjalon:
> When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> the compiler complains about non standard 128-bit integer type:
>
> include/rte_atomic_64.h:223:3: error:
> ISO C does not support ‘__int128’ types [-Werror=pedantic]
>
> It must be marked as an extension of the standard C language
> to be accepted in pedantic compilation.
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Forgot one line:
Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
Note: It seems only Ferruh can reproduce it.
I wonder whether the RTE_STD_C11 of the union is hiding the issue.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
@ 2019-04-04 14:14 ` Eads, Gage
2019-04-04 14:14 ` Eads, Gage
2019-04-04 15:13 ` Ferruh Yigit
1 sibling, 2 replies; 10+ messages in thread
From: Eads, Gage @ 2019-04-04 14:14 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Richardson, Bruce, Ananyev, Konstantin, Yigit, Ferruh,
david.marchand, alialnu
> 04/04/2019 15:00, Thomas Monjalon:
> > When enabling pedantic compilation with
> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> > the compiler complains about non standard 128-bit integer type:
> >
> > include/rte_atomic_64.h:223:3: error:
> > ISO C does not support ‘__int128’ types [-Werror=pedantic]
> >
> > It must be marked as an extension of the standard C language to be
> > accepted in pedantic compilation.
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Forgot one line:
>
> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
>
> Note: It seems only Ferruh can reproduce it.
> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
>
>
With that change:
Acked-by: Gage Eads <gage.eads@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 14:14 ` Eads, Gage
@ 2019-04-04 14:14 ` Eads, Gage
2019-04-04 15:13 ` Ferruh Yigit
1 sibling, 0 replies; 10+ messages in thread
From: Eads, Gage @ 2019-04-04 14:14 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Richardson, Bruce, Ananyev, Konstantin, Yigit, Ferruh,
david.marchand, alialnu
> 04/04/2019 15:00, Thomas Monjalon:
> > When enabling pedantic compilation with
> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> > the compiler complains about non standard 128-bit integer type:
> >
> > include/rte_atomic_64.h:223:3: error:
> > ISO C does not support ‘__int128’ types [-Werror=pedantic]
> >
> > It must be marked as an extension of the standard C language to be
> > accepted in pedantic compilation.
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Forgot one line:
>
> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
>
> Note: It seems only Ferruh can reproduce it.
> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
>
>
With that change:
Acked-by: Gage Eads <gage.eads@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 14:14 ` Eads, Gage
2019-04-04 14:14 ` Eads, Gage
@ 2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:23 ` Thomas Monjalon
1 sibling, 2 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-04-04 15:13 UTC (permalink / raw)
To: Eads, Gage, Thomas Monjalon, dev
Cc: Richardson, Bruce, Ananyev, Konstantin, david.marchand, alialnu
On 4/4/2019 3:14 PM, Eads, Gage wrote:
>
>> 04/04/2019 15:00, Thomas Monjalon:
>>> When enabling pedantic compilation with
>> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
>>> the compiler complains about non standard 128-bit integer type:
>>>
>>> include/rte_atomic_64.h:223:3: error:
>>> ISO C does not support ‘__int128’ types [-Werror=pedantic]
>>>
>>> It must be marked as an extension of the standard C language to be
>>> accepted in pedantic compilation.
>>>
>>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> Forgot one line:
>>
>> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
>>
>> Note: It seems only Ferruh can reproduce it.
>> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
>>
>>
>
> With that change:
> Acked-by: Gage Eads <gage.eads@intel.com>
>
I confirm it fixes the build issue:
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 15:13 ` Ferruh Yigit
@ 2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:23 ` Thomas Monjalon
1 sibling, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-04-04 15:13 UTC (permalink / raw)
To: Eads, Gage, Thomas Monjalon, dev
Cc: Richardson, Bruce, Ananyev, Konstantin, david.marchand, alialnu
On 4/4/2019 3:14 PM, Eads, Gage wrote:
>
>> 04/04/2019 15:00, Thomas Monjalon:
>>> When enabling pedantic compilation with
>> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
>>> the compiler complains about non standard 128-bit integer type:
>>>
>>> include/rte_atomic_64.h:223:3: error:
>>> ISO C does not support ‘__int128’ types [-Werror=pedantic]
>>>
>>> It must be marked as an extension of the standard C language to be
>>> accepted in pedantic compilation.
>>>
>>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> Forgot one line:
>>
>> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
>>
>> Note: It seems only Ferruh can reproduce it.
>> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
>>
>>
>
> With that change:
> Acked-by: Gage Eads <gage.eads@intel.com>
>
I confirm it fixes the build issue:
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:13 ` Ferruh Yigit
@ 2019-04-04 15:23 ` Thomas Monjalon
2019-04-04 15:23 ` Thomas Monjalon
1 sibling, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 15:23 UTC (permalink / raw)
To: Ferruh Yigit, Eads, Gage
Cc: dev, Richardson, Bruce, Ananyev, Konstantin, david.marchand, alialnu
04/04/2019 17:13, Ferruh Yigit:
> On 4/4/2019 3:14 PM, Eads, Gage wrote:
> >> 04/04/2019 15:00, Thomas Monjalon:
> >>> When enabling pedantic compilation with
> >> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> >>> the compiler complains about non standard 128-bit integer type:
> >>>
> >>> include/rte_atomic_64.h:223:3: error:
> >>> ISO C does not support ‘__int128’ types [-Werror=pedantic]
> >>>
> >>> It must be marked as an extension of the standard C language to be
> >>> accepted in pedantic compilation.
> >>>
> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >> Forgot one line:
> >>
> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
> >>
> >> Note: It seems only Ferruh can reproduce it.
> >> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> >
> > With that change:
> > Acked-by: Gage Eads <gage.eads@intel.com>
> >
>
> I confirm it fixes the build issue:
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
2019-04-04 15:23 ` Thomas Monjalon
@ 2019-04-04 15:23 ` Thomas Monjalon
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-04 15:23 UTC (permalink / raw)
To: Ferruh Yigit, Eads, Gage
Cc: dev, Richardson, Bruce, Ananyev, Konstantin, david.marchand, alialnu
04/04/2019 17:13, Ferruh Yigit:
> On 4/4/2019 3:14 PM, Eads, Gage wrote:
> >> 04/04/2019 15:00, Thomas Monjalon:
> >>> When enabling pedantic compilation with
> >> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> >>> the compiler complains about non standard 128-bit integer type:
> >>>
> >>> include/rte_atomic_64.h:223:3: error:
> >>> ISO C does not support ‘__int128’ types [-Werror=pedantic]
> >>>
> >>> It must be marked as an extension of the standard C language to be
> >>> accepted in pedantic compilation.
> >>>
> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >> Forgot one line:
> >>
> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
> >>
> >> Note: It seems only Ferruh can reproduce it.
> >> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> >
> > With that change:
> > Acked-by: Gage Eads <gage.eads@intel.com>
> >
>
> I confirm it fixes the build issue:
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-04 15:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 13:00 [dpdk-dev] [PATCH] eal/x86: fix pedantic build Thomas Monjalon
2019-04-04 13:00 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon
2019-04-04 14:14 ` Eads, Gage
2019-04-04 14:14 ` Eads, Gage
2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:13 ` Ferruh Yigit
2019-04-04 15:23 ` Thomas Monjalon
2019-04-04 15:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).