From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0069DA0679 for <public@inbox.dpdk.org>; Thu, 4 Apr 2019 18:13:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2C701B212; Thu, 4 Apr 2019 18:13:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BAD971B20D for <dev@dpdk.org>; Thu, 4 Apr 2019 18:13:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 09:13:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,308,1549958400"; d="scan'208";a="220582034" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga001.jf.intel.com with ESMTP; 04 Apr 2019 09:13:06 -0700 To: Xiaolong Ye <xiaolong.ye@intel.com>, dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>, Luca Boccassi <bluca@debian.org> Cc: Qi Zhang <qi.z.zhang@intel.com>, Karlsson Magnus <magnus.karlsson@intel.com>, Topel Bjorn <bjorn.topel@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Bruce Richardson <bruce.richardson@intel.com>, Ananyev Konstantin <konstantin.ananyev@intel.com>, David Marchand <david.marchand@redhat.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190404085113.16732-1-xiaolong.ye@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <6a63d9fa-0634-8184-252e-40e0ff5ce203@intel.com> Date: Thu, 4 Apr 2019 17:13:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190404085113.16732-1-xiaolong.ye@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 0/1] Introduce AF_XDP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190404161305.itRzr8S6PexYP9NVnyyiygwKYKYabUg18_WSZHCFl1o@z> On 4/4/2019 9:51 AM, Xiaolong Ye wrote: > Overview > ======== > > This patchset adds a new PMD driver for AF_XDP which is a proposed > faster version of AF_PACKET interface in Linux, see below links [1] [2] for > details of AF_XDP introduction: > > AF_XDP roadmap > ============== > - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support > in libbpf has been merged in v5.1-rc1. > - Now i40e and ixgbe drivers have supported zero copy mode. > > Change logs > =========== > v11: > > - fix the meson build issue > > v10: > > - refine the Makefile, remove RTE_KERNELDIR related CFLAGS > - add a new internal file af_xdp_deps.h to handle the dependency for > asm/barrier.h > - fix a typo observed by Stephen > - rename xsk.h to bpf/xsk.h as xsk.h is assumed to be installed in > /usr/local/include/bpf > - add libbpf build steps in af_xdp.rst > > > v9: > - adjust header files order according to Stephen's suggestion > > v8: > - address Ferruh's comments on V7 > - replace posix_memalign with rte_memzone_reserve_aligned to get better > performance > - keep the first patch only as Oliver suggested as zero copy part > implementation is still in suspense, we may provide the related patch > later. > > v7: > - mention mtu limitation in af_xdp.rst > - fix the vdev name in af_xdp.rst > > V6: > > - remove the newline in AF_XDP_LOG definition to avoid double new lines > issue. > - rename MEMPOOL_F_PAGE_ALIGN to MEMPOOL_CHUNK_F_PAGE_ALIGN. > > V5: > > - disable AF_XDP pmd by default due to it requires kernel more recent > than minimum kernel version supported by DPDK > - address other review comments of Maxime > > V4: > > - change vdev name to net_af_xdp > - adopt dynamic log type for all logging > - Fix other style issues raised by Stephen > > V3: > > - Fix all style issues pointed by Stephen, Mattias, David. > - Drop the testpmd change as we'll adopt Jerin's suggestion to add a new > mempool driver to handle the application use of AF_XDP's zero copy feature. > > V2: > - Fix a NULL pointer reference crash issue > - Fix txonly stop sending traffic in zc mode > - Refactor rte_mbuf.c to avoid ABI breakage. > - Fix multiple style issues pointed by Ferruh, David, Stephen, Luca. > > changes vs RFC sent by Qi last Aug: > > - Re-work base on AF_XDP's interface changes since the new libbpf has > provided higher-level APIs that hide many of the details of the AP_XDP > uapi. After the rework, it helps to reduce 300+ lines of code. > > - multi-queues is not supported due to current libbpf doesn't support > multi-sockets on a single umem. > > - No extra steps to load xdp program manually, since the current behavior of > libbpf would load a default xdp program when user calls xsk_socket__create. > userspace application only needs to handle the cleanup. > > How to try > ========== > > 1. take the kernel >= v5.1-rc1, build kernel and replace your host > kernel with it. > > make sure you turn on XDP sockets when compiling > > Networking support --> > Networking options --> > [ * ] XDP sockets > > 2. build & install libbpf in tools/lib/bpf > > cd tools/lib/bpf > make install_lib > make install_headers > > 3. ethtool -L enp59s0f0 combined 1 > > 4. extra step to build dpdk > > explicitly enable AF_XDP pmd by adding below line to > config/common_linux > > CONFIG_RTE_LIBRTE_PMD_AF_XDP=y > > 5. start testpmd > > ./build/app/testpmd -c 0xc -n 4 --vdev net_af_xdp,iface=enp59s0f0,queue=0 -- -i --rxq=1 --txq=1 > > in this case, default xdp program will be loaded and linked to queue 0 of enp59s0f0, > network traffics travel to queue 0 will be redirected to af_xdp socket. > > Xiaolong Ye (1): > net/af_xdp: introduce AF XDP PMD driver Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>