From: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>
Subject: [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix Tx QinQ set
Date: Fri, 5 Apr 2019 07:36:24 +0000 [thread overview]
Message-ID: <20190405073558.9930-2-ndabilpuram@marvell.com> (raw)
Message-ID: <20190405073624.GCdu3LeGYGg8FtW6JNpLSxMP24yaOCz33l-6NDucsMQ@z> (raw)
In-Reply-To: <20190405073558.9930-1-ndabilpuram@marvell.com>
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shahafs@mellanox.com
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
v3:
* Rename headline
v2:
* Split change into two seperate patches as suggested.
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 010e26d..f9cb129 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3006,7 +3006,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)
}
tx_vlan_reset(port_id);
- ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_QINQ_INSERT;
+ ports[port_id].dev_conf.txmode.offloads |= (DEV_TX_OFFLOAD_VLAN_INSERT |
+ DEV_TX_OFFLOAD_QINQ_INSERT);
ports[port_id].tx_vlan_id = vlan_id;
ports[port_id].tx_vlan_id_outer = vlan_id_outer;
}
--
2.8.4
next prev parent reply other threads:[~2019-04-05 7:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:48 [dpdk-dev] [PATCH] app/testpmd: fix tx vlan and qinq insert enable Nithin Kumar Dabilpuram
2019-03-01 16:29 ` Ferruh Yigit
2019-03-18 9:56 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency Nithin Kumar Dabilpuram
2019-03-18 9:56 ` Nithin Kumar Dabilpuram
2019-03-18 9:56 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable Nithin Kumar Dabilpuram
2019-03-18 9:56 ` Nithin Kumar Dabilpuram
2019-03-26 17:40 ` Iremonger, Bernard
2019-03-26 17:40 ` Iremonger, Bernard
2019-03-21 17:11 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency Ferruh Yigit
2019-03-21 17:11 ` Ferruh Yigit
2019-03-26 17:33 ` Iremonger, Bernard
2019-03-26 17:33 ` Iremonger, Bernard
2019-03-27 9:52 ` Iremonger, Bernard
2019-03-27 9:52 ` Iremonger, Bernard
2019-03-31 18:58 ` [dpdk-dev] [EXT] " Nithin Kumar Dabilpuram
2019-03-31 18:58 ` Nithin Kumar Dabilpuram
2019-04-01 19:10 ` Ferruh Yigit
2019-04-01 19:10 ` Ferruh Yigit
2019-04-02 2:35 ` Wang, Xiao W
2019-04-02 2:35 ` Wang, Xiao W
2019-04-05 7:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Nithin Kumar Dabilpuram
2019-04-05 7:36 ` Nithin Kumar Dabilpuram
2019-04-05 7:36 ` Nithin Kumar Dabilpuram [this message]
2019-04-05 7:36 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix Tx QinQ set Nithin Kumar Dabilpuram
2019-04-05 13:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Ferruh Yigit
2019-04-05 13:36 ` Ferruh Yigit
2019-04-05 12:04 ` [dpdk-dev] [PATCH v4 " Nithin Dabilpuram
2019-04-05 12:04 ` Nithin Dabilpuram
2019-04-05 12:04 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix Tx QinQ set Nithin Dabilpuram
2019-04-05 12:04 ` Nithin Dabilpuram
2019-04-05 12:06 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: fix Tx VLAN and QinQ dependency Ferruh Yigit
2019-04-05 12:06 ` Ferruh Yigit
2019-04-05 13:10 ` Nithin Kumar D
2019-04-05 13:10 ` Nithin Kumar D
2019-04-05 13:32 ` Ferruh Yigit
2019-04-05 13:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405073558.9930-2-ndabilpuram@marvell.com \
--to=ndabilpuram@marvell.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).