From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>,
David Harton <dharton@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation
Date: Fri, 5 Apr 2019 07:49:13 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153363E84@SHSMSX103.ccr.corp.intel.com> (raw)
Message-ID: <20190405074913.rWnymO0TQ70iIRrljsfq1Put8Zz3hijPn5Ir9wpyv2U@z> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07ECE373@PGSMSX103.gar.corp.intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, April 3, 2019 10:26 AM
> To: David Harton <dharton@cisco.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation
>
> HI,
>
> Why not add some more code
> "
> if (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER)
> dev->data->scattered_rx = 1;
> "
>
> Into ixgbevf_dev_rx_init() to enable scatter mode when start device?
>
>
> Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton
> > Sent: Wednesday, April 3, 2019 9:19 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; David Harton <dharton@cisco.com>
> > Subject: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation
> >
> > Currently, if requested MTU is bigger than mbuf size and scattered
> > receive is not enabled, setting MTU to that value fails.
> >
> > This patch allows setting this special MTU when device is stopped,
> > because scattered_rx will be re-configured during next port start and
> > driver may enable scattered receive according new MTU value.
> >
> > After this patch, driver may select different receive function
> > automatically after MTU set, according MTU values selected.
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2019-04-05 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 1:18 David Harton
2019-04-03 1:18 ` David Harton
2019-04-03 2:25 ` Zhao1, Wei
2019-04-03 2:25 ` Zhao1, Wei
2019-04-03 12:36 ` David Harton (dharton)
2019-04-03 12:36 ` David Harton (dharton)
2019-04-08 6:13 ` Zhao1, Wei
2019-04-08 6:13 ` Zhao1, Wei
2019-04-05 7:49 ` Zhang, Qi Z [this message]
2019-04-05 7:49 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153363E84@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).