DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: stop lldp by default
Date: Fri, 5 Apr 2019 08:01:34 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153363EAA@SHSMSX103.ccr.corp.intel.com> (raw)
Message-ID: <20190405080134.uTEe1cOewnDkrIkhGndj9mNs6EK9ztKGswiT1-mTw0k@z> (raw)
In-Reply-To: <20190403155921.184963-1-qiming.yang@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Wednesday, April 3, 2019 11:59 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: stop lldp by default
> 
> This patch stopped lldp by default to avoid the statistics error.
> 
> Fixes: f9cf4f864150 ("net/ice: support device initialization")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 1482ced..b3df282 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -11,6 +11,7 @@
> 
>  #include "base/ice_sched.h"
>  #include "base/ice_flow.h"
> +#include "base/ice_dcb.h"
>  #include "ice_ethdev.h"
>  #include "ice_rxtx.h"
> 
> @@ -1406,6 +1407,10 @@ ice_dev_init(struct rte_eth_dev *dev)
>  	/* Disable double vlan by default */
>  	ice_vsi_config_double_vlan(vsi, FALSE);
> 
> +	ret = ice_aq_stop_lldp(hw, TRUE, NULL);
> +	if (ret != ICE_SUCCESS)
> +		PMD_INIT_LOG(DEBUG, "Failed to stop lldp");

I think we need to warning user here if LLDP can't be stopped.

> +
>  	/* register callback func to eal lib */
>  	rte_intr_callback_register(intr_handle,
>  				   ice_interrupt_handler, dev);
> --
> 2.9.5


  parent reply	other threads:[~2019-04-05  8:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 15:59 Qiming Yang
2019-04-03 15:59 ` Qiming Yang
2019-04-05  8:01 ` Zhang, Qi Z [this message]
2019-04-05  8:01   ` Zhang, Qi Z
2019-04-08 16:02 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2019-04-08 16:02   ` Qiming Yang
2019-04-12 10:10   ` [dpdk-dev] [PATCH v3] " Qiming Yang
2019-04-12 10:10     ` Qiming Yang
2019-04-12 12:24     ` Zhang, Qi Z
2019-04-12 12:24       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E7061153363EAA@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).