From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nithind1988@gmail.com>
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com
[209.85.210.179]) by dpdk.org (Postfix) with ESMTP id 51D6B1B4CB
for <dev@dpdk.org>; Fri, 5 Apr 2019 14:04:18 +0200 (CEST)
Received: by mail-pf1-f179.google.com with SMTP id z5so3183770pfn.3
for <dev@dpdk.org>; Fri, 05 Apr 2019 05:04:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=tDoIIFqtTcPi7/xdARNLjE6HNG83KM7EDxtkqIB+9Z8=;
b=aAk3ILVGS4mmV52ESyRoRm8Wi60DxORNdcPVBv9qRktadRR3zRQUVwrxtO36DNsYWT
/jBuFKD00pe4DMXXIu4Z+7kSEZX8EuXGbIih/b3iCqU4F0wa7LwIW/XFR7SYaWQe8/ER
jbyTscbvkIal34lxsdPJReHjeP3QA91hp1Ukp+vP5EF+U2/oEH54RZZenx6PbT6SSeY6
ADWOzgdGhMiuCLbibgYgXyX6iAScF5WP4HRJnxgaGxJb+A0hI+rI2ov1FVUGQGvC+g8w
F2NCmJ1V/RXYgtY3j1PcEjznF3+n3HKvfsrToh0FlM+L8TvY+sQRMPGt8zP4d7OhUkZt
kuNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=tDoIIFqtTcPi7/xdARNLjE6HNG83KM7EDxtkqIB+9Z8=;
b=fF7VfoVvuCeijNs0ecTvVEPRBa6RoWXtpCpuw4F5HPXCs7qtOnAfPaST1q+MxdggjJ
9DrktJme08riFJA9HdPu7cvajgcOGBiEk/uWtBxffw5iM3y+ZKNqCYC60/XNV736vZIs
aNBHhi8ruHds4vI29J3x6oD8fCX9NvPfPPs7N2ICvcgKjIxlcnBu2Pgj6TaKGZgBSeRp
u4szmlryAIZoRpuRBOhKHlaJ2jAtZxKrHfqGoXlUIbL2Dy6ofb4IZbMbwlTgqPSv9o5/
/OSx7aGFG9puvElipLNdkPpweQjpanZjeH0tl/j3L8w7Xovtp/RBInSxSfNy1lx9ITP7
p6eg==
X-Gm-Message-State: APjAAAXqLFIFi9nyzc4Mdj1Xbn3+QymeBwMhHQcCslQEiB/dZCNB02+I
G03mjKlcSnhgsINhFiEpIh4=
X-Google-Smtp-Source: APXvYqzXr5CGOXbxNUal8WwBVshXcnHyOwtBTtdWJSyK60/vQZpTJrYN9xc8vGGv83BeU5W02/VhmQ==
X-Received: by 2002:a63:720c:: with SMTP id n12mr11702277pgc.348.1554465857219;
Fri, 05 Apr 2019 05:04:17 -0700 (PDT)
Received: from hyd1434t5810.caveonetworks.com ([115.113.156.2])
by smtp.gmail.com with ESMTPSA id r87sm33786816pfa.71.2019.04.05.05.04.14
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Fri, 05 Apr 2019 05:04:16 -0700 (PDT)
From: Nithin Dabilpuram <nithind1988@gmail.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
Wang Xiao W <xiao.w.wang@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>, shahafs@mellanox.com
Date: Fri, 5 Apr 2019 17:34:03 +0530
Message-Id: <20190405120403.5446-2-nithind1988@gmail.com>
X-Mailer: git-send-email 2.8.4
In-Reply-To: <20190405120403.5446-1-nithind1988@gmail.com>
References: <20190219064840.12046-1-ndabilpuram@marvell.com>
<20190405120403.5446-1-nithind1988@gmail.com>
Subject: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix Tx QinQ set
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 12:04:19 -0000
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shahafs@mellanox.com
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v4:
* Resend v3 from different mailserver to avoid
CRLF
v3:
* Rename headline
v2:
* Split change into two seperate patches as suggested.
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 010e26d..f9cb129 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3006,7 +3006,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)
}
tx_vlan_reset(port_id);
- ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_QINQ_INSERT;
+ ports[port_id].dev_conf.txmode.offloads |= (DEV_TX_OFFLOAD_VLAN_INSERT |
+ DEV_TX_OFFLOAD_QINQ_INSERT);
ports[port_id].tx_vlan_id = vlan_id;
ports[port_id].tx_vlan_id_outer = vlan_id_outer;
}
--
2.8.4
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id F0D2CA0679
for <public@inbox.dpdk.org>; Fri, 5 Apr 2019 14:04:24 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C094D1B4D1;
Fri, 5 Apr 2019 14:04:20 +0200 (CEST)
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com
[209.85.210.179]) by dpdk.org (Postfix) with ESMTP id 51D6B1B4CB
for <dev@dpdk.org>; Fri, 5 Apr 2019 14:04:18 +0200 (CEST)
Received: by mail-pf1-f179.google.com with SMTP id z5so3183770pfn.3
for <dev@dpdk.org>; Fri, 05 Apr 2019 05:04:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=tDoIIFqtTcPi7/xdARNLjE6HNG83KM7EDxtkqIB+9Z8=;
b=aAk3ILVGS4mmV52ESyRoRm8Wi60DxORNdcPVBv9qRktadRR3zRQUVwrxtO36DNsYWT
/jBuFKD00pe4DMXXIu4Z+7kSEZX8EuXGbIih/b3iCqU4F0wa7LwIW/XFR7SYaWQe8/ER
jbyTscbvkIal34lxsdPJReHjeP3QA91hp1Ukp+vP5EF+U2/oEH54RZZenx6PbT6SSeY6
ADWOzgdGhMiuCLbibgYgXyX6iAScF5WP4HRJnxgaGxJb+A0hI+rI2ov1FVUGQGvC+g8w
F2NCmJ1V/RXYgtY3j1PcEjznF3+n3HKvfsrToh0FlM+L8TvY+sQRMPGt8zP4d7OhUkZt
kuNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=tDoIIFqtTcPi7/xdARNLjE6HNG83KM7EDxtkqIB+9Z8=;
b=fF7VfoVvuCeijNs0ecTvVEPRBa6RoWXtpCpuw4F5HPXCs7qtOnAfPaST1q+MxdggjJ
9DrktJme08riFJA9HdPu7cvajgcOGBiEk/uWtBxffw5iM3y+ZKNqCYC60/XNV736vZIs
aNBHhi8ruHds4vI29J3x6oD8fCX9NvPfPPs7N2ICvcgKjIxlcnBu2Pgj6TaKGZgBSeRp
u4szmlryAIZoRpuRBOhKHlaJ2jAtZxKrHfqGoXlUIbL2Dy6ofb4IZbMbwlTgqPSv9o5/
/OSx7aGFG9puvElipLNdkPpweQjpanZjeH0tl/j3L8w7Xovtp/RBInSxSfNy1lx9ITP7
p6eg==
X-Gm-Message-State: APjAAAXqLFIFi9nyzc4Mdj1Xbn3+QymeBwMhHQcCslQEiB/dZCNB02+I
G03mjKlcSnhgsINhFiEpIh4=
X-Google-Smtp-Source: APXvYqzXr5CGOXbxNUal8WwBVshXcnHyOwtBTtdWJSyK60/vQZpTJrYN9xc8vGGv83BeU5W02/VhmQ==
X-Received: by 2002:a63:720c:: with SMTP id n12mr11702277pgc.348.1554465857219;
Fri, 05 Apr 2019 05:04:17 -0700 (PDT)
Received: from hyd1434t5810.caveonetworks.com ([115.113.156.2])
by smtp.gmail.com with ESMTPSA id r87sm33786816pfa.71.2019.04.05.05.04.14
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Fri, 05 Apr 2019 05:04:16 -0700 (PDT)
From: Nithin Dabilpuram <nithind1988@gmail.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
Wang Xiao W <xiao.w.wang@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>, shahafs@mellanox.com
Date: Fri, 5 Apr 2019 17:34:03 +0530
Message-Id: <20190405120403.5446-2-nithind1988@gmail.com>
X-Mailer: git-send-email 2.8.4
In-Reply-To: <20190405120403.5446-1-nithind1988@gmail.com>
References: <20190219064840.12046-1-ndabilpuram@marvell.com>
<20190405120403.5446-1-nithind1988@gmail.com>
Subject: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix Tx QinQ set
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190405120403.Tvo2fnklg4wZk3PCocU4P2YtxuwNRdCdKaQCUK8eFVo@z>
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with
DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes
both vlan id's as arguments.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: shahafs@mellanox.com
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v4:
* Resend v3 from different mailserver to avoid
CRLF
v3:
* Rename headline
v2:
* Split change into two seperate patches as suggested.
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 010e26d..f9cb129 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3006,7 +3006,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer)
}
tx_vlan_reset(port_id);
- ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_QINQ_INSERT;
+ ports[port_id].dev_conf.txmode.offloads |= (DEV_TX_OFFLOAD_VLAN_INSERT |
+ DEV_TX_OFFLOAD_QINQ_INSERT);
ports[port_id].tx_vlan_id = vlan_id;
ports[port_id].tx_vlan_id_outer = vlan_id_outer;
}
--
2.8.4