DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf
@ 2019-04-05 13:13 Tom Barbette
  2019-04-05 13:13 ` Tom Barbette
  2019-04-05 13:44 ` Ferruh Yigit
  0 siblings, 2 replies; 4+ messages in thread
From: Tom Barbette @ 2019-04-05 13:13 UTC (permalink / raw)
  To: dev; +Cc: thomas, ferruh.yigit, arybchenko, Tom Barbette

Clarify the fact that mask bits should be set in rte_eth_reta_query.

v2:
- Change documentation string as suggested by Ferruh

Signed-off-by: Tom Barbette <barbette@kth.se>
---
 lib/librte_ethdev/rte_ethdev.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index e254da8b1..2a49fd2e2 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -2941,7 +2941,8 @@ int rte_eth_dev_rss_reta_update(uint16_t port_id,
  * @param port_id
  *   The port identifier of the Ethernet device.
  * @param reta_conf
- *   RETA to query.
+ *   RETA to query. For each requested reta entry, corresponding bit
+ *   in mask must be set.
  * @param reta_size
  *   Redirection table size. The table size can be queried by
  *   rte_eth_dev_info_get().
-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf
  2019-04-05 13:13 [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf Tom Barbette
@ 2019-04-05 13:13 ` Tom Barbette
  2019-04-05 13:44 ` Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Barbette @ 2019-04-05 13:13 UTC (permalink / raw)
  To: dev; +Cc: thomas, ferruh.yigit, arybchenko, Tom Barbette

Clarify the fact that mask bits should be set in rte_eth_reta_query.

v2:
- Change documentation string as suggested by Ferruh

Signed-off-by: Tom Barbette <barbette@kth.se>
---
 lib/librte_ethdev/rte_ethdev.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index e254da8b1..2a49fd2e2 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -2941,7 +2941,8 @@ int rte_eth_dev_rss_reta_update(uint16_t port_id,
  * @param port_id
  *   The port identifier of the Ethernet device.
  * @param reta_conf
- *   RETA to query.
+ *   RETA to query. For each requested reta entry, corresponding bit
+ *   in mask must be set.
  * @param reta_size
  *   Redirection table size. The table size can be queried by
  *   rte_eth_dev_info_get().
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf
  2019-04-05 13:13 [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf Tom Barbette
  2019-04-05 13:13 ` Tom Barbette
@ 2019-04-05 13:44 ` Ferruh Yigit
  2019-04-05 13:44   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-04-05 13:44 UTC (permalink / raw)
  To: Tom Barbette, dev; +Cc: thomas, arybchenko

On 4/5/2019 2:13 PM, Tom Barbette wrote:
> Clarify the fact that mask bits should be set in rte_eth_reta_query.
> 
> v2:
> - Change documentation string as suggested by Ferruh
> 
> Signed-off-by: Tom Barbette <barbette@kth.se>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf
  2019-04-05 13:44 ` Ferruh Yigit
@ 2019-04-05 13:44   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-04-05 13:44 UTC (permalink / raw)
  To: Tom Barbette, dev; +Cc: thomas, arybchenko

On 4/5/2019 2:13 PM, Tom Barbette wrote:
> Clarify the fact that mask bits should be set in rte_eth_reta_query.
> 
> v2:
> - Change documentation string as suggested by Ferruh
> 
> Signed-off-by: Tom Barbette <barbette@kth.se>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-05 13:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05 13:13 [dpdk-dev] [PATCH v2] reta_query: Doc requirements on reta_conf Tom Barbette
2019-04-05 13:13 ` Tom Barbette
2019-04-05 13:44 ` Ferruh Yigit
2019-04-05 13:44   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).