From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6A180A0679 for ; Fri, 5 Apr 2019 16:57:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37CB81B520; Fri, 5 Apr 2019 16:57:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B11661B4F2 for ; Fri, 5 Apr 2019 16:57:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 07:57:19 -0700 X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="131760932" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES128-SHA; 05 Apr 2019 07:57:15 -0700 To: Ferruh Yigit , Nikhil Agarwal , nikhil.agarwal@nxp.com, hemant.agrawal@nxp.com Cc: Thomas Monjalon , dev@dpdk.org, david.hunt@intel.com, arybchenko@solarflare.com, shahafs@mellanox.com References: <20171212100520.20502-1-nikhil.agarwal@linaro.org> <1867579.zxL6BAlCOx@xps> From: "Yigit, Ferruh" Message-ID: Date: Fri, 5 Apr 2019 15:57:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405145714.bX_1HuJaBnT2LTik-QflVSxK-JTyGhh6dF9q5eFePeA@z> On 4/5/2019 3:55 PM, Ferruh Yigit wrote: > On 5/22/2018 11:17 PM, Thomas Monjalon wrote: >> 12/12/2017 11:05, Nikhil Agarwal: >>> Currently, if the rte_eth_rx_burst() function returns a value less than >>> *nb_pkts*, the application will assume that no more packets are present. >>> >>> Some of the hw queue based hardware can only support smaller burst for RX >>> and TX and thus break the expectation of the rx_burst API. >>> >>> This patch adds support to provide the maximum burst size that can be >>> supported by a given PMD. The dev_info is being memset to '0' in >>> rte_ethdev library. The value of '0' indicates that any value for burst >>> size can be supported i.e. no change for existing PMDs. >>> >>> The application can now use the lowest available max_burst_size value >>> for rte_eth_rx_burst. >>> >>> Signed-off-by: Nikhil Agarwal >>> --- >>> @@ -1047,6 +1047,7 @@ struct rte_eth_dev_info { >>> /** Configured number of rx/tx queues */ >>> uint16_t nb_rx_queues; /**< Number of RX queues. */ >>> uint16_t nb_tx_queues; /**< Number of TX queues. */ >>> + uint16_t max_burst_size; /**< MAX burst size, 0 for no limit. */ >>> }; >> >> What is the status of this proposal? >> >> Recently, the preferred tuning have been added by >> "ethdev: support PMD-tuned Tx/Rx parameters" >> http://dpdk.org/commit/3be82f5cc5 > > Hi Nikhil, Hemant, > > PMD returning preferred 'burst_size' support already added, I guess this > patchset is no more valid. I am updating this as rejected. > > If something is missing or there are still some relevant pieces in this patch, > please send as a new version on top of latest head. As reference, mentioned patches: https://patches.dpdk.org/patch/32112/ https://patches.dpdk.org/patch/32113/ https://patches.dpdk.org/patch/32114/