From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B9F0FA0096 for ; Mon, 8 Apr 2019 08:00:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 582FE2C55; Mon, 8 Apr 2019 08:00:11 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10051.outbound.protection.outlook.com [40.107.1.51]) by dpdk.org (Postfix) with ESMTP id E56952C55 for ; Mon, 8 Apr 2019 08:00:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4VlB5yJ6JQPPWk8e9B3hknugYXns9yzMYnFwX0W0+s=; b=X4/BOF/2kBpdurCbiA+djlgExbD9NHwOLaWVrC0rVFW62C947OOLP+zIvrslQBuFk/nDzVh8lfweGNFKIro7mf6SjsL0ydaovnte/TEYpveRNR1JgFooIAlIhfYrISj863epWZRKSFn5/GUsApYh8fmixoiKT+ICTHL576YiOkg= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3745.eurprd05.prod.outlook.com (52.133.50.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Mon, 8 Apr 2019 06:00:07 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Mon, 8 Apr 2019 06:00:07 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH v2 1/1] net/mlx5: fix typos in comments Thread-Index: AQHU641hm3KBA22UcEaDA+RDCSv2taYxyLMg Date: Mon, 8 Apr 2019 06:00:07 +0000 Message-ID: References: <1554190805-376-1-git-send-email-viacheslavo@mellanox.com> <1554454530-24103-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1554454530-24103-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b349e71e-91df-45f1-ee45-08d6bbe773dd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3745; x-ms-traffictypediagnostic: AM0PR0502MB3745: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(86362001)(66066001)(229853002)(99286004)(305945005)(76176011)(97736004)(8936002)(25786009)(7696005)(6506007)(256004)(52536014)(966005)(26005)(478600001)(2906002)(14454004)(186003)(6436002)(33656002)(6246003)(5660300002)(106356001)(102836004)(105586002)(8676002)(7736002)(110136005)(55016002)(486006)(53936002)(6306002)(9686003)(316002)(74316002)(81166006)(2501003)(14444005)(5024004)(71200400001)(71190400001)(11346002)(476003)(3846002)(6116002)(446003)(81156014)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3745; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: azRpWDll8Z34cFYVj6eJhcB/cyid5MU+UmHl+gstggeCLTVGBIgakQpNfauE8QitxBjaETaAomGViXoWr7ESitHsy/S38OP2/Qyk0UYIGbebXZpzke8OiE2eqWA2MUFuZ4rz1bxSWQJ6ddsRyFvJakSHVc0xRLliq0X+3rQ7wAmiZdFjLdDlWsACPGk7o2M1gghmSWAR91OG58MJ20kfmR2/IIqzvPxszqoGdhWqKmlD7yxgqvBKBeFbIcEywAQ5XqYrOIZAvyMaD/6EU/GyTID4QBsTl95fSGC+uYFPhQJ2Fj3udAqHYSI6QFaCWxqujKz68u9k+zE/MJ6OhheGZLfvt4OS6dxPhsJL5DoJ19x3c77zisUaAorIsz2CvWsj+EUtpdb6zYMGHmnaZOd21TksLg4MwABma8ax+QP6YzU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b349e71e-91df-45f1-ee45-08d6bbe773dd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 06:00:07.4156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix typos in comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408060007.LA7Vj7hYoaeMwCRAaMoxVE8YCd0OktoMll5dEst-Jr8@z> Friday, April 5, 2019 11:56 AM, Viacheslav Ovsiienko: > Subject: [PATCH v2 1/1] net/mlx5: fix typos in comments >=20 > Fixes: 299d7dc28c37 ("net/mlx5: add representor recognition on Linux 5.x"= ) >=20 > Signed-off-by: Viacheslav Ovsiienko >=20 Applied to next-net-mlx, thanks. Pay attention the below comments should be after the "---" to not be includ= ed on the commit log. > v2: > rebasing only > v1: > http://patches.dpdk.org/patch/52056/ >=20 > --- > drivers/net/mlx5/mlx5.c | 14 +++++++------- > drivers/net/mlx5/mlx5_flow_tcf.c | 22 +++++++++++----------- > 2 files changed, 18 insertions(+), 18 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > f571ba2..09f4a21 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -155,7 +155,7 @@ struct mlx5_dev_spawn_data { > * port dedicated IB device, the context will be used by only given > * port due to unification. > * > - * Routine first searches the context for the spesified IB device name, > + * Routine first searches the context for the specified IB device name, > * if found the shared context assumed and reference counter is > incremented. > * If no context found the new one is created and initialized with speci= fied > * IB device context and parameters. > @@ -185,7 +185,7 @@ struct mlx5_dev_spawn_data { > goto exit; > } > } > - /* No device found, we have to create new sharted context. */ > + /* No device found, we have to create new shared context. */ > assert(spawn->max_port); > sh =3D rte_zmalloc("ethdev shared ib context", > sizeof(struct mlx5_ibv_shared) + > @@ -305,7 +305,7 @@ struct mlx5_dev_spawn_data { > /** > * Initialize DR related data within private structure. > * Routine checks the reference counter and does actual > - * resources creation/iniialization only if counter is zero. > + * resources creation/initialization only if counter is zero. > * > * @param[in] priv > * Pointer to the private device data structure. > @@ -1353,7 +1353,7 @@ struct mlx5_dev_spawn_data { > * Currently we support single E-Switch per PF configurations > * only and vport_id field contains the vport index for > * associated VF, which is deduced from representor port name. > - * For exapmple, let's have the IB device port 10, it has > + * For example, let's have the IB device port 10, it has > * attached network device eth0, which has port name attribute > * pf0vf2, we can deduce the VF number as 2, and set vport index > * as 3 (2+1). This assigning schema should be changed if the @@ - > 1595,7 +1595,7 @@ struct mlx5_dev_spawn_data { > mlx5_set_link_up(eth_dev); > /* > * Even though the interrupt handler is not installed yet, > - * interrupts will still trigger on the asyn_fd from > + * interrupts will still trigger on the async_fd from > * Verbs context returned by ibv_open_device(). > */ > mlx5_link_update(eth_dev, 0); > @@ -1772,7 +1772,7 @@ struct mlx5_dev_spawn_data { > } > ibv_match[nd] =3D NULL; > if (!nd) { > - /* No device macthes, just complain and bail out. */ > + /* No device matches, just complain and bail out. */ > mlx5_glue->free_device_list(ibv_list); > DRV_LOG(WARNING, > "no Verbs device matches PCI device " PCI_PRI_FMT > "," > @@ -1805,7 +1805,7 @@ struct mlx5_dev_spawn_data { >=20 > if (np > 1) { > /* > - * Signle IB device with multiple ports found, > + * Single IB device with multiple ports found, > * it may be E-Switch master device and representors. > * We have to perform identification trough the ports. > */ > diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c > b/drivers/net/mlx5/mlx5_flow_tcf.c > index 3006f83..fc04c9d 100644 > --- a/drivers/net/mlx5/mlx5_flow_tcf.c > +++ b/drivers/net/mlx5/mlx5_flow_tcf.c > @@ -2916,7 +2916,7 @@ struct pedit_parser { > * VXLAN VNI in 24-bit wire format. > * > * @return > - * VXLAN VNI as a 32-bit integer value in network endian. > + * VXLAN VNI as a 32-bit integer value in network endianness. > */ > static inline rte_be32_t > vxlan_vni_as_be32(const uint8_t vni[3]) @@ -4051,7 +4051,7 @@ struct > pedit_parser { > nlh->nlmsg_flags |=3D NLM_F_ACK; > ret =3D mnl_socket_sendto(tcf->nl, nlh, nlh->nlmsg_len); > if (ret <=3D 0) { > - /* Message send error occurres. */ > + /* Message send error occurred. */ > rte_errno =3D errno; > return -rte_errno; > } > @@ -4307,7 +4307,7 @@ struct tcf_nlcb_context { > * @param[in] tcf > * Context object initialized by mlx5_flow_tcf_context_create(). > * @param[in] ifindex > - * Network inferface index to perform cleanup. > + * Network interface index to perform cleanup. > */ > static void > flow_tcf_encap_local_cleanup(struct mlx5_flow_tcf_context *tcf, @@ - > 4343,7 +4343,7 @@ struct tcf_nlcb_context { } >=20 > /** > - * Collect neigh permament rules on specified network device. > + * Collect neigh permanent rules on specified network device. > * This is callback routine called by libmnl mnl_cb_run() in loop for > * every message in received packet. > * > @@ -4392,7 +4392,7 @@ struct tcf_nlcb_context { > } > if (!na_mac || !na_ip) > return 1; > - /* Neigh rule with permenent attribute found. */ > + /* Neigh rule with permanent attribute found. */ > size =3D MNL_ALIGN(sizeof(struct nlmsghdr)) + > MNL_ALIGN(sizeof(struct ndmsg)) + > SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) + @@ -4431,7 +4431,7 > @@ struct tcf_nlcb_context { > * @param[in] tcf > * Context object initialized by mlx5_flow_tcf_context_create(). > * @param[in] ifindex > - * Network inferface index to perform cleanup. > + * Network interface index to perform cleanup. > */ > static void > flow_tcf_encap_neigh_cleanup(struct mlx5_flow_tcf_context *tcf, @@ - > 4599,7 +4599,7 @@ struct tcf_nlcb_context { > * Note that an implicit route is maintained by the kernel due to the > * presence of a peer address (IFA_ADDRESS). > * > - * These rules are used for encapsultion only and allow to assign > + * These rules are used for encapsulation only and allow to assign > * the outer tunnel source IP address. > * > * @param[in] tcf > @@ -5018,7 +5018,7 @@ struct tcf_nlcb_context { >=20 > /** > * Releases VXLAN encap rules container by pointer. Decrements the > - * reference cointer and deletes the container if counter is zero. > + * reference counter and deletes the container if counter is zero. > * > * @param[in] irule > * VXLAN rule container pointer to release. > @@ -5042,7 +5042,7 @@ struct tcf_nlcb_context { > * @param[in] tcf > * Context object initialized by mlx5_flow_tcf_context_create(). > * @param[in] vtep > - * Object represinting the network device to delete. Memory > + * Object representing the network device to delete. Memory > * allocated for this object is freed by routine. > */ > static void > @@ -5268,7 +5268,7 @@ struct tcf_nlcb_context { } >=20 > /** > - * Aqcuire target interface index for VXLAN tunneling encapsulation. > + * Acquire target interface index for VXLAN tunneling encapsulation. > * > * @param[in] tcf > * Context object initialized by mlx5_flow_tcf_context_create(). > @@ -5601,7 +5601,7 @@ struct tcf_nlcb_query { > /** > * Fetch the applied rule handle. This is callback routine called by > * libmnl mnl_cb_run() in loop for every message in received packet. > - * When the NLM_F_ECHO flag i sspecified the kernel sends the created > + * When the NLM_F_ECHO flag is specified the kernel sends the created > * rule descriptor back to the application and we can retrieve the > * actual rule handle from updated descriptor. > * > -- > 1.8.3.1