From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B1ECDA0096 for ; Mon, 8 Apr 2019 08:00:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 862734CA9; Mon, 8 Apr 2019 08:00:15 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30080.outbound.protection.outlook.com [40.107.3.80]) by dpdk.org (Postfix) with ESMTP id 1792F2BD8 for ; Mon, 8 Apr 2019 08:00:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JUHlb81qjQqkVhbpnKOuUx/LK0p1+tKvAC7asx8aupk=; b=S9Jv6CYQoTQSK84Ld50Fq4hWJHjoEF4Vcn8AXrorTLLcbtByaLt4PO5CndD144uMCxtx/0VGRNUBtCE4FSOJyuNT5/NMdzL3g69RClH+RdrsV9mPXIxX7ie0eAEXuFRKeLu57slu0xQco7LHRLOBOlRqabjRvoMPW7QLVxO49q8= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3745.eurprd05.prod.outlook.com (52.133.50.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Mon, 8 Apr 2019 06:00:11 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Mon, 8 Apr 2019 06:00:11 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old kernel drivers Thread-Index: AQHU67Mk1i6z8uY1C06KXHfa15KCkKYxyKhQ Date: Mon, 8 Apr 2019 06:00:11 +0000 Message-ID: References: <1554300882-23990-1-git-send-email-viacheslavo@mellanox.com> <1554470755-14183-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1554470755-14183-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82951e32-1c9e-4b49-73ce-08d6bbe7763a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3745; x-ms-traffictypediagnostic: AM0PR0502MB3745: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(86362001)(66066001)(229853002)(99286004)(305945005)(76176011)(97736004)(8936002)(25786009)(7696005)(6506007)(256004)(52536014)(966005)(26005)(45080400002)(478600001)(2906002)(14454004)(186003)(6436002)(33656002)(6246003)(5660300002)(106356001)(102836004)(105586002)(7736002)(110136005)(55016002)(486006)(53936002)(6306002)(9686003)(316002)(74316002)(81166006)(2501003)(14444005)(71200400001)(71190400001)(11346002)(476003)(3846002)(6116002)(446003)(81156014)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3745; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ABdiM0O0WWZ5zVBizW7kyOR10kkMpOqiZkfPIcUcI5yHzzXaLIL90BS4gvPrtidGPom1t7kfTLi5J6D07QqYLJ6LDORT3tEKyZ5UYsm3TOtp/pdNwJxUw2Cy/JcosMkhNDqQ9OmtLcqcIitpUBTOElOgJ7mF0OgGyl3yG/Uq4WuMVjCNipq4s+DAzelksN8sajY4qxufd6Y4E7K2QeRoMwO+zbdOhqr1Ww1BwkewIi/06AnlI8D6CYchnkkPh7PsN9i9o91M8gMc9lxKLFDm+SpnyeKo1JEP4wne9FG3YRhwL+LfYDzy29O+61QGTb7wtue4WqYB1TMqvGlqpDrfZU8bxotJADx4yjqrNLEHUxsMVfcOEfBxLh+Tr/rSmn0R/IWHEB3nMrF2fKMBt3yVsFapx0sAGKisExfHwFS0DTM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82951e32-1c9e-4b49-73ce-08d6bbe7763a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 06:00:11.3864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408060011.F-afDpZiTDgCl6D2OTiLXtnEHlgCaYu_S0ohd6SnjDo@z> Friday, April 5, 2019 4:26 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old > kernel drivers >=20 > Retrieving network interface index via Netlink fails in case of old ib_co= re > kernel driver installed - mlx5_nl_ifindex() routine fails due to > RDMA_NLDEV_ATTR_NDEV_INDEX attribute is not supported by the old > driver. >=20 > The patch allowing to retrieve the network interface index and name via > Netlink [1]. So, the problem depends on ib_core module version - 4.16 > supports getting ifindex via Netlink, 4.15 does not. >=20 > This error was ignored in previous versions of MLX5 PMD probing routine. = For > single device ifindex was retrieved via sysfs and link control was not lo= st, so > problem just was not noticed. > In order to support MLX5 PMD functioning over old kernel driver this patc= h > adds ifindex retrieving via sysfs into probing routine. > It is worth to note this method works for master/standalone device only. >=20 > [1] > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww > .spinics.net%2Flists%2Flinux- > rdma%2Fmsg62948.html&data=3D02%7C01%7Cshahafs%40mellanox.com > %7C0968f75813714ee221ac08d6b9ca45ea%7Ca652971c7d2e4d9ba6a4d149256 > f461b%7C0%7C0%7C636900675741983483&sdata=3DONhYWfZ7Y4zEOunEd > wx9H0zyOiFIyzHDxnw7MXtTIAk%3D&reserved=3D0 > Linux tree: 5b2cc79d (Leon Romanovsky 2018-03-27 20:40:49 +0300 270) >=20 > Fixes: ad74bc619504 ("net/mlx5: support multiport IB device during probin= g") >=20 > Signed-off-by: Viacheslav Ovsiienko Applied to next-net-mlx, thanks.=20