From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 51CADA0096 for ; Mon, 8 Apr 2019 10:24:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BEEC2BC9; Mon, 8 Apr 2019 10:24:42 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 930A9DED for ; Mon, 8 Apr 2019 10:24:40 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id e13so10276547ioq.6 for ; Mon, 08 Apr 2019 01:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ja7lH1tcH91MoVpIYa7L6lYfPq4HkDvuUMNnrPQOs5E=; b=vCNgkMonPg115wNr9iWBYmaJMYi2hHjh47eGh0VJqVpu1myDoMMdfWD1Ds+EF0sNiC 5xw3GGCYbfdlj5t+deqV1KT0WjLStvlT3t4DBkCfhEn9eOfE0qKq5QawONeckxFzDQxM mhoyEkgi3TDQTXhmqvywAAqmOSmCczZk3U3sCnlj1NcVXXzAiwy6WRZXzhtbh3+d+fv9 eRcqu66xaTGGljgt5wHkpkeqCz9jIGjhmSKLIIvYterLpjMN8HZ9tR0jhG4VQNEQM/8K ufyCluoG4ZaYmWzLLhtsqSp+aAIxsI7pqx8kOn7c6iDWqUeLIXT4cJ3yiFPeqp5fHWAq JKtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ja7lH1tcH91MoVpIYa7L6lYfPq4HkDvuUMNnrPQOs5E=; b=V4lFr+jlpWR+AMoDOdQgA3qNspGIPzZx/XGkUghcQ/qDc5zs1XZPmaGpmzNXRjAzYf HbrxteVUwtO0k9GJDi1qVrpHy915VniaXflzescHJ+G65dRk2NbFWJMNf5uNtzhE1GIG eeiddF63vyk7YWH26a8W9A47ArqtXAQSgtaTdsq/OhNanlhjj5keja4K6AdrAV/NTLiP yM3qUVP4qB4IDVoMv4oYod77JspiLmptMP+lD6gf6D973Djn6zGcBVLV7JUPWeuSvILb zA4x8NInb4Qqz51b1ljtTuZXqD8TnsxFTguLH6nr9d7tUvmd6ndkscaYhzXxQYx8xaCG Zz/Q== X-Gm-Message-State: APjAAAVnn5+Ll4DbJpHgd1M7F9rxF62EQwM9ucc3pY9FSvJL/ake9pS7 wjxuHnwmJPTfp2u0N9StSolOGdRQ35soTOXPqQ== X-Google-Smtp-Source: APXvYqwg4F9eDwRQ0Hj4Jvgo7AWQ2vgMKSmSb9JAZkxyUfGvpOka0Lf6myRxID1FkSuqSMIb/8ghO14D+SgEAauoo6Q= X-Received: by 2002:a6b:fa0b:: with SMTP id p11mr8408918ioh.36.1554711879981; Mon, 08 Apr 2019 01:24:39 -0700 (PDT) MIME-Version: 1.0 References: <1516032969-23894-1-git-send-email-alan.dewar@att.com> <1516118822-6323-1-git-send-email-alan.dewar@att.com> In-Reply-To: From: Alan Dewar Date: Mon, 8 Apr 2019 09:24:29 +0100 Message-ID: To: Ferruh Yigit Cc: cristian.dumitrescu@intel.com, tomasz.kantecki@intel.com, Stephen Hemminger , dev@dpdk.org, Alan Dewar , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408082429.0EGRBnCH1mITtZ5996kU8p1pU4FfMqXuc7ubpSkMlMs@z> Hi Ferruh, We are still using this patch against DPDK 17.11 and 18.11 as part of the AT&T Vyatta NOS. It is needed to make WRED queues longer than 1024 packets work correctly. I'm afraid that I have no idea what is holding it up from being merged. Regards Alan On Fri, Apr 5, 2019 at 4:36 PM Ferruh Yigit wrote: > > On 1/16/2018 4:07 PM, alangordondewar@gmail.com wrote: > > From: Alan Dewar > > > > The RED code stores the weighted moving average in a 32-bit integer as > > a pseudo fixed-point floating number with 10 fractional bits. Twelve > > other bits are used to encode the filter weight, leaving just 10 bits > > for the queue length. This limits the maximum queue length supported > > by RED queues to 1024 packets. > > > > Introduce a new API to allow the RED scaling factor to be configured > > based upon maximum queue length. If this API is not called, the RED > > scaling factor remains at its default value. > > > > Added some new RED scaling unit-tests to test with RED queue-lengths > > up to 8192 packets long. > > > > Signed-off-by: Alan Dewar > > Hi Cristian, Alan, > > The v7 of this patch is sting without any comment for more than a year. > What is the status of this patch? Is it still valid? What is blocking it? > > For reference patch: > https://patches.dpdk.org/patch/33837/